Add support for configurable endpoints

Author: lbeckman314

main.go

@@ -9,7 +9,7 @@ import (
 	"example.com/shared"
 )
 
-func run(user string, dir string) (string, error) {
+func run(user string, host string, dir string) (string, error) {
 	m := &shared.Manager{}
 	defer m.Close()
 
@@ -18,7 +18,7 @@ func run(user string, dir string) (string, error) {
 		return "", fmt.Errorf("failed to get client: %w", err)
 	}
 
-	resp, err := authorize.Get(user, "http://localhost:8080/token?user=")
+	resp, err := authorize.Get(user, host)
 	if err != nil {
 		return "", fmt.Errorf("failed to authorize: %w", err)
 	}
@@ -33,12 +33,17 @@ func run(user string, dir string) (string, error) {
 }
 
 func main() {
-	if len(os.Args) < 2 {
-		fmt.Printf("Usage: %s <user>\n", os.Args[0])
+	if len(os.Args) < 3 {
+		fmt.Printf("Usage: %s <USER> <HOST>\n", os.Args[0])
 		os.Exit(1)
 	}
 
-	out, err := run(os.Args[1], "build/plugins")
+	user := os.Args[1]
+	// "http://localhost:8080/token?user="
+	host := os.Args[2]
+	dir := "build/plugins"
+
+	out, err := run(user, host, dir)
 	if err != nil {
 		fmt.Println("Error calling plugin:", err)
 		os.Exit(1)

plugin/auth_impl.go

@@ -16,11 +16,12 @@ import (
 type Authorize struct{}
 
 func (Authorize) Get(user string, host string) ([]byte, error) {
+	shared.Logger.Info("Get", "user", user, "host", host)
+
 	if user == "" {
-		return nil, fmt.Errorf("user is required (e.g. ./authorize <user>)")
+		return nil, fmt.Errorf("user is required (e.g. ./authorize <USER> <HOST>)")
 	}
-	// Currently hardcoding the endpoint of the token service
-	// TODO: This should be made configurable similar to the test server (see tests/test-server/main.go)
+
 	resp, err := http.Get(host + user)
 	if err != nil {
 		return nil, fmt.Errorf("error making request: %w", err)

shared/interface.go

@@ -33,7 +33,7 @@ var Handshake = plugin.HandshakeConfig{
 // Create an hclog.Logger
 var Logger = hclog.New(&hclog.LoggerOptions{
 	Name:  "plugin",
-	Level: hclog.Warn,
+	Level: hclog.Info,
 })
 
 // PluginMap is the map of plugins we can dispense.

shared/rpc.go

@@ -1,15 +1,16 @@
 package shared
 
 import (
+	"fmt"
 	"net/rpc"
 )
 
 // RPCClient is an implementation of Authorization that talks over RPC.
 type RPCClient struct{ client *rpc.Client }
 
-func (m *RPCClient) Get(user string) ([]byte, error) {
+func (m *RPCClient) Get(user string, host string) ([]byte, error) {
 	var resp []byte
-	err := m.client.Call("Plugin.Get", user, &resp)
+	err := m.client.Call("Plugin.Get", []string{user, host}, &resp)
 	return resp, err
 }
 
@@ -20,7 +21,11 @@ type RPCServer struct {
 	Impl Authorize
 }
 
-func (m *RPCServer) Get(user string, host string, resp *[]byte) error {
+func (m *RPCServer) Get(args []string, resp *[]byte) error {
+	if len(args) != 2 {
+		return fmt.Errorf("expected 2 arguments, got %d", len(args))
+	}
+	user, host := args[0], args[1]
 	v, err := m.Impl.Get(user, host)
 	*resp = v
 	return err