Skip to content

Commit 0646883

Browse files
committed
Get all tests in ShouldContainValueSpec to pass under Scala 2.13.0-M5.
1 parent 9517238 commit 0646883

File tree

1 file changed

+18
-31
lines changed

1 file changed

+18
-31
lines changed

scalatest-test/src/test/scala/org/scalatest/ShouldContainValueSpec.scala

Lines changed: 18 additions & 31 deletions
Original file line numberDiff line numberDiff line change
@@ -569,110 +569,97 @@ class ShouldContainValueSpec extends FunSpec with ReturnsNormallyThrowsAssertion
569569
val caught1 = intercept[TestFailedException] {
570570
HashMap("one" -> 1, "two" -> 2) should contain value (3)
571571
}
572-
//assert(caught1.getMessage === "Map(one -> 1, two -> 2) did not contain value 3")
573-
assert(caught1.getMessage.startsWith("Map("))
574-
assert(caught1.getMessage.endsWith(") did not contain value 3"))
572+
assert(caught1.getMessage == Prettifier.default(HashMap("one" -> 1, "two" -> 2)) + " did not contain value 3")
575573
}
576574

577575
it("should throw TestFailedException if contains the specified value when used with not") {
578576

579577
val caught1 = intercept[TestFailedException] {
580578
HashMap("one" -> 1, "two" -> 2) should (not contain value (2))
581579
}
582-
caught1.getMessage should fullyMatch regex ("Map(.*) contained value 2")
580+
assert(caught1.getMessage == Prettifier.default(HashMap("one" -> 1, "two" -> 2)) + " contained value 2")
583581

584582
val caught2 = intercept[TestFailedException] {
585583
HashMap("one" -> 1, "two" -> 2) should not (contain value (2))
586584
}
587-
caught1.getMessage should fullyMatch regex ("Map(.*) contained value 2")
585+
assert(caught2.getMessage == Prettifier.default(HashMap("one" -> 1, "two" -> 2)) + " contained value 2")
588586

589587
val caught3 = intercept[TestFailedException] {
590588
HashMap("one" -> 1, "two" -> 2) should not contain value (2)
591589
}
592-
caught1.getMessage should fullyMatch regex ("Map(.*) contained value 2")
590+
assert(caught3.getMessage == Prettifier.default(HashMap("one" -> 1, "two" -> 2)) + " contained value 2")
593591
}
594592

595593
it("should throw an TestFailedException when map doesn't contain specified value and used in a logical-and expression") {
596594

597595
val caught1 = intercept[TestFailedException] {
598596
HashMap("one" -> 1, "two" -> 2) should { contain value (5) and (contain value (2)) }
599597
}
600-
caught1.getMessage should fullyMatch regex ("Map(.*) did not contain value 5")
598+
assert(caught1.getMessage == Prettifier.default(HashMap("one" -> 1, "two" -> 2)) + " did not contain value 5")
601599

602600
val caught2 = intercept[TestFailedException] {
603601
HashMap("one" -> 1, "two" -> 2) should ((contain value (5)) and (contain value (2)))
604602
}
605-
//assert(caught2.getMessage === "Map(one -> 1, two -> 2) did not contain value 5")
606-
caught1.getMessage should fullyMatch regex ("Map(.*) did not contain value 5")
603+
assert(caught2.getMessage == Prettifier.default(HashMap("one" -> 1, "two" -> 2)) + " did not contain value 5")
607604

608605
val caught3 = intercept[TestFailedException] {
609606
HashMap("one" -> 1, "two" -> 2) should (contain value (5) and contain value (2))
610607
}
611-
//assert(caught3.getMessage === "Map(one -> 1, two -> 2) did not contain value 5")
612-
caught1.getMessage should fullyMatch regex ("Map(.*) did not contain value 5")
608+
assert(caught3.getMessage == Prettifier.default(HashMap("one" -> 1, "two" -> 2)) + " did not contain value 5")
613609
}
614610

615611
it("should throw an TestFailedException when map doesn't contain specified value and used in a logical-or expression") {
616612

617613
val caught1 = intercept[TestFailedException] {
618614
HashMap("one" -> 1, "two" -> 2) should { contain value (55) or (contain value (22)) }
619615
}
620-
//assert(caught1.getMessage === "Map(one -> 1, two -> 2) did not contain value 55, and Map(one -> 1, two -> 2) did not contain value 22")
621-
caught1.getMessage should fullyMatch regex ("Map(.*) did not contain value 55, and Map(.*) did not contain value 22")
622-
616+
assert(caught1.getMessage == Prettifier.default(HashMap("one" -> 1, "two" -> 2)) + " did not contain value 55, and " + Prettifier.default(HashMap("one" -> 1, "two" -> 2)) + " did not contain value 22")
617+
623618
val caught2 = intercept[TestFailedException] {
624619
HashMap("one" -> 1, "two" -> 2) should ((contain value (55)) or (contain value (22)))
625620
}
626-
//assert(caught2.getMessage === "Map(one -> 1, two -> 2) did not contain value 55, and Map(one -> 1, two -> 2) did not contain value 22")
627-
caught1.getMessage should fullyMatch regex ("Map(.*) did not contain value 55, and Map(.*) did not contain value 22")
621+
assert(caught2.getMessage == Prettifier.default(HashMap("one" -> 1, "two" -> 2)) + " did not contain value 55, and " + Prettifier.default(HashMap("one" -> 1, "two" -> 2)) + " did not contain value 22")
628622

629623
val caught3 = intercept[TestFailedException] {
630624
HashMap("one" -> 1, "two" -> 2) should (contain value (55) or contain value (22))
631625
}
632-
//assert(caught3.getMessage === "Map(one -> 1, two -> 2) did not contain value 55, and Map(one -> 1, two -> 2) did not contain value 22")
633-
caught1.getMessage should fullyMatch regex ("Map(.*) did not contain value 55, and Map(.*) did not contain value 22")
626+
assert(caught3.getMessage == Prettifier.default(HashMap("one" -> 1, "two" -> 2)) + " did not contain value 55, and " + Prettifier.default(HashMap("one" -> 1, "two" -> 2)) + " did not contain value 22")
634627
}
635628

636629
it("should throw an TestFailedException when map contains specified value and used in a logical-and expression with not") {
637630

638631
val caught1 = intercept[TestFailedException] {
639632
HashMap("one" -> 1, "two" -> 2) should { not { contain value (3) } and not { contain value (2) }}
640633
}
641-
//assert(caught1.getMessage === "Map(one -> 1, two -> 2) did not contain value 3, but Map(one -> 1, two -> 2) contained value 2")
642-
caught1.getMessage should fullyMatch regex ("Map(.*) did not contain value 3, but Map(.*) contained value 2")
634+
assert(caught1.getMessage == Prettifier.default(HashMap("one" -> 1, "two" -> 2)) + " did not contain value 3, but " + Prettifier.default(HashMap("one" -> 1, "two" -> 2)) + " contained value 2")
643635

644636
val caught2 = intercept[TestFailedException] {
645637
HashMap("one" -> 1, "two" -> 2) should ((not contain value (3)) and (not contain value (2)))
646638
}
647-
//assert(caught2.getMessage === "Map(one -> 1, two -> 2) did not contain value 3, but Map(one -> 1, two -> 2) contained value 2")
648-
caught1.getMessage should fullyMatch regex ("Map(.*) did not contain value 3, but Map(.*) contained value 2")
639+
assert(caught2.getMessage == Prettifier.default(HashMap("one" -> 1, "two" -> 2)) + " did not contain value 3, but " + Prettifier.default(HashMap("one" -> 1, "two" -> 2)) + " contained value 2")
649640

650641
val caught3 = intercept[TestFailedException] {
651642
HashMap("one" -> 1, "two" -> 2) should (not contain value (3) and not contain value (2))
652643
}
653-
//assert(caught3.getMessage === "Map(one -> 1, two -> 2) did not contain value 3, but Map(one -> 1, two -> 2) contained value 2")
654-
caught1.getMessage should fullyMatch regex ("Map(.*) did not contain value 3, but Map(.*) contained value 2")
644+
assert(caught3.getMessage == Prettifier.default(HashMap("one" -> 1, "two" -> 2)) + " did not contain value 3, but " + Prettifier.default(HashMap("one" -> 1, "two" -> 2)) + " contained value 2")
655645
}
656646

657647
it("should throw an TestFailedException when map contains specified value and used in a logical-or expression with not") {
658648

659649
val caught1 = intercept[TestFailedException] {
660650
HashMap("one" -> 1, "two" -> 2) should { not { contain value (2) } or not { contain value (2) }}
661651
}
662-
//assert(caught1.getMessage === "Map(one -> 1, two -> 2) contained value 2, and Map(one -> 1, two -> 2) contained value 2")
663-
caught1.getMessage should fullyMatch regex ("Map(.*) contained value 2, and Map(.*) contained value 2")
664-
652+
assert(caught1.getMessage == Prettifier.default(HashMap("one" -> 1, "two" -> 2)) + " contained value 2, and " + Prettifier.default(HashMap("one" -> 1, "two" -> 2)) + " contained value 2")
653+
665654
val caught2 = intercept[TestFailedException] {
666655
HashMap("one" -> 1, "two" -> 2) should ((not contain value (2)) or (not contain value (2)))
667656
}
668-
//assert(caught2.getMessage === "Map(one -> 1, two -> 2) contained value 2, and Map(one -> 1, two -> 2) contained value 2")
669-
caught1.getMessage should fullyMatch regex ("Map(.*) contained value 2, and Map(.*) contained value 2")
657+
assert(caught2.getMessage == Prettifier.default(HashMap("one" -> 1, "two" -> 2)) + " contained value 2, and " + Prettifier.default(HashMap("one" -> 1, "two" -> 2)) + " contained value 2")
670658

671659
val caught3 = intercept[TestFailedException] {
672660
HashMap("one" -> 1, "two" -> 2) should (not contain value (2) or not contain value (2))
673661
}
674-
//assert(caught3.getMessage === "Map(one -> 1, two -> 2) contained value 2, and Map(one -> 1, two -> 2) contained value 2")
675-
caught1.getMessage should fullyMatch regex ("Map(.*) contained value 2, and Map(.*) contained value 2")
662+
assert(caught3.getMessage == Prettifier.default(HashMap("one" -> 1, "two" -> 2)) + " contained value 2, and " + Prettifier.default(HashMap("one" -> 1, "two" -> 2)) + " contained value 2")
676663
}
677664

678665
// SKIP-SCALATESTJS,NATIVE-START

0 commit comments

Comments
 (0)