Skip to content

Commit 2cffac8

Browse files
committed
Enabled GenGen's tests in js and native tests, and enabled must matchers tests in js (unable to enable for native as it demands too much memory).
1 parent a9927c4 commit 2cffac8

File tree

3 files changed

+38
-18
lines changed

3 files changed

+38
-18
lines changed

project/GenGen.scala

Lines changed: 15 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4230,4 +4230,19 @@ $okayAssertions$
42304230
genGeneratorDrivenSuite(dir, false, true, generatorSuiteExpectTemplate, "expect", false)*/
42314231

42324232
}
4233+
4234+
def genTestForNative(dir: File, version: String, scalaVersion: String): Seq[File] = {
4235+
genGeneratorDrivenSuite(dir, true, false, generatorSuiteAssertTemplate, "assert", false) ++
4236+
genGeneratorDrivenSuite(dir, false, false, generatorSuiteAssertTemplate, "assert", false) ++
4237+
genGeneratorDrivenSuite(dir, true, true, generatorSuiteAssertTemplate, "assert", false) ++
4238+
genGeneratorDrivenSuite(dir, false, true, generatorSuiteAssertTemplate, "assert", false) /*++
4239+
genGeneratorDrivenSuite(dir, true, false, generatorSuiteFutureAssertTemplate, "assert", true) ++
4240+
genGeneratorDrivenSuite(dir, false, false, generatorSuiteFutureAssertTemplate, "assert", true) ++
4241+
genGeneratorDrivenSuite(dir, true, true, generatorSuiteFutureAssertTemplate, "assert", true) ++
4242+
genGeneratorDrivenSuite(dir, false, true, generatorSuiteFutureAssertTemplate, "assert", true) ++
4243+
genGeneratorDrivenSuite(dir, true, false, generatorSuiteExpectTemplate, "expect", false) ++
4244+
genGeneratorDrivenSuite(dir, false, false, generatorSuiteExpectTemplate, "expect", false) ++
4245+
genGeneratorDrivenSuite(dir, true, true, generatorSuiteExpectTemplate, "expect", false) ++
4246+
genGeneratorDrivenSuite(dir, false, true, generatorSuiteExpectTemplate, "expect", false)*/
4247+
}
42334248
}

project/GenMustMatchersTests.scala

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -120,7 +120,11 @@ trait GenMustMatchersTestsBase {
120120
genTestImpl(targetBaseDir, version, scalaVersion, false)
121121
}
122122

123-
def genTestForScalaJS(targetBaseDir: File, version: String, scalaVersion: String): Unit = {
123+
def genTestForScalaJS(targetBaseDir: File, version: String, scalaVersion: String): Seq[File] = {
124+
genTestImpl(targetBaseDir, version, scalaVersion, true)
125+
}
126+
127+
def genTestForScalaNative(targetBaseDir: File, version: String, scalaVersion: String): Seq[File] = {
124128
genTestImpl(targetBaseDir, version, scalaVersion, true)
125129
}
126130

project/scalatest.scala

Lines changed: 18 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -1074,11 +1074,15 @@ object ScalatestBuild {
10741074
Def.task {
10751075
GenScalaTestJS.genTest((sourceManaged in Test).value, version.value, scalaVersion.value)
10761076
}.taskValue
1077-
}/*,
1078-
sourceGenerators in Test <+=
1079-
(baseDirectory, sourceManaged in Test, version, scalaVersion) map genFiles("gengen", "GenGen.scala")(GenGen.genTest),
1080-
sourceGenerators in Test <+=
1081-
(baseDirectory, sourceManaged in Test, version, scalaVersion) map genFiles("genmatchers", "GenMustMatchersTests.scala")(GenMustMatchersTests.genTestForScalaJS)*/
1077+
},
1078+
sourceGenerators in Test +=
1079+
Def.task {
1080+
GenGen.genTest((sourceManaged in Test).value, version.value, scalaVersion.value)
1081+
},
1082+
sourceGenerators in Test +=
1083+
Def.task {
1084+
GenMustMatchersTests.genTestForScalaJS((sourceManaged in Test).value, version.value, scalaVersion.value)
1085+
}
10821086
).dependsOn(scalatestJS % "test", commonTestJS % "test").enablePlugins(ScalaJSPlugin)
10831087

10841088
lazy val scalatestNative = Project("scalatestNative", file("scalatest.native"))
@@ -1200,11 +1204,15 @@ object ScalatestBuild {
12001204
Def.task {
12011205
GenScalaTestNative.genTest((sourceManaged in Test).value / "scala", version.value, scalaVersion.value)
12021206
}.taskValue
1203-
}/*,
1204-
sourceGenerators in Test <+=
1205-
(baseDirectory, sourceManaged in Test, version, scalaVersion) map genFiles("gengen", "GenGen.scala")(GenGen.genTest),
1206-
sourceGenerators in Test <+=
1207-
(baseDirectory, sourceManaged in Test, version, scalaVersion) map genFiles("genmatchers", "GenMustMatchersTests.scala")(GenMustMatchersTests.genTestForScalaJS)*/
1207+
},
1208+
sourceGenerators in Test +=
1209+
Def.task {
1210+
GenGen.genTestForNative((sourceManaged in Test).value, version.value, scalaVersion.value)
1211+
}/*, // OOM even with 14gb heap size, will turn this one when 32gb machine is common or if newer scala-native use lesser memory.
1212+
sourceGenerators in Test +=
1213+
Def.task {
1214+
GenMustMatchersTests.genTestForScalaNative((sourceManaged in Test).value, version.value, scalaVersion.value)
1215+
}*/
12081216
).dependsOn(scalatestNative % "test", commonTestNative % "test").enablePlugins(ScalaNativePlugin)
12091217

12101218
lazy val scalatestApp = Project("scalatestApp", file("."))
@@ -1715,13 +1723,6 @@ object ScalatestBuild {
17151723
results
17161724
}
17171725

1718-
/*def genFiles(generatorSource: File, generatedFile: File)(genFun: => Seq[File]): Seq[File] = {
1719-
if (generatedFile.exists || generatorSource.lastModified > generatedFile.lastModified)
1720-
genFun()
1721-
else
1722-
Seq.empty[File]
1723-
}*/
1724-
17251726
def genJavaFiles(name: String, generatorSource: String)(gen: (File, String, String) => Unit)(basedir: File, outDir: File, theVersion: String, theScalaVersion: String): Seq[File] = {
17261727
val tdir = outDir / "java" / name
17271728
val genSource = basedir / "project" / generatorSource

0 commit comments

Comments
 (0)