Avoid using inline overriding inline

Author: nicolasstucki

scalatest.dotty/src/main/scala/org/scalatest/Assertions.scala

@@ -468,7 +468,7 @@ trait Assertions extends TripleEquals  {
    * @throws TestFailedException if the condition is <code>false</code>.
    */
   inline def assert(inline condition: Boolean)(implicit prettifier: Prettifier, pos: source.Position): Assertion =
-    ${ AssertionsMacro.assert('{condition}, '{prettifier}, '{pos}, '{""}) }
+    ${ AssertionsMacro.assert('this, 'condition, 'prettifier, 'pos, '{""}) }
 
   private[scalatest] def newAssertionFailedException(optionalMessage: Option[String], optionalCause: Option[Throwable], pos: source.Position, analysis: scala.collection.immutable.IndexedSeq[String]): Throwable =
     new org.scalatest.exceptions.TestFailedException(toExceptionFunction(optionalMessage), optionalCause, Left(pos), None, analysis)
@@ -527,7 +527,7 @@ trait Assertions extends TripleEquals  {
    * @throws NullArgumentException if <code>message</code> is <code>null</code>.
    */
   inline def assert(inline condition: Boolean, clue: Any)(implicit prettifier: Prettifier, pos: source.Position): Assertion =
-    ${ AssertionsMacro.assert('{condition}, '{prettifier}, '{pos}, '{clue}) }
+    ${ AssertionsMacro.assert('this, 'condition, 'prettifier, 'pos, 'clue) }
 
   /**
    * Assume that a boolean condition is true.
@@ -575,7 +575,7 @@ trait Assertions extends TripleEquals  {
    * @throws TestCanceledException if the condition is <code>false</code>.
    */
   inline def assume(inline condition: Boolean)(implicit prettifier: Prettifier, pos: source.Position): Assertion =
-    ${ AssertionsMacro.assume('{condition}, '{prettifier}, '{pos}, '{""}) }
+    ${ AssertionsMacro.assume('this, 'condition, 'prettifier, 'pos, '{""}) }
 
   /**
    * Assume that a boolean condition, described in <code>String</code>
@@ -628,7 +628,7 @@ trait Assertions extends TripleEquals  {
    * @throws NullArgumentException if <code>message</code> is <code>null</code>.
    */
   inline def assume(inline condition: Boolean, clue: Any)(implicit prettifier: Prettifier, pos: source.Position): Assertion =
-    ${ AssertionsMacro.assume('{condition}, '{prettifier}, '{pos}, '{clue}) }
+    ${ AssertionsMacro.assume('this, 'condition, 'prettifier, 'pos, 'clue) }
 
   /**
    * Asserts that a given string snippet of code does not pass the Scala type checker, failing if the given

scalatest.dotty/src/main/scala/org/scalatest/AssertionsMacro.scala

@@ -29,8 +29,11 @@ object AssertionsMacro {
    * @param condition original condition expression
    * @return transformed expression that performs the assertion check and throw <code>TestFailedException</code> with rich error message if assertion failed
    */
-  def assert(condition: Expr[Boolean], prettifier: Expr[Prettifier], pos: Expr[source.Position], clue: Expr[Any])(implicit qctx: QuoteContext): Expr[Assertion] =
-    transform('{Assertions.assertionsHelper.macroAssert}, condition, prettifier, pos, clue)
+  def assert(ths: Expr[Assertions], condition: Expr[Boolean], prettifier: Expr[Prettifier], pos: Expr[source.Position], clue: Expr[Any])(implicit qctx: QuoteContext): Expr[Assertion] =
+    ths match {
+      case '{ $ths: diagrams.Diagrams } => org.scalatest.DiagrammedAssertionsMacro.assert(condition, prettifier, pos, clue)
+      case _ => transform('{Assertions.assertionsHelper.macroAssert}, condition, prettifier, pos, clue)
+    }
 
   /**
    * Provides implementation for <code>Assertions.assume(booleanExpr: Boolean)</code>, with rich error message.
@@ -39,8 +42,12 @@ object AssertionsMacro {
    * @param condition original condition expression
    * @return transformed expression that performs the assumption check and throw <code>TestCanceledException</code> with rich error message if assumption failed
    */
-  def assume(condition: Expr[Boolean], prettifier: Expr[Prettifier], pos: Expr[source.Position], clue: Expr[Any])(implicit qctx: QuoteContext): Expr[Assertion] =
-    transform('{Assertions.assertionsHelper.macroAssume}, condition, prettifier, pos, clue)
+  def assume(ths: Expr[Assertions], condition: Expr[Boolean], prettifier: Expr[Prettifier], pos: Expr[source.Position], clue: Expr[Any])(implicit qctx: QuoteContext): Expr[Assertion] =
+    ths match {
+      case '{ $ths: diagrams.Diagrams } => org.scalatest.DiagrammedAssertionsMacro.assume(condition, prettifier, pos, clue)
+      case _ => transform('{Assertions.assertionsHelper.macroAssume}, condition, prettifier, pos, clue)
+    }
+
 
   def transform(
     helper:Expr[(Bool, Any, source.Position) => Assertion],

scalatest.dotty/src/main/scala/org/scalatest/diagrams/Diagrams.scala

@@ -154,97 +154,7 @@ import org.scalatest.compatible.Assertion
  *
  * <p>Trait <code>DiagrammedAssertions</code> was inspired by Peter Niederwieser's work in <a href="http://code.google.com/p/spock/">Spock</a> and <a href="https://github.com/pniederw/expecty">Expecty</a>.
  */
-trait Diagrams extends Assertions {
-
-  import scala.tasty._
-  import scala.quoted._
-
-  /**
-   * Assert that a boolean condition is true.
-   * If the condition is <code>true</code>, this method returns normally.
-   * Else, it throws <code>TestFailedException</code>.
-   *
-   * <p>
-   * This method is implemented in terms of a Scala macro that will generate a more helpful error message that includes
-   * a diagram showing expression values.
-   * </p>
-   *
-   * <p>
-   * If multi-line <code>Boolean</code> is passed in, it will fallback to the macro implementation of <code>Assertions</code>
-   * that does not contain diagram.
-   * </p>
-   *
-   * @param condition the boolean condition to assert
-   * @throws TestFailedException if the condition is <code>false</code>.
-   */
-  inline override def assert(inline condition: Boolean)(implicit prettifier: Prettifier, pos: source.Position): Assertion =
-    ${ DiagrammedAssertionsMacro.assert('{condition}, '{prettifier}, '{pos}, '{""}) }
-
-  /**
-   * Assert that a boolean condition, described in <code>String</code>
-   * <code>message</code>, is true.
-   * If the condition is <code>true</code>, this method returns normally.
-   * Else, it throws <code>TestFailedException</code> with the
-   * <code>String</code> obtained by invoking <code>toString</code> on the
-   * specified <code>clue</code> as the exception's detail message and a
-   * diagram showing expression values.
-   *
-   * <p>
-   * If multi-line <code>Boolean</code> is passed in, it will fallback to the macro implementation of <code>Assertions</code>
-   * that does not contain diagram.
-   * </p>
-   *
-   * @param condition the boolean condition to assert
-   * @param clue An objects whose <code>toString</code> method returns a message to include in a failure report.
-   * @throws TestFailedException if the condition is <code>false</code>.
-   * @throws NullArgumentException if <code>message</code> is <code>null</code>.
-   */
-  inline override def assert(inline condition: Boolean, clue: Any)(implicit prettifier: Prettifier, pos: source.Position): Assertion =
-    ${ DiagrammedAssertionsMacro.assert('condition, 'prettifier, 'pos, 'clue) }
-
-  /**
-   * Assume that a boolean condition is true.
-   * If the condition is <code>true</code>, this method returns normally.
-   * Else, it throws <code>TestCanceledException</code>.
-   *
-   * <p>
-   * This method is implemented in terms of a Scala macro that will generate a more helpful error message that includes
-   * a diagram showing expression values.
-   * </p>
-   *
-   * <p>
-   * If multi-line <code>Boolean</code> is passed in, it will fallback to the macro implementation of <code>Assertions</code>
-   * that does not contain diagram.
-   * </p>
-   *
-   * @param condition the boolean condition to assume
-   * @throws TestCanceledException if the condition is <code>false</code>.
-   */
-  inline override def assume(inline condition: Boolean)(implicit prettifier: Prettifier, pos: source.Position): Assertion =
-    ${ DiagrammedAssertionsMacro.assume('condition, 'prettifier, 'pos, '{""}) }
-
-  /**
-   * Assume that a boolean condition, described in <code>String</code>
-   * <code>message</code>, is true.
-   * If the condition is <code>true</code>, this method returns normally.
-   * Else, it throws <code>TestCanceledException</code> with the
-   * <code>String</code> obtained by invoking <code>toString</code> on the
-   * specified <code>clue</code> as the exception's detail message and a
-   * diagram showing expression values.
-   *
-   * <p>
-   * If multi-line <code>Boolean</code> is passed in, it will fallback to the macro implementation of <code>Assertions</code>
-   * that does not contain diagram.
-   * </p>
-   *
-   * @param condition the boolean condition to assume
-   * @param clue An objects whose <code>toString</code> method returns a message to include in a failure report.
-   * @throws TestCanceledException if the condition is <code>false</code>.
-   * @throws NullArgumentException if <code>message</code> is <code>null</code>.
-   */
-  inline override def assume(inline condition: Boolean, clue: Any)(implicit prettifier: Prettifier, pos: source.Position): Assertion =
-    ${ DiagrammedAssertionsMacro.assume('condition, 'prettifier, 'pos, 'clue) }
-}
+trait Diagrams extends Assertions
 
 /**
  * Companion object that facilitates the importing of <code>DiagrammedAssertions</code> members as