Skip to content

Commit 7659107

Browse files
committed
Fixed cannot close release problem caused by uploading artifacts to sonatype in batch.
1 parent 532b9ea commit 7659107

File tree

5 files changed

+37
-10
lines changed

5 files changed

+37
-10
lines changed

build.sbt

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -101,4 +101,5 @@ lazy val scalatestDiagramsDotty = ScalatestBuild.scalatestDiagramsDotty
101101
lazy val scalatestMatchersCoreDotty = ScalatestBuild.scalatestMatchersCoreDotty
102102
lazy val scalatestShouldMatchersDotty = ScalatestBuild.scalatestShouldMatchersDotty
103103
lazy val scalatestMustMatchersDotty = ScalatestBuild.scalatestMustMatchersDotty
104-
lazy val scalatestModulesDotty = ScalatestBuild.scalatestModulesDotty
104+
lazy val scalatestModulesDotty = ScalatestBuild.scalatestModulesDotty
105+
lazy val rootProject = ScalatestBuild.rootProject

project/JsBuild.scala

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -223,6 +223,7 @@ trait JsBuild { this: BuildCommons =>
223223
Seq.empty[File]
224224
}.taskValue
225225
},
226+
aggregate in publish := false,
226227
mimaPreviousArtifacts := Set(organization.value %%% moduleName.value % previousReleaseVersion),
227228
mimaCurrentClassfiles := (classDirectory in Compile).value.getParentFile / (moduleName.value + "_" + "sjs0.6_" + scalaBinaryVersion.value + "-" + releaseVersion + ".jar")
228229
).settings(osgiSettings: _*).settings(
@@ -276,7 +277,7 @@ trait JsBuild { this: BuildCommons =>
276277
"Bundle-Vendor" -> "Artima, Inc.",
277278
"Main-Class" -> "org.scalatest.tools.Runner"
278279
)
279-
).dependsOn(scalacticMacroJS % "compile-internal, test-internal", scalacticJS % "compile-internal", scalatestJS % "compile-internal").aggregate(scalacticMacroJS, scalacticJS, scalatestJS, commonTestJS, scalacticTestJS, scalatestTestJS).enablePlugins(ScalaJSPlugin)
280+
).dependsOn(scalacticMacroJS % "compile-internal, test-internal", scalacticJS % "compile-internal", scalatestJS % "compile-internal").enablePlugins(ScalaJSPlugin)
280281

281282
def scalatestTestJSOptions =
282283
Seq(Tests.Argument(TestFrameworks.ScalaTest,

project/NativeBuild.scala

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -210,7 +210,8 @@ trait NativeBuild { this: BuildCommons =>
210210
(new File(crossTarget.value, "classes")).mkdirs()
211211
Seq.empty[File]
212212
}.taskValue
213-
}
213+
},
214+
aggregate in publish := false
214215
).settings(osgiSettings: _*).settings(
215216
OsgiKeys.exportPackage := Seq(
216217
"org.scalatest",
@@ -262,7 +263,7 @@ trait NativeBuild { this: BuildCommons =>
262263
"Bundle-Vendor" -> "Artima, Inc.",
263264
"Main-Class" -> "org.scalatest.tools.Runner"
264265
)
265-
).dependsOn(scalacticMacroNative % "compile-internal, test-internal", scalacticNative % "compile-internal", scalatestNative % "compile-internal").aggregate(scalacticMacroNative, scalacticNative, scalatestNative, commonTestNative, scalacticTestNative, scalatestTestNative).enablePlugins(ScalaNativePlugin)
266+
).dependsOn(scalacticMacroNative % "compile-internal, test-internal", scalacticNative % "compile-internal", scalatestNative % "compile-internal").enablePlugins(ScalaNativePlugin)
266267

267268
lazy val scalatestCoreNative = Project("scalatestCoreNative", file("modules/native/scalatest-core.native"))
268269
.enablePlugins(SbtOsgi)

project/scalatest.scala

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -514,7 +514,7 @@ object ScalatestBuild extends BuildCommons with DottyBuild with NativeBuild with
514514
scalacOptions ++= (if (scalaBinaryVersion.value == "2.10" || scalaVersion.value.startsWith("2.13")) Seq.empty[String] else Seq("-Ypartial-unification"))
515515
).dependsOn(scalatest % "test", commonTest % "test")
516516

517-
lazy val scalatestApp = Project("scalatestApp", file("."))
517+
lazy val scalatestApp = Project("scalatestApp", file("scalatest-app"))
518518
.enablePlugins(SbtOsgi)
519519
.settings(sharedSettings: _*)
520520
.settings(scalatestDocSettings: _*)
@@ -538,6 +538,7 @@ object ScalatestBuild extends BuildCommons with DottyBuild with NativeBuild with
538538
Seq.empty[File]
539539
}.taskValue
540540
},
541+
aggregate in publishArtifact := false,
541542
scalatestDocSettings,
542543
unmanagedResourceDirectories in Compile += baseDirectory.value / "scalatest" / "src" / "main" / "resources",
543544
mimaPreviousArtifacts := Set(organization.value %% name.value % previousReleaseVersion),
@@ -594,9 +595,9 @@ object ScalatestBuild extends BuildCommons with DottyBuild with NativeBuild with
594595
"Bundle-Vendor" -> "Artima, Inc.",
595596
"Main-Class" -> "org.scalatest.tools.Runner"
596597
)
597-
).dependsOn(scalacticMacro % "compile-internal, test-internal", scalactic % "compile-internal", scalatest % "compile-internal").aggregate(scalacticMacro, scalactic, scalatest, commonTest, scalacticTest, scalatestTest)
598+
).dependsOn(scalacticMacro % "compile-internal, test-internal", scalactic % "compile-internal", scalatest % "compile-internal")
598599

599-
lazy val rootProject = scalatestApp
600+
lazy val rootProject = Project("root", file(".")).aggregate(scalacticMacro, scalactic, scalatest, commonTest, scalacticTest, scalatestTest)
600601

601602
lazy val scalatestCompatible = Project("scalatestCompatible", file("scalatest-compatible"))
602603
.enablePlugins(SbtOsgi)

publish.sh

Lines changed: 26 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,35 @@
1+
sbt clean
2+
sbt "project scalactic" clean +publishSigned
3+
export SCALAJS_VERSION=0.6.31
4+
sbt "project scalacticJS" clean +publishSigned
5+
export SCALAJS_VERSION=1.0.0-M8
6+
sbt ++2.11.12 "project scalacticJS" clean publishSigned
7+
sbt ++2.12.10 "project scalacticJS" clean publishSigned
8+
sbt ++2.13.1 "project scalacticJS" clean publishSigned
9+
sbt ++2.11.12 "project scalacticNative" clean publishSigned
10+
sbt "project scalacticDotty" clean publishSigned
11+
sbt "project scalactic" sonatypeBundleUpload
12+
13+
sbt clean
114
sbt scalatestCompatible/clean scalatestCompatible/publishSigned
15+
sbt "project scalatest" clean +publishSigned
16+
export SCALAJS_VERSION=0.6.31
17+
sbt "project scalatestJS" clean +publishSigned
18+
export SCALAJS_VERSION=1.0.0-M8
19+
sbt ++2.11.12 "project scalatestJS" clean publishSigned
20+
sbt ++2.12.10 "project scalatestJS" clean publishSigned
21+
sbt ++2.13.1 "project scalatestJS" clean publishSigned
22+
sbt ++2.11.12 "project scalatestNative" clean publishSigned
23+
sbt "project scalatestDotty" clean publishSigned
24+
sbt "project scalatest" sonatypeBundleUpload
25+
26+
sbt clean
27+
sbt "project scalatestApp" clean +publishSigned
228
export SCALAJS_VERSION=0.6.31
3-
sbt "project scalatestApp" clean +publishSigned
429
sbt "project scalatestAppJS" clean +publishSigned
530
export SCALAJS_VERSION=1.0.0-M8
631
sbt ++2.11.12 "project scalatestAppJS" clean publishSigned
732
sbt ++2.12.10 "project scalatestAppJS" clean publishSigned
833
sbt ++2.13.1 "project scalatestAppJS" clean publishSigned
934
sbt ++2.11.12 "project scalatestAppNative" clean publishSigned
10-
sbt scalacticDotty/clean scalacticDotty/publishSigned
11-
sbt scalatestDotty/clean scalatestDotty/publishSigned
1235
sbt sonatypeBundleUpload

0 commit comments

Comments
 (0)