Skip to content

Commit 8491f86

Browse files
committed
Merge branch 'cheeseng-feature-gengen-must-matchers-tests-for-js-native' into 3.1.x
2 parents 919fee6 + cc2c305 commit 8491f86

File tree

3 files changed

+38
-18
lines changed

3 files changed

+38
-18
lines changed

project/GenGen.scala

Lines changed: 15 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4230,4 +4230,19 @@ $okayAssertions$
42304230
genGeneratorDrivenSuite(dir, false, true, generatorSuiteExpectTemplate, "expect", false)*/
42314231

42324232
}
4233+
4234+
def genTestForNative(dir: File, version: String, scalaVersion: String): Seq[File] = {
4235+
genGeneratorDrivenSuite(dir, true, false, generatorSuiteAssertTemplate, "assert", false) ++
4236+
genGeneratorDrivenSuite(dir, false, false, generatorSuiteAssertTemplate, "assert", false) ++
4237+
genGeneratorDrivenSuite(dir, true, true, generatorSuiteAssertTemplate, "assert", false) ++
4238+
genGeneratorDrivenSuite(dir, false, true, generatorSuiteAssertTemplate, "assert", false) /*++
4239+
genGeneratorDrivenSuite(dir, true, false, generatorSuiteFutureAssertTemplate, "assert", true) ++
4240+
genGeneratorDrivenSuite(dir, false, false, generatorSuiteFutureAssertTemplate, "assert", true) ++
4241+
genGeneratorDrivenSuite(dir, true, true, generatorSuiteFutureAssertTemplate, "assert", true) ++
4242+
genGeneratorDrivenSuite(dir, false, true, generatorSuiteFutureAssertTemplate, "assert", true) ++
4243+
genGeneratorDrivenSuite(dir, true, false, generatorSuiteExpectTemplate, "expect", false) ++
4244+
genGeneratorDrivenSuite(dir, false, false, generatorSuiteExpectTemplate, "expect", false) ++
4245+
genGeneratorDrivenSuite(dir, true, true, generatorSuiteExpectTemplate, "expect", false) ++
4246+
genGeneratorDrivenSuite(dir, false, true, generatorSuiteExpectTemplate, "expect", false)*/
4247+
}
42334248
}

project/GenMustMatchersTests.scala

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -120,7 +120,11 @@ trait GenMustMatchersTestsBase {
120120
genTestImpl(targetBaseDir, version, scalaVersion, false)
121121
}
122122

123-
def genTestForScalaJS(targetBaseDir: File, version: String, scalaVersion: String): Unit = {
123+
def genTestForScalaJS(targetBaseDir: File, version: String, scalaVersion: String): Seq[File] = {
124+
genTestImpl(targetBaseDir, version, scalaVersion, true)
125+
}
126+
127+
def genTestForScalaNative(targetBaseDir: File, version: String, scalaVersion: String): Seq[File] = {
124128
genTestImpl(targetBaseDir, version, scalaVersion, true)
125129
}
126130

project/scalatest.scala

Lines changed: 18 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -1080,11 +1080,15 @@ object ScalatestBuild {
10801080
Def.task {
10811081
GenScalaTestJS.genTest((sourceManaged in Test).value, version.value, scalaVersion.value)
10821082
}.taskValue
1083-
}/*,
1084-
sourceGenerators in Test <+=
1085-
(baseDirectory, sourceManaged in Test, version, scalaVersion) map genFiles("gengen", "GenGen.scala")(GenGen.genTest),
1086-
sourceGenerators in Test <+=
1087-
(baseDirectory, sourceManaged in Test, version, scalaVersion) map genFiles("genmatchers", "GenMustMatchersTests.scala")(GenMustMatchersTests.genTestForScalaJS)*/
1083+
},
1084+
sourceGenerators in Test +=
1085+
Def.task {
1086+
GenGen.genTest((sourceManaged in Test).value, version.value, scalaVersion.value)
1087+
},
1088+
sourceGenerators in Test +=
1089+
Def.task {
1090+
GenMustMatchersTests.genTestForScalaJS((sourceManaged in Test).value, version.value, scalaVersion.value)
1091+
}
10881092
).dependsOn(scalatestJS % "test", commonTestJS % "test").enablePlugins(ScalaJSPlugin)
10891093

10901094
lazy val scalatestNative = Project("scalatestNative", file("scalatest.native"))
@@ -1206,11 +1210,15 @@ object ScalatestBuild {
12061210
Def.task {
12071211
GenScalaTestNative.genTest((sourceManaged in Test).value / "scala", version.value, scalaVersion.value)
12081212
}.taskValue
1209-
}/*,
1210-
sourceGenerators in Test <+=
1211-
(baseDirectory, sourceManaged in Test, version, scalaVersion) map genFiles("gengen", "GenGen.scala")(GenGen.genTest),
1212-
sourceGenerators in Test <+=
1213-
(baseDirectory, sourceManaged in Test, version, scalaVersion) map genFiles("genmatchers", "GenMustMatchersTests.scala")(GenMustMatchersTests.genTestForScalaJS)*/
1213+
},
1214+
sourceGenerators in Test +=
1215+
Def.task {
1216+
GenGen.genTestForNative((sourceManaged in Test).value, version.value, scalaVersion.value)
1217+
}/*, // OOM even with 14gb heap size, will turn this one when 32gb machine is common or if newer scala-native use lesser memory.
1218+
sourceGenerators in Test +=
1219+
Def.task {
1220+
GenMustMatchersTests.genTestForScalaNative((sourceManaged in Test).value, version.value, scalaVersion.value)
1221+
}*/
12141222
).dependsOn(scalatestNative % "test", commonTestNative % "test").enablePlugins(ScalaNativePlugin)
12151223

12161224
lazy val scalatestApp = Project("scalatestApp", file("."))
@@ -1727,13 +1735,6 @@ object ScalatestBuild {
17271735
results
17281736
}
17291737

1730-
/*def genFiles(generatorSource: File, generatedFile: File)(genFun: => Seq[File]): Seq[File] = {
1731-
if (generatedFile.exists || generatorSource.lastModified > generatedFile.lastModified)
1732-
genFun()
1733-
else
1734-
Seq.empty[File]
1735-
}*/
1736-
17371738
def genJavaFiles(name: String, generatorSource: String)(gen: (File, String, String) => Unit)(basedir: File, outDir: File, theVersion: String, theScalaVersion: String): Seq[File] = {
17381739
val tdir = outDir / "java" / name
17391740
val genSource = basedir / "project" / generatorSource

0 commit comments

Comments
 (0)