Remove implicit conversions to Predef.any2stringadd

Author: nicolasstucki

scalactic-test/src/test/scala/org/scalactic/ChainSpec.scala

@@ -1024,8 +1024,8 @@ class ChainSpec extends UnitSpec {
   it should "have a scan method" in {
     Chain(1).scan(0)(_ + _) shouldBe Chain(0, 1)
     Chain(1, 2, 3).scan(0)(_ + _) shouldBe Chain(0, 1, 3, 6)
-    Chain(1, 2, 3).scan("z")(_ + _.toString) shouldBe Chain("z", "z1", "z12", "z123")
-    Chain(0).scan("z")(_ + _.toString) shouldBe Chain("z", "z0")
+    Chain(1, 2, 3).scan("z")(_.toString + _.toString) shouldBe Chain("z", "z1", "z12", "z123")
+    Chain(0).scan("z")(_.toString + _.toString) shouldBe Chain("z", "z0")
   }
   it should "have a scanLeft method" in {
     Chain(1).scanLeft(0)(_ + _) shouldBe Chain(0, 1)

scalactic-test/src/test/scala/org/scalactic/EverySpec.scala

@@ -824,8 +824,8 @@ class EverySpec extends UnitSpec {
   it should "have a scan method" in {
     Every(1).scan(0)(_ + _) shouldBe Every(0, 1)
     Every(1, 2, 3).scan(0)(_ + _) shouldBe Every(0, 1, 3, 6)
-    Every(1, 2, 3).scan("z")(_ + _.toString) shouldBe Every("z", "z1", "z12", "z123")
-    Every(0).scan("z")(_ + _.toString) shouldBe Every("z", "z0")
+    Every(1, 2, 3).scan("z")(_.toString + _.toString) shouldBe Every("z", "z1", "z12", "z123")
+    Every(0).scan("z")(_.toString + _.toString) shouldBe Every("z", "z0")
   }
   it should "have a scanLeft method" in {
     Every(1).scanLeft(0)(_ + _) shouldBe Every(0, 1)

scalactic-test/src/test/scala/org/scalactic/anyvals/NonEmptyArraySpec.scala

@@ -1043,8 +1043,8 @@ class NonEmptyArraySpec extends UnitSpec {
   it should "have a scan method" in {
     NonEmptyArray(1).scan(0)(_ + _) shouldBe NonEmptyArray(0, 1)
     NonEmptyArray(1, 2, 3).scan(0)(_ + _) shouldBe NonEmptyArray(0, 1, 3, 6)
-    NonEmptyArray(1, 2, 3).scan("z")(_ + _.toString) shouldBe NonEmptyArray("z", "z1", "z12", "z123")
-    NonEmptyArray(0).scan("z")(_ + _.toString) shouldBe NonEmptyArray("z", "z0")
+    NonEmptyArray(1, 2, 3).scan("z")(_.toString + _.toString) shouldBe NonEmptyArray("z", "z1", "z12", "z123")
+    NonEmptyArray(0).scan("z")(_.toString + _.toString) shouldBe NonEmptyArray("z", "z0")
   }
   it should "have a scanLeft method" in {
     NonEmptyArray(1).scanLeft(0)(_ + _) shouldBe NonEmptyArray(0, 1)

scalactic-test/src/test/scala/org/scalactic/anyvals/NonEmptyListSpec.scala

@@ -1023,8 +1023,8 @@ class NonEmptyListSpec extends UnitSpec {
   it should "have a scan method" in {
     NonEmptyList(1).scan(0)(_ + _) shouldBe NonEmptyList(0, 1)
     NonEmptyList(1, 2, 3).scan(0)(_ + _) shouldBe NonEmptyList(0, 1, 3, 6)
-    NonEmptyList(1, 2, 3).scan("z")(_ + _.toString) shouldBe NonEmptyList("z", "z1", "z12", "z123")
-    NonEmptyList(0).scan("z")(_ + _.toString) shouldBe NonEmptyList("z", "z0")
+    NonEmptyList(1, 2, 3).scan("z")(_.toString + _.toString) shouldBe NonEmptyList("z", "z1", "z12", "z123")
+    NonEmptyList(0).scan("z")(_.toString + _.toString) shouldBe NonEmptyList("z", "z0")
   }
   it should "have a scanLeft method" in {
     NonEmptyList(1).scanLeft(0)(_ + _) shouldBe NonEmptyList(0, 1)

scalactic-test/src/test/scala/org/scalactic/anyvals/NonEmptySetSpec.scala

@@ -538,8 +538,8 @@ class NonEmptySetSpec extends UnitSpec {
   it should "have a scan method" in {
     NonEmptySet(1).scan(0)(_ + _) shouldBe NonEmptySet(0, 1)
     NonEmptySet(1, 2, 3).scan(0)(_ + _) shouldBe NonEmptySet(0, 2, 5, 6)
-    NonEmptySet(1, 2, 3).scan("z")(_ + _.toString) shouldBe NonEmptySet("z", "z2", "z23", "z231")
-    NonEmptySet(0).scan("z")(_ + _.toString) shouldBe NonEmptySet("z", "z0")
+    NonEmptySet(1, 2, 3).scan("z")(_.toString + _.toString) shouldBe NonEmptySet("z", "z2", "z23", "z231")
+    NonEmptySet(0).scan("z")(_.toString + _.toString) shouldBe NonEmptySet("z", "z0")
   }
   it should "have a scanLeft method" in {
     NonEmptySet(1).scanLeft(0)(_ + _) shouldBe NonEmptySet(0, 1)

scalactic-test/src/test/scala/org/scalactic/anyvals/NonEmptyVectorSpec.scala

@@ -984,8 +984,8 @@ class NonEmptyVectorSpec extends UnitSpec {
   it should "have a scan method" in {
     NonEmptyVector(1).scan(0)(_ + _) shouldBe NonEmptyVector(0, 1)
     NonEmptyVector(1, 2, 3).scan(0)(_ + _) shouldBe NonEmptyVector(0, 1, 3, 6)
-    NonEmptyVector(1, 2, 3).scan("z")(_ + _.toString) shouldBe NonEmptyVector("z", "z1", "z12", "z123")
-    NonEmptyVector(0).scan("z")(_ + _.toString) shouldBe NonEmptyVector("z", "z0")
+    NonEmptyVector(1, 2, 3).scan("z")(_.toString + _.toString) shouldBe NonEmptyVector("z", "z1", "z12", "z123")
+    NonEmptyVector(0).scan("z")(_.toString + _.toString) shouldBe NonEmptyVector("z", "z0")
   }
   it should "have a scanLeft method" in {
     NonEmptyVector(1).scanLeft(0)(_ + _) shouldBe NonEmptyVector(0, 1)

scalactic/src/main/scala/org/scalactic/Differ.scala

@@ -192,17 +192,17 @@ private[scalactic] class GenMapDiffer[K, V] extends Differ {
             val leftValue = aMap(k)
             val rightValue = bMap(k)
             if (leftValue != rightValue)
-              Some(k + ": " + leftValue + " -> " + rightValue)
+              Some(k.toString + ": " + leftValue + " -> " + rightValue)
             else
               None
           }.toSet ++
             missingKeyInLeft.flatMap { k =>
               val rightValue = bMap(k)
-              Option(k + ": -> " + rightValue)
+              Option(k.toString + ": -> " + rightValue)
             }.toSet ++
             missingKeyInRight.flatMap { k =>
               val leftValue = aMap(k)
-              Option(k + ": " + leftValue + " -> ")
+              Option(k.toString + ": " + leftValue + " -> ")
             }.toSet
 
         val shortName = Differ.simpleClassName(aMap)

scalactic/src/main/scala/org/scalactic/anyvals/NonEmptyString.scala

@@ -841,7 +841,7 @@ final class NonEmptyString private (val theString: String) extends AnyVal {
     //NonEmptyString("test")
     new NonEmptyString(
       theString.map { c =>
-        f(c) + ""
+        f(c).toString
       }.mkString
     )
   }

scalatest.dotty/src/main/scala/org/scalatest/diagrams/Diagrams.scala

@@ -362,7 +362,7 @@ object Diagrams extends Diagrams {
       requireNonNull(clue)
       if (!bool.value) {
         val failureMessage =
-          Some(clue + Prettifier.lineSeparator + Prettifier.lineSeparator + renderDiagram(sourceText, bool.anchorValues))
+          Some(clue.toString + Prettifier.lineSeparator + Prettifier.lineSeparator + renderDiagram(sourceText, bool.anchorValues))
         throw newAssertionFailedException(failureMessage, None, pos, Vector.empty)
       }
       Succeeded
@@ -379,7 +379,7 @@ object Diagrams extends Diagrams {
       requireNonNull(clue)
       if (!bool.value) {
         val failureMessage =
-          Some(clue + Prettifier.lineSeparator + Prettifier.lineSeparator + renderDiagram(sourceText, bool.anchorValues))
+          Some(clue.toString + Prettifier.lineSeparator + Prettifier.lineSeparator + renderDiagram(sourceText, bool.anchorValues))
         throw newTestCanceledException(failureMessage, None, pos)
       }
       Succeeded

scalatest/src/main/scala/org/scalatest/tools/DashboardReporter.scala

@@ -165,12 +165,12 @@ private[scalatest] class DashboardReporter(directory: String,
       if (summaryFile.exists)
         summaryFile.renameTo(
           new File(
-            summariesDir + "/summary-" + previousRunTimestamp.get + ".xml"))
+            summariesDir.toString + "/summary-" + previousRunTimestamp.get + ".xml"))
 
       if (durationsFile.exists)
         durationsFile.renameTo(
           new File(
-            durationsDir + "/duration-" + previousRunTimestamp.get + ".xml"))
+            durationsDir.toString + "/duration-" + previousRunTimestamp.get + ".xml"))
 
       purgeDir(summariesDir, "summary-")
       purgeDir(durationsDir, "duration-")