Skip to content

Commit ce53e89

Browse files
committed
Fixed failing tests when built with Scala-js 1.0.0.
1 parent 9d8061c commit ce53e89

File tree

4 files changed

+21
-12
lines changed

4 files changed

+21
-12
lines changed

project/JsBuild.scala

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ import org.portablescala.sbtplatformdeps.PlatformDepsPlugin.autoImport._
1414

1515
trait JsBuild { this: BuildCommons =>
1616

17-
val scalaJSVersion = Option(System.getenv("SCALAJS_VERSION")).getOrElse("0.6.31")
17+
val scalaJSVersion = Option(System.getenv("SCALAJS_VERSION")).getOrElse("1.0.0")
1818

1919
lazy val deleteJsDependenciesTask = taskKey[Unit]("Delete JS_DEPENDENCIES")
2020

project/plugins.sbt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ addSbtPlugin("com.jsuereth" % "sbt-pgp" % "1.1.1")
44

55
addSbtPlugin("com.typesafe.sbt" % "sbt-osgi" % "0.9.4")
66

7-
val scalaJSVersion = Option(System.getenv("SCALAJS_VERSION")).getOrElse("0.6.31")
7+
val scalaJSVersion = Option(System.getenv("SCALAJS_VERSION")).getOrElse("1.0.0")
88

99
addSbtPlugin("org.scala-js" % "sbt-scalajs" % scalaJSVersion)
1010

publish.sh

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
11
sbt clean
22
sbt "project scalactic" clean +publishSigned
3-
export SCALAJS_VERSION=0.6.31
3+
export SCALAJS_VERSION=0.6.32
44
sbt "project scalacticJS" clean +publishSigned
5-
export SCALAJS_VERSION=1.0.0-RC2
5+
export SCALAJS_VERSION=1.0.0
66
sbt ++2.11.12 "project scalacticJS" clean publishSigned
77
sbt ++2.12.10 "project scalacticJS" clean publishSigned
88
sbt ++2.13.1 "project scalacticJS" clean publishSigned
@@ -13,9 +13,9 @@ sbt "project scalactic" sonatypeBundleUpload
1313
sbt clean
1414
sbt scalatestCompatible/clean scalatestCompatible/publishSigned
1515
sbt "project scalatest" clean +publishSigned
16-
export SCALAJS_VERSION=0.6.31
16+
export SCALAJS_VERSION=0.6.32
1717
sbt "project scalatestJS" clean +publishSigned
18-
export SCALAJS_VERSION=1.0.0-RC2
18+
export SCALAJS_VERSION=1.0.0
1919
sbt ++2.11.12 "project scalatestJS" clean publishSigned
2020
sbt ++2.12.10 "project scalatestJS" clean publishSigned
2121
sbt ++2.13.1 "project scalatestJS" clean publishSigned
@@ -24,9 +24,9 @@ sbt "project scalatestDotty" clean publishSigned
2424

2525
sbt clean
2626
sbt "project scalatestApp" clean +publishSigned
27-
export SCALAJS_VERSION=0.6.31
27+
export SCALAJS_VERSION=0.6.32
2828
sbt "project scalatestAppJS" clean +publishSigned
29-
export SCALAJS_VERSION=1.0.0-RC2
29+
export SCALAJS_VERSION=1.0.0
3030
sbt ++2.11.12 "project scalatestAppJS" clean publishSigned
3131
sbt ++2.12.10 "project scalatestAppJS" clean publishSigned
3232
sbt ++2.13.1 "project scalatestAppJS" clean publishSigned

scalactic.js/src/main/scala/org/scalactic/source/ObjectMeta.scala

Lines changed: 13 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -55,14 +55,23 @@ object ObjectMeta {
5555
replaceAllLiterally("$$und", "_").
5656
replaceAllLiterally("$mcI", "").
5757
replaceAllLiterally("$sp", "").
58-
replaceAllLiterally("$f", "")
59-
60-
Some((filterDollarNumberAtTheEnd(decodedKey), value))
58+
replaceAllLiterally("$f", "").
59+
replace(".*__f_", "") // For scala-js 1.0
60+
61+
val decodedKey10 = {
62+
val idx = decodedKey.indexOf("__f_")
63+
if (idx >= 0)
64+
decodedKey.drop(idx + 4)
65+
else
66+
decodedKey
67+
}
68+
69+
Some((filterDollarNumberAtTheEnd(decodedKey10), value))
6170
}.flatten.toMap
6271

6372
new ObjectMeta {
6473

65-
lazy val fieldNames = dict.keys.toVector.filter(_ != "$$outer")
74+
lazy val fieldNames = dict.keys.toVector.filter(k => k != "$$outer" && k != "$outer")
6675

6776
def value(name: String): Any = {
6877
dict.get(name) match {

0 commit comments

Comments
 (0)