Skip to content

Commit d314a6c

Browse files
committed
Merge branch 'cheeseng-scala-2.13.0-RC2' into 3.1.x
2 parents 0baec70 + 9c188f5 commit d314a6c

File tree

3 files changed

+29
-29
lines changed

3 files changed

+29
-29
lines changed

README.md

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -150,22 +150,22 @@ Before publishing any patch release, binary compatibility with previous version
150150
$ sbt ++2.12.6 scalacticJS/package scalacticJS/mimaReportBinaryIssues
151151
$ sbt ++2.12.6 scalatestJS/package scalatestJS/mimaReportBinaryIssues
152152

153-
$ sbt ++2.13.0-RC1 scalactic/package scalactic/mimaReportBinaryIssues
154-
$ sbt ++2.13.0-RC1 scalatest/package scalatest/mimaReportBinaryIssues
155-
$ sbt ++2.13.0-RC1 scalacticJS/package scalacticJS/mimaReportBinaryIssues
156-
$ sbt ++2.13.0-RC1 scalatestJS/package scalatestJS/mimaReportBinaryIssues
153+
$ sbt ++2.13.0-RC2 scalactic/package scalactic/mimaReportBinaryIssues
154+
$ sbt ++2.13.0-RC2 scalatest/package scalatest/mimaReportBinaryIssues
155+
$ sbt ++2.13.0-RC2 scalacticJS/package scalacticJS/mimaReportBinaryIssues
156+
$ sbt ++2.13.0-RC2 scalatestJS/package scalatestJS/mimaReportBinaryIssues
157157

158158
To publish scalactic, scalatest and scalatest-app use the following command:
159159

160160
$ export SCALAJS_VERSION=0.6.27
161161
$ sbt ++2.10.7 clean publishSigned "project scalatestAppJS" clean publishSigned
162162
$ sbt ++2.11.12 clean publishSigned "project scalatestAppJS" clean publishSigned
163163
$ sbt ++2.12.8 "project scalatestApp" clean publishSigned "project scalatestAppJS" clean publishSigned
164-
$ sbt ++2.13.0-RC1 "project scalatestApp" clean publishSigned "project scalatestAppJS" clean publishSigned
164+
$ sbt ++2.13.0-RC2 "project scalatestApp" clean publishSigned "project scalatestAppJS" clean publishSigned
165165
$ export SCALAJS_VERSION=1.0.0-M7
166166
$ sbt ++2.11.12 "project scalatestAppJS" clean publishSigned
167167
$ sbt ++2.12.8 "project scalatestAppJS" clean publishSigned
168-
$ sbt ++2.13.0-RC1 "project scalatestAppJS" clean publishSigned
168+
$ sbt ++2.13.0-RC2 "project scalatestAppJS" clean publishSigned
169169

170170
To publish scalactic, scalatest and scalatest-app (for Scala-native version 2.11, and make sure you're on Java 8) to Sonatype, use the following command:
171171

project/scalatest.scala

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -36,14 +36,14 @@ object ScalatestBuild {
3636

3737
// To temporarily switch sbt to a different Scala version:
3838
// > ++ 2.10.5
39-
lazy val supportedScalaVersions = List("2.12.8", "2.11.12", "2.10.7", "2.13.0-RC1")
39+
lazy val supportedScalaVersions = List("2.12.8", "2.11.12", "2.10.7", "2.13.0-RC2")
4040

41-
val releaseVersion = "3.1.0-SNAP10"
41+
val releaseVersion = "3.1.0-SNAP11"
4242

4343
val previousReleaseVersion = "3.0.5"
4444

45-
val plusJUnitVersion = "1.0.0-SNAP5"
46-
val plusTestNGVersion = "1.0.0-SNAP4"
45+
val plusJUnitVersion = "1.0.0-SNAP7"
46+
val plusTestNGVersion = "1.0.0-SNAP6"
4747
val pegdownVersion = "1.4.2"
4848

4949
val githubTag = "release-3.1.0" // for scaladoc source urls

scalactic/src/main/scala/org/scalactic/Accumulation.scala

Lines changed: 19 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -60,6 +60,25 @@ trait AccumulationLowPriorityImplicits {
6060
}
6161
}
6262

63+
implicit def convertGenTraversableOnceToCombinable3[E, TRAVONCE[+e] <: GenTraversableOnce[e]](xs: TRAVONCE[Bad[Every[E]]]): Combinable[Nothing, E, TRAVONCE] =
64+
new Combinable[Nothing, E, TRAVONCE] {
65+
override def combined: Or[TRAVONCE[Nothing], Every[E]] = {
66+
val either: Either[Every[E], TRAVONCE[Nothing]] =
67+
if (xs.isEmpty)
68+
Right(Vector.empty[Nothing].asInstanceOf[TRAVONCE[Nothing]])
69+
else {
70+
val i = xs.toIterable
71+
Left(
72+
(i.tail.foldLeft(i.head.b) { case (res, ele) =>
73+
res ++ ele.b
74+
}.asInstanceOf[Every[E]])
75+
)
76+
}
77+
78+
Or.from(either)
79+
}
80+
}
81+
6382
}
6483

6584
/**
@@ -148,25 +167,6 @@ trait Accumulation extends AccumulationLowPriorityImplicits {
148167

149168
}
150169

151-
implicit def convertGenTraversableOnceToCombinable3[E, TRAVONCE[+e] <: GenTraversableOnce[e]](xs: TRAVONCE[Bad[Every[E]]]): Combinable[Nothing, E, TRAVONCE] =
152-
new Combinable[Nothing, E, TRAVONCE] {
153-
override def combined: Or[TRAVONCE[Nothing], Every[E]] = {
154-
val either: Either[Every[E], TRAVONCE[Nothing]] =
155-
if (xs.isEmpty)
156-
Right(Vector.empty[Nothing].asInstanceOf[TRAVONCE[Nothing]])
157-
else {
158-
val i = xs.toIterable
159-
Left(
160-
(i.tail.foldLeft(i.head.b) { case (res, ele) =>
161-
res ++ ele.b
162-
}.asInstanceOf[Every[E]])
163-
)
164-
}
165-
166-
Or.from(either)
167-
}
168-
}
169-
170170
// Must have another one for Sets, because they are not covariant. Will need to handle Good/Nothing case specially therefore, and plan to do that
171171
// with another implicit here. Or just don't support Nothing.
172172

0 commit comments

Comments
 (0)