Skip to content

Commit ef9b159

Browse files
committed
Fix NormalizationSpec for Dotty
1 parent 68a3221 commit ef9b159

File tree

2 files changed

+33
-28
lines changed

2 files changed

+33
-28
lines changed

project/GenScalacticDotty.scala

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -149,7 +149,6 @@ object GenScalacticDotty {
149149
def genTest(targetDir: File, version: String, scalaVersion: String): Seq[File] =
150150
copyDir("scalactic-test/src/test/scala/org/scalactic", "org/scalactic", targetDir,
151151
List(
152-
"NormalizationSpec.scala", // Compilation error to be investigated further.
153152
"NormMethodsSpec.scala", // Compilation error to be investigated further.
154153
"OrSpec.scala", // Compilation error to be investigated further.
155154
"PrettifierSpec.scala", // Test failed with java.lang.IllegalAccessException

scalactic-test/src/test/scala/org/scalactic/NormalizationSpec.scala

Lines changed: 33 additions & 27 deletions
Original file line numberDiff line numberDiff line change
@@ -21,17 +21,17 @@ class NormalizationSpec extends FunSpec with StringNormalizations {
2121

2222
describe("A Uniformity") {
2323
describe("when anded with another Uniformity") {
24-
it("should produce a Uniformity") {
24+
it("should produce a Uniformity") {
2525
assert(lowerCased.isInstanceOf[Uniformity[_]])
2626
assert((lowerCased and trimmed).isInstanceOf[Uniformity[_]])
2727
}
2828
}
2929
describe("when anded with a regular Normalization (on left or right)") {
30-
val shouted: Normalization[String] =
30+
val shouted: Normalization[String] =
3131
new Normalization[String] {
3232
def normalized(s: String): String = s.toUpperCase
3333
}
34-
it("should produce a Normalization that is not also a Uniformity") {
34+
it("should produce a Normalization that is not also a Uniformity") {
3535
assert(!shouted.isInstanceOf[Uniformity[_]])
3636
assert(trimmed.isInstanceOf[Uniformity[_]])
3737
val tAndS: Normalization[String] = trimmed and shouted
@@ -47,20 +47,23 @@ class NormalizationSpec extends FunSpec with StringNormalizations {
4747
assert(!(lowerCased and trimmed).toEquality.areEqual(" howdy", "HOWDX "))
4848
assert(!lowerCased.toEquality.areEqual("howdy", "XOWDY"))
4949
assert(!(lowerCased and trimmed).toEquality.areEqual(" howdy", "XOWDY "))
50-
implicit val firstCharStringEquality =
51-
new Equality[String] {
52-
def areEqual(a: String, b: Any): Boolean =
53-
b match {
54-
case bString: String => a(0) == bString(0)
55-
case _ => false
56-
}
57-
}
58-
assert(lowerCased.toEquality.areEqual("howdy", "HOWDY"))
59-
assert((lowerCased and trimmed).toEquality.areEqual(" howdy", "HOWDY "))
60-
assert(lowerCased.toEquality.areEqual("howdy", "HOWDX"))
61-
assert((lowerCased and trimmed).toEquality.areEqual(" howdy", "HOWDX "))
62-
assert(!lowerCased.toEquality.areEqual("howdy", "XOWDY"))
63-
assert(!(lowerCased and trimmed).toEquality.areEqual(" howdy", "XOWDY "))
50+
51+
{
52+
implicit val firstCharStringEquality: Equality[String] =
53+
new Equality[String] {
54+
def areEqual(a: String, b: Any): Boolean =
55+
b match {
56+
case bString: String => a(0) == bString(0)
57+
case _ => false
58+
}
59+
}
60+
assert(lowerCased.toEquality.areEqual("howdy", "HOWDY"))
61+
assert((lowerCased and trimmed).toEquality.areEqual(" howdy", "HOWDY "))
62+
assert(lowerCased.toEquality.areEqual("howdy", "HOWDX"))
63+
assert((lowerCased and trimmed).toEquality.areEqual(" howdy", "HOWDX "))
64+
assert(!lowerCased.toEquality.areEqual("howdy", "XOWDY"))
65+
assert(!(lowerCased and trimmed).toEquality.areEqual(" howdy", "XOWDY "))
66+
}
6467
}
6568
}
6669
describe("A Normalization") {
@@ -71,16 +74,19 @@ class NormalizationSpec extends FunSpec with StringNormalizations {
7174
assert(!(lowerCased and trimmed).toEquivalence.areEquivalent(" howdy", "HOWDX "))
7275
assert(!lowerCased.toEquivalence.areEquivalent("howdy", "XOWDY"))
7376
assert(!(lowerCased and trimmed).toEquivalence.areEquivalent(" howdy", "XOWDY "))
74-
implicit val firstCharStringEquivalence =
75-
new Equivalence[String] {
76-
def areEquivalent(a: String, b: String): Boolean = a(0) == b(0)
77-
}
78-
assert(lowerCased.toEquivalence.areEquivalent("howdy", "HOWDY"))
79-
assert((lowerCased and trimmed).toEquivalence.areEquivalent(" howdy", "HOWDY "))
80-
assert(lowerCased.toEquivalence.areEquivalent("howdy", "HOWDX"))
81-
assert((lowerCased and trimmed).toEquivalence.areEquivalent(" howdy", "HOWDX "))
82-
assert(!lowerCased.toEquivalence.areEquivalent("howdy", "XOWDY"))
83-
assert(!(lowerCased and trimmed).toEquivalence.areEquivalent(" howdy", "XOWDY "))
77+
78+
{
79+
implicit val firstCharStringEquivalence: Equivalence[String] =
80+
new Equivalence[String] {
81+
def areEquivalent(a: String, b: String): Boolean = a(0) == b(0)
82+
}
83+
assert(lowerCased.toEquivalence.areEquivalent("howdy", "HOWDY"))
84+
assert((lowerCased and trimmed).toEquivalence.areEquivalent(" howdy", "HOWDY "))
85+
assert(lowerCased.toEquivalence.areEquivalent("howdy", "HOWDX"))
86+
assert((lowerCased and trimmed).toEquivalence.areEquivalent(" howdy", "HOWDX "))
87+
assert(!lowerCased.toEquivalence.areEquivalent("howdy", "XOWDY"))
88+
assert(!(lowerCased and trimmed).toEquivalence.areEquivalent(" howdy", "XOWDY "))
89+
}
8490
}
8591
}
8692
}

0 commit comments

Comments
 (0)