Skip to content

Improve matching for gitlab users #88

@73VW

Description

@73VW

Hello there 👋🏻,

Actually, the comparison between the user having commited and gitlab users is done this way:

if user['name'] == commit['author_name']:

which I find too strict.

Sadly, Gitlag does not include the username in the commits API. That would have been the best way to go.

However, I think that a comparison ignoring accents and case could really improve the matching. Chances that two commiters with the names Bob example and Bob Example are two different people are IMHO very slim.

If the Gitlab user is set to Bob Exämple, no commits would match.

What do you think?

I can open a PR to improve this.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions