Skip to content

Commit 4e7b4ff

Browse files
Jinjie RuanRussell King (Oracle)
authored andcommitted
ARM: 9406/1: Fix callchain_trace() return value
perf_callchain_store() return 0 on success, -1 otherwise, fix callchain_trace() to return correct bool value. So walk_stackframe() can have a chance to stop walking the stack ahead. Fixes: 70ccc7c ("ARM: 9258/1: stacktrace: Make stack walk callback consistent with generic code") Signed-off-by: Jinjie Ruan <[email protected]> Signed-off-by: Russell King (Oracle) <[email protected]>
1 parent e3cf20e commit 4e7b4ff

File tree

1 file changed

+1
-2
lines changed

1 file changed

+1
-2
lines changed

arch/arm/kernel/perf_callchain.c

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -85,8 +85,7 @@ static bool
8585
callchain_trace(void *data, unsigned long pc)
8686
{
8787
struct perf_callchain_entry_ctx *entry = data;
88-
perf_callchain_store(entry, pc);
89-
return true;
88+
return perf_callchain_store(entry, pc) == 0;
9089
}
9190

9291
void

0 commit comments

Comments
 (0)