Enhance CSV validation error handling and normalization in Spanish translations

Author: germankay

ckanext/iati_generator/helpers.py

@@ -750,13 +750,63 @@ def _deduplicate_errors(normalized: List[Dict[str, Any]]) -> List[Dict[str, Any]
     return deduped
 
 
+def _normalize_validation_issues(error_list: List[Any]) -> List[Dict[str, Any]]:
+    """Helper to process list of errors (ValidationIssue objects)."""
+    normalized = []
+    for err in error_list:
+        if hasattr(err, 'message'):
+            row = getattr(err, 'row_number', getattr(err, 'line', None))
+            col = getattr(err, 'column_name', getattr(err, 'column', None))
+
+            item = {
+                "severity": "error",
+                "category": "csv-content",
+                "title": toolkit._(f"Error in {err.file_name}") if hasattr(err, 'file_name')
+                else toolkit._("Validation error"),
+                "details": err.message,
+                "csv_file": getattr(err, 'file_name', None),
+                "location": {"line": row, "col": col} if row else None,
+                "suggestion": toolkit._("Check the format of the uploaded file."),
+                "raw": str(err)
+            }
+            normalized.append(item)
+        else:
+            # Fallback for simple strings inside a list
+            parsed = _parse_schema_error_line(str(err))
+            normalized.append(_normalize_single_error(str(err), parsed))
+    return normalized
+
+
+def _format_raw_errors_as_json(error_dict: Any) -> str:
+    """Helper to dump errors to a pretty JSON string."""
+    def _json_default(obj):
+        """Converts complex objects (ValidationIssue, Enums) to dictionaries/strings."""
+        if isinstance(obj, ValidationIssue):
+            return {
+                "level": getattr(obj.level, 'value', str(obj.level)) if hasattr(obj, 'level') else None,
+                "code": getattr(obj.code, 'value', str(obj.code)) if hasattr(obj, 'code') else None,
+                "message": obj.message,
+                "file_name": getattr(obj, 'file_name', None),
+                "row": getattr(obj, 'row_number', None),
+                "column": getattr(obj, 'column_name', None),
+                "value": getattr(obj, 'value', None)
+            }
+        if hasattr(obj, 'value'):
+            return obj.value
+        return str(obj)
+
+    try:
+        return json.dumps(error_dict, default=_json_default, indent=4, ensure_ascii=False)
+    except Exception:
+        return str(error_dict)
+
+
 def normalize_iati_errors(error_dict: Any, package_id: Optional[str] = None) -> Dict[str, Any]:
     """
     It normalizes converter errors (XSD / latest_errors) into a user-friendly structure.
 
     It also supports pre-normalized structures (e.g., the output of validate_required_csv_folder()).
     """
-
     if isinstance(error_dict, dict) and "items" in error_dict and "raw" in error_dict:
         if "summary" not in error_dict or error_dict["summary"] is None:
             error_dict["summary"] = toolkit._(
@@ -767,54 +817,15 @@ def normalize_iati_errors(error_dict: Any, package_id: Optional[str] = None) ->
     normalized = []
 
     if isinstance(error_dict, list):
-        for err in error_dict:
-            if hasattr(err, 'message'):
-                row = getattr(err, 'row_number', getattr(err, 'line', None))
-                col = getattr(err, 'column_name', getattr(err, 'column', None))
-
-                item = {
-                    "severity": "error",
-                    "category": "csv-content",
-                    "title": toolkit._(f"Error in {err.file_name}") if hasattr(err, 'file_name') else toolkit._("Validation error"),
-                    "details": err.message,
-                    "csv_file": getattr(err, 'file_name', None),
-                    "location": {"line": row, "col": col} if row else None,
-                    "suggestion": toolkit._("Check the format of the uploaded file."),
-                    "raw": str(err)
-                }
-                normalized.append(item)
-            else:
-                parsed = _parse_schema_error_line(str(err))
-                normalized.append(_normalize_single_error(str(err), parsed))
-
+        normalized = _normalize_validation_issues(error_dict)
     elif isinstance(error_dict, dict):
         raw_lines = _flatten_error_dict(error_dict)
         for raw in raw_lines:
             parsed = _parse_schema_error_line(raw)
             normalized.append(_normalize_single_error(raw, parsed))
 
     deduped = _deduplicate_errors(normalized)
-
-    def _json_default(obj):
-        """Converts complex objects (ValidationIssue, Enums) to dictionaries/strings."""
-        if isinstance(obj, ValidationIssue):
-            return {
-                "level": getattr(obj.level, 'value', str(obj.level)) if hasattr(obj, 'level') else None,
-                "code": getattr(obj.code, 'value', str(obj.code)) if hasattr(obj, 'code') else None,
-                "message": obj.message,
-                "file_name": getattr(obj, 'file_name', None),
-                "row": getattr(obj, 'row_number', None),
-                "column": getattr(obj, 'column_name', None),
-                "value": getattr(obj, 'value', None)
-            }
-        if hasattr(obj, 'value'):
-            return obj.value
-        return str(obj)
-
-    try:
-        raw_formatted = json.dumps(error_dict, default=_json_default, indent=4, ensure_ascii=False)
-    except Exception:
-        raw_formatted = str(error_dict)
+    raw_formatted = _format_raw_errors_as_json(error_dict)
 
     return {
         "summary": toolkit._("Validation errors were found in the source CSV files.") if deduped else None,

ckanext/iati_generator/i18n/es/LC_MESSAGES/ckanext-iati-generator.mo

@@ -126,31 +126,31 @@ msgstr "Tipo de dato inválido"
 msgid "The value '%(value)s' is not of the correct type for '%(element)s'."
 msgstr "El valor '%(value)s' no es del tipo correcto para '%(element)s'."
 
-#: ckanext/iati_generator/helpers.py:716
-#, fuzzy
+#: ckanext/iati_generator/helpers.py:718
 msgid "Validation error"
 msgstr "Errores al compilar IATI"
-#: ckanext/iati_generator/helpers.py:718
+
+#: ckanext/iati_generator/helpers.py:720
 msgid "Check the required CSV files and their format."
 msgstr "Verifica los archivos CSV requeridos y su formato."
 
-#: ckanext/iati_generator/helpers.py:763
+#: ckanext/iati_generator/helpers.py:813
 msgid "The XML could not be generated due to errors in the source CSV files."
 msgstr "No se pudo generar el XML debido a errores en los archivos CSV fuente."
 
-#: ckanext/iati_generator/helpers.py:778
+#: ckanext/iati_generator/helpers.py:764
 msgid "Error in %(file_name)s"
 msgstr "Error en %(file_name)s"
 
-#: ckanext/iati_generator/helpers.py:778
+#: ckanext/iati_generator/helpers.py:764
 msgid "Validation error"
 msgstr "Error de validación"
 
-#: ckanext/iati_generator/helpers.py:782
+#: ckanext/iati_generator/helpers.py:769
 msgid "Check the format of the uploaded file."
 msgstr "Verifica el formato del archivo subido."
 
-#: ckanext/iati_generator/helpers.py:820
+#: ckanext/iati_generator/helpers.py:831
 msgid "Validation errors were found in the source CSV files."
 msgstr "Se encontraron errores de validación en los archivos CSV fuente."