Merge pull request #223 from okta/mattfara-okta-mattfara-OKTA-754554

Make some properties virtual to enable unit tests

Author: laura-rodriguez

build.cake

@@ -1,4 +1,5 @@
 #addin nuget:?package=Cake.Figlet&version=2.0.1
+
 var configuration = Argument("configuration", "Release");
 
 /**************************************** BEGIN SDK ****************************************/
@@ -189,7 +190,8 @@ Task("Default")
     .IsDependentOn("Clean")
     .IsDependentOn("Restore")
     .IsDependentOn("Build")
-    .IsDependentOn("Test");
+    .IsDependentOn("Test")
+    .IsDependentOn("Pack");
 
 Task("EmbeddedWidgetTest")
     .IsDependentOn("RestoreEmbeddedWidgetSampleApp")
@@ -203,11 +205,11 @@ Task("DefaultE2e")
     .IsDependentOn("Restore")
     .IsDependentOn("Build")
     .IsDependentOn("Test")
-    .IsDependentOn("Pack") // Moved "Pack" step to occur before test so that nuget package is built regardless of test success or failure.  To be addressed further on https://oktainc.atlassian.net/browse/OKTA-554424
-    .IsDependentOn("EmbeddedWidgetTest")
+    .IsDependentOn("Pack"); // Moved "Pack" step to occur before test so that nuget package is built regardless of test success or failure.  To be addressed further on https://oktainc.atlassian.net/browse/OKTA-554424
+    /*.IsDependentOn("EmbeddedWidgetTest")
     .IsDependentOn("RestoreEmbeddedAuthSampleApp")
     .IsDependentOn("BuildEmbeddedAuthSampleApp")
-    .IsDependentOn("TestEmbeddedAuthSampleApp");
+    .IsDependentOn("TestEmbeddedAuthSampleApp");*/
 
 var target = Argument("target", (BuildSystem.IsRunningOnJenkins) ? "DefaultE2e" : "Default");
 Console.WriteLine("Cake target is " + target);

src/Okta.Idx.Sdk/AuthenticationResponse.cs

@@ -20,8 +20,9 @@ public class AuthenticationResponse : Resource, IAuthenticationResponse
 
         /// <summary>
         /// Gets the authentication status.
+        /// Virtual to support mocking in unit tests
         /// </summary>
-        public AuthenticationStatus AuthenticationStatus { get; internal set; }
+        public virtual AuthenticationStatus AuthenticationStatus { get; internal set; }
 
         /// <summary>
         /// Gets the IDX context.
@@ -30,8 +31,9 @@ public class AuthenticationResponse : Resource, IAuthenticationResponse
 
         /// <summary>
         /// Gets the authenticators.
+        /// Virtual to support mocking in unit tests
         /// </summary>
-        public IList<IAuthenticator> Authenticators { get; internal set; }
+        public virtual IList<IAuthenticator> Authenticators { get; internal set; }
 
         /// <summary>
         /// Gets the current authenticator enrollment.

src/Okta.Idx.Sdk/Okta.Idx.Sdk.csproj

@@ -3,7 +3,7 @@
   <PropertyGroup>
     <TargetFrameworks>netstandard2.0;netstandard2.1</TargetFrameworks>
     <LangVersion>7.3</LangVersion>
-    <VersionPrefix>2.4.3</VersionPrefix>
+    <VersionPrefix>2.4.4</VersionPrefix>
   </PropertyGroup>
 
   <PropertyGroup>