Skip to content

getSwapData() slippagePercent range not updated to API v6 #13

@GlooMyPan

Description

@GlooMyPan

In v5, the range of slippage is (0–1)
In v6, the range of slippagePercent is (0-100)

The current validation logic in getSwapData() still enforces the old (0–1) range.

Related code:

async getSwapData(params) {
        // Validate slippage parameters
        if (!params.slippagePercent && !params.autoSlippage) {
            throw new Error("Either slippagePercent or autoSlippage must be provided");
        }
        if (params.slippagePercent) {
            const slippageValue = parseFloat(params.slippagePercent);
            if (isNaN(slippageValue) ||
                slippageValue < 0 ||
                slippageValue > 1) {
                throw new Error("Slippage must be between 0 and 1");
            }
        }
        if (params.autoSlippage && !params.maxAutoSlippagePercent) {
            throw new Error("maxAutoSlippagePercent must be provided when autoSlippage is enabled");
        }
        return this.client.request("GET", "/api/v6/dex/aggregator/swap", this.toAPIParams(params));
    }

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions