Skip to content

refactor: update GetBlockInternalTransactions to use blockHash #119

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
umiiii wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

refactor: update GetBlockInternalTransactions to use blockHash #119

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 7 additions & 8 deletions eth/api_legacy_xlayer.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -462,15 +462,14 @@ func (api *XlayerHybridTransactionAPI) GetBlockTransactionCountByNumber(ctx cont
}

// eth_getBlockInternalTransactions FORWARD
func (api *XlayerHybridTransactionAPI) GetBlockInternalTransactions(ctx context.Context, blockNr rpc.BlockNumber) (map[common.Hash][]*types.InnerTx, error) {
// Check if we should proxy to erigon
if api.legacyRpc.shouldProxy(uint64(blockNr)) {
var result map[common.Hash][]*types.InnerTx
err := api.legacyRpc.ErigonClient.CallContext(ctx, &result, "eth_getBlockInternalTransactions", hexutil.Uint64(blockNr))
return result, err
func (api *XlayerHybridTransactionAPI) GetBlockInternalTransactions(ctx context.Context, blockHash common.Hash) (map[common.Hash][]*types.InnerTx, error) {
result, err := api.TransactionAPI.GetBlockInternalTransactions(ctx, blockHash)
if err == nil && result != nil {
return result, nil
}
// Handle locally
return api.TransactionAPI.GetBlockInternalTransactions(ctx, blockNr)
var remoteResult map[common.Hash][]*types.InnerTx
err = api.legacyRpc.ErigonClient.CallContext(ctx, &remoteResult, "eth_getBlockInternalTransactions", blockHash)
return remoteResult, err
}

// eth_getInternalTransactions TransactionAPI LOCAL
Expand Down