feat: using dependency injection instead of composition

Author: Ola Austine

src/linear/linear_create_issues.py

@@ -9,8 +9,8 @@
 
 
 class LinearCreateIssueService:
-    def __init__(self):
-        self.linear_service = LinearService()
+    def __init__(self, linear_service: LinearService):
+        self.linear_service = linear_service
 
     def get_data_and_populate_variables(
         self, list_issues: list[Issue]

src/linear/linear_update_issues.py

@@ -7,8 +7,8 @@
 
 
 class LinearUpdateIssueService:
-    def __init__(self):
-        self.linear_service = LinearService()
+    def __init__(self, linear_service: LinearService):
+        self.linear_service = linear_service
 
     def check_all_linear_ticket_statuses(self) -> None:
         """Check and update the Linear ticket status for all issues in Redis."""

src/tests/linear/test_linear_create_issues.py

@@ -1,6 +1,7 @@
 import pytest
 from unittest.mock import patch, MagicMock
 from src.linear.linear_create_issues import LinearCreateIssueService
+from src.linear.linear import LinearService
 
 
 # Test for get_data_and_populate_variables
@@ -15,7 +16,8 @@ def test_get_data_and_populate_variables_raises_exception(mock_post):
     }
     mock_post.return_value = mock_response
 
-    linear_service = LinearCreateIssueService()
+    service = LinearService()
+    linear_service = LinearCreateIssueService(service)
     issue1 = MagicMock()
     issue1.title = "t1"
     issue1.body = "b1"
@@ -36,9 +38,9 @@ def test_get_data_and_populate_variables_success(mock_post):
         "data": {"teams": {"nodes": [{"id": valid_uuid, "name": "tid"}]}}
     }
     mock_post.return_value = mock_response
-    service = LinearCreateIssueService()
-    # Set the private attribute directly
-    service.linear_service.team_id = valid_uuid
+    linear = LinearService()
+    linear.team_id = valid_uuid
+    service = LinearCreateIssueService(linear)
     issue1 = MagicMock()
     issue1.title = "t1"
     issue1.body = "b1"
@@ -78,8 +80,9 @@ def test_run_query_creates_new(mock_post, mock_redis):
     mock_exists = MagicMock()
     mock_exists.return_value = False
 
-    linear_create = LinearCreateIssueService()
-    linear_create.linear_service.confirm_if_ticket_exists = mock_exists
+    service = LinearService()
+    service.confirm_if_ticket_exists = mock_exists
+    linear_create = LinearCreateIssueService(service)
     var = MagicMock()
     var.title = "title"
     var.as_input.return_value = {"foo": "bar"}

src/tests/linear/test_linear_update_issues.py

@@ -1,10 +1,18 @@
 from unittest.mock import patch, MagicMock
 from datetime import datetime
 from src.linear.linear_update_issues import LinearUpdateIssueService
+from src.linear.linear import LinearService
 
 
 def test_check_all_linear_ticket_statuses_internal_mocks():
-    service = LinearUpdateIssueService()
+    linear = LinearService()
+    # make these methods callables returning the expected values
+    linear.get_ticket_if_it_exists = MagicMock(
+        return_value=[{"identifier": "TICKET-1"}]
+    )
+    linear.get_ticket_status = MagicMock(return_value="Done")
+
+    service = LinearUpdateIssueService(linear)
 
     # Mock redis_client.scan_iter and redis_client.get/set
     with patch("src.linear.linear_update_issues.redis_client") as mock_redis:
@@ -16,21 +24,10 @@ def test_check_all_linear_ticket_statuses_internal_mocks():
             "updated_at": datetime.utcnow().isoformat(),
         }
 
-        # Mock internal methods on the service instance
-        service.linear_service = MagicMock()
-        service.linear_service.get_ticket_if_it_exists.return_value = [
-            {"identifier": "TICKET-1"}
-        ]
-        with (
-            patch.object(
-                service.linear_service,
-                "get_ticket_status",
-                return_value="Done",
-            ),
-            patch.object(
-                service, "_LinearUpdateIssueService__update_ticket_status_in_redis"
-            ) as mock_update,
-        ):
+        # Mock internal update method on the service instance
+        with patch.object(
+            service, "_LinearUpdateIssueService__update_ticket_status_in_redis"
+        ) as mock_update:
             service.check_all_linear_ticket_statuses()
             # Assert update was called with correct arguments
             mock_update.assert_called_with("Test Issue", "Done")