Merge pull request #208 from olasunkanmi-SE/clean-up

style(providers, services, ui): improve code quality and fix minor is…

Author: olasunkanmi-SE

src/providers/base.ts

@@ -142,6 +142,7 @@ export abstract class BaseWebViewProvider implements vscode.Disposable {
             break;
           case "upload-file":
             await this.fileManager.uploadFileHandler();
+            break;
           default:
             throw new Error("Unknown command");
         }

src/providers/deepseek.ts

@@ -25,7 +25,7 @@ export class DeepseekWebViewProvider extends BaseWebViewProvider {
     this.deepseekLLM = DeepseekLLM.getInstance({
       apiKey: this.apiKey,
       model: this.generativeAiModel,
-      baseUrl: this.baseUrl || "https://api.deepseek.com/v1",
+      baseUrl: this.baseUrl ?? "https://api.deepseek.com/v1",
     });
     this.client = this.deepseekLLM.getModel();
   }

src/providers/gemini.ts

@@ -5,7 +5,6 @@ import { IMessageInput, Message } from "../llms/message";
 import { Memory } from "../memory/base";
 import { GeminiLLM } from "./../llms/gemini/gemini";
 import { BaseWebViewProvider } from "./base";
-import { FileService } from "../services/file-system";
 
 export class GeminiWebViewProvider extends BaseWebViewProvider {
   chatHistory: IMessageInput[] = [];

src/providers/webview-events-provider.ts

@@ -16,10 +16,10 @@ export class WebViewEventsProvider {
     this.logger = new Logger("WebViewEventsProvider");
   }
 
-  public postMessage(message: IPostMessage) {
+  public async postMessage(message: IPostMessage) {
     const { type, payload } = message;
     try {
-      this.webView.webview.postMessage({ type, payload });
+      await this.webView.webview.postMessage({ type, payload });
     } catch (error: any) {
       this.logger.error(`Unable to emit ${type}`, error);
       throw new Error(error);

src/services/file-manager.ts

@@ -168,7 +168,6 @@ export class FileManager implements IFileUploader {
         this.logger.info(`File ${filename} created successfully`);
         created = true;
       } else {
-        created = false;
         this.logger.info(`File ${filename} already exists`);
       }
       return created;

src/services/url-reranker.ts

@@ -130,7 +130,7 @@ export class UrlReranker {
    */
   calculateFinalScore(metadata: IPageMetada): number {
     const titleRelevanceScore = this.calculateTitleRelevanceScore(
-      metadata.title || "",
+      metadata.title ?? "",
     );
     const reputationScore = this.calculateSourceReputationScore(metadata);
     const contentQualityScore = this.calculateContentQualityScore(metadata);

src/services/web-search-service.ts

@@ -28,7 +28,7 @@ export class WebSearchService {
   private readonly logger: Logger;
   private readonly userAgent = WEB_SEARCH_CONFIG.userAgent;
   private readonly urlRanker: UrlReranker;
-  private static URL_PRIORITY_LIST = PRIORITY_URLS;
+  static readonly URL_PRIORITY_LIST = PRIORITY_URLS;
 
   private constructor(logger: Logger) {
     this.logger = logger;
@@ -264,16 +264,14 @@ export class WebSearchService {
       const contextPromises = urls
         .slice(0, 6)
         .map((url) => this.fetchArticleContent(url));
-      if (contextPromises?.length) {
-      }
       const contextResults = await Promise.all(contextPromises);
       const filteredContext = contextResults.filter((c) => c !== undefined);
       const combinedContext = filteredContext
         .map((result) => result?.content)
         .join("\n\n");
 
       return {
-        pagesPublished: crawleableMetadata?.length > 0 ? true : false,
+        pagesPublished: Boolean(crawleableMetadata?.length),
         combinedContext,
       };
     } catch (error: any) {
@@ -282,7 +280,7 @@ export class WebSearchService {
     }
   }
 
-  private sortUrlsByPriority = (
+  readonly sortUrlsByPriority = (
     metadata: IPageMetada[],
     priorityDomains: string[],
   ): string[] => {

webviewUi/src/components/select.tsx

@@ -7,15 +7,9 @@ interface ModelDropdownProps {
   onChange: (e: any) => void;
   id?: string;
   options: any[];
-  defaultValue?: string;
 }
 
-export const ModelDropdown: React.FC<ModelDropdownProps> = ({
-  value,
-  onChange,
-  id,
-  options,
-}) => {
+export const ModelDropdown: React.FC<ModelDropdownProps> = ({ value, onChange, id, options }) => {
   console.log({ value, onChange, id, options });
   return (
     <VSCodeDropdown value={value} id={id} onChange={onChange}>