refactor: fix shellcheck issues

Author: oldratlee

bin/ap

@@ -78,9 +78,9 @@ usage() {
 
   # NOTE: $'foo' is the escape sequence syntax of bash
   local nl=$'\n' # new line
-  (($# > 0)) && redPrint "$*$nl" >$out
+  (($# > 0)) && redPrint "$*$nl" >"$out"
 
-  cat >$out <<EOF
+  cat >"$out" <<EOF
 Usage: ${PROG} [OPTION]... [FILE]...
 convert to Absolute Path.
 

bin/c

@@ -51,9 +51,9 @@ usage() {
   # shellcheck disable=SC2015
   [ "$exit_code" != 0 ] && local -r out=/dev/stderr || local -r out=/dev/stdout
 
-  (($# > 0)) && printErrorMsg "$*" >$out
+  (($# > 0)) && printErrorMsg "$*" >"$out"
 
-  cat >$out <<EOF
+  cat >"$out" <<EOF
 Usage: ${PROG} [OPTION]... [command [command_args ...]]
 Run command and put output to system clipper.
 If no command is specified, read from stdin(pipe).

bin/cp-into-docker-run

@@ -71,9 +71,9 @@ usage() {
 
   # NOTE: $'foo' is the escape sequence syntax of bash
   local nl=$'\n' # new line
-  (($# > 0)) && redPrint "$*$nl" >$out
+  (($# > 0)) && redPrint "$*$nl" >"$out"
 
-  cat >$out <<EOF
+  cat >"$out" <<EOF
 Usage: ${PROG} [OPTION]... command [command-args]...
 
 Copy the command into docker container

bin/find-in-jars

@@ -100,9 +100,9 @@ usage() {
 
   # NOTE: $'foo' is the escape sequence syntax of bash
   local -r nl=$'\n' # new line
-  (($# > 0)) && redPrint "$*$nl" >$out
+  (($# > 0)) && redPrint "$*$nl" >"$out"
 
-  cat >$out <<EOF
+  cat >"$out" <<EOF
 Usage: ${PROG} [OPTION]... PATTERN
 
 Find files in the jar files under specified directory,
@@ -376,7 +376,7 @@ __outputResultOfJarFile() {
       matched=true
     fi
 
-    if [ $print_matched_files != $matched ]; then
+    if [ "$print_matched_files" != "$matched" ]; then
       return
     fi
 

bin/rp

@@ -76,9 +76,9 @@ usage() {
 
   # NOTE: $'foo' is the escape sequence syntax of bash
   local nl=$'\n' # new line
-  (($# > 0)) && redPrint "$*$nl" >$out
+  (($# > 0)) && redPrint "$*$nl" >"$out"
 
-  cat >$out <<EOF
+  cat >"$out" <<EOF
 Usage: ${PROG} [OPTION]... [FILE]...
 convert to Relative Path.
 

bin/show-busy-java-threads

@@ -49,9 +49,7 @@ readonly USER
 ################################################################################
 
 # NOTE: $'foo' is the escape sequence syntax of bash
-readonly ec=$'\033'      # escape char
-readonly eend=$'\033[0m' # escape end
-readonly nl=$'\n'        # new line
+readonly nl=$'\n' # new line
 
 colorPrint() {
   local color=$1
@@ -154,9 +152,9 @@ usage() {
   # shellcheck disable=SC2015
   [ "$exit_code" != 0 ] && local -r out=/dev/stderr || local -r out=/dev/stdout
 
-  (($# > 0)) && colorPrint 31 "$*$nl" >$out
+  (($# > 0)) && colorPrint 31 "$*$nl" >"$out"
 
-  cat >$out <<EOF
+  cat >"$out" <<EOF
 Usage: ${PROG} [OPTION]... [delay [count]]
 Find out the highest cpu consumed threads of java processes,
 and print the stack of these threads.

bin/uq

@@ -90,9 +90,9 @@ usage() {
   # shellcheck disable=SC2015
   [ "$exit_code" != 0 ] && local -r out=/dev/stderr || local -r out=/dev/stdout
 
-  (($# > 0)) && redPrint "$*$nl" >$out
+  (($# > 0)) && redPrint "$*$nl" >"$out"
 
-  cat >$out <<EOF
+  cat >"$out" <<EOF
 Usage: ${PROG} [OPTION]... [INPUT [OUTPUT]]
 Filter lines from INPUT (or standard input), writing to OUTPUT (or standard output).
 Same as \`uniq\` command in core utils,

bin/xpl

@@ -40,7 +40,7 @@ usage() {
   # shellcheck disable=SC2015
   [ "$exit_code" != 0 ] && local -r out=/dev/stderr || local -r out=/dev/stdout
 
-  (($# > 0)) && printf '%s\n\n' "$*" >$out
+  (($# > 0)) && printf '%s\n\n' "$*" >"$out"
 
   cat <<EOF
 Usage: ${PROG} [OPTION] [FILE]...

lib/console-text-color-themes.sh

@@ -72,21 +72,21 @@ colorEchoWithoutNewLine() {
 
   echo 'Code sample to print color text:'
 
-  echo -n '    echo -e "\033['
+  printf %s '    echo -e "\033['
   colorEchoWithoutNewLine '3;35;40' '1;36;41'
-  echo -n m
+  printf %s m
   colorEchoWithoutNewLine '0;32;40' 'Sample Text'
-  echo '\033[0m"'
+  printf '%s\n' '\033[0m"'
 
-  echo -n "    echo \$'\033["
+  printf %s "    echo \$'\033["
   colorEchoWithoutNewLine '3;35;40' '1;36;41'
-  echo -n "m'\""
+  printf %s "m'\""
   colorEchoWithoutNewLine '0;32;40' 'Sample Text'
-  echo "\"$'\033[0m'"
-  echo "      # NOTE: $'foo' is the escape sequence syntax of bash, safer escape"
+  printf '%s\n' "\"$'\033[0m'"
+  printf '%s\n' "      # NOTE: $'foo' is the escape sequence syntax of bash, safer escape"
 
-  echo 'Output of above code:'
-  echo -n '    '
+  printf '%s\n' 'Output of above code:'
+  printf %s '    '
   colorEcho '1;36;41' 'Sample Text'
   echo
   echo 'If you are going crazy to write text in escapes string like me,'