Skip to content

Commit a62e719

Browse files
committed
Revert "cleanup github action"
This reverts commit dd3181f.
1 parent dd3181f commit a62e719

File tree

5 files changed

+8
-4
lines changed

5 files changed

+8
-4
lines changed

.github/workflows/tests.yml

Lines changed: 8 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -11,12 +11,14 @@ jobs:
1111
image: postgres
1212
env:
1313
POSTGRES_PASSWORD: postgres
14+
# Set health checks to wait until postgres has started
1415
options: >-
1516
--health-cmd pg_isready
1617
--health-interval 10s
1718
--health-timeout 5s
1819
--health-retries 5
1920
ports:
21+
# Maps tcp port 5432 on service container to the host
2022
- 5432:5432
2123

2224
strategy:
@@ -34,11 +36,13 @@ jobs:
3436
with:
3537
ruby-version: ${{ matrix.ruby-version }}
3638
- run: bundle install
37-
env:
38-
BUNDLE_GEMFILE: ${{ github.workspace }}/.github/gemfiles/${{ matrix.gemfile }}.gemfile
39+
env: # $BUNDLE_GEMFILE must be set at the job level, so it is set for all steps
40+
BUNDLE_GEMFILE: ${{ github.workspace }}/gemfiles/${{ matrix.gemfile }}.gemfile
3941
- run: bundle exec rspec
40-
env:
41-
BUNDLE_GEMFILE: ${{ github.workspace }}/.github/gemfiles/${{ matrix.gemfile }}.gemfile
42+
env: # $BUNDLE_GEMFILE must be set at the job level, so it is set for all steps
43+
BUNDLE_GEMFILE: ${{ github.workspace }}/gemfiles/${{ matrix.gemfile }}.gemfile
44+
# The hostname used to communicate with the PostgreSQL service container
4245
POSTGRES_HOST: localhost
46+
# The default PostgreSQL port
4347
POSTGRES_PORT: 5432
4448
POSTGRES_PASSWORD: postgres

0 commit comments

Comments
 (0)