Allow # comments in only/ignore filters

Author: oli-obk

CHANGELOG.md

@@ -14,6 +14,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 ### Changed
 
 * `only`/`ignore` filters now only accept integers, alphabetic characters, `-` and `_`
+* `only`/ `ignore` filters allow comments by ignoring everything from an `#` onwards
 
 ### Removed
 

src/parser.rs

@@ -306,8 +306,8 @@ impl Condition {
                 })).collect::<Result<Vec<_>, _>>()?;
                 Ok(Condition::Bitwidth(bits))
             }
-            "target" => Ok(Condition::Target(args.map(|arg|TargetSubStr::try_from(arg.to_owned())).collect::<Result<_, _>>()?)),
-            "host" => Ok(Condition::Host(args.map(|arg|TargetSubStr::try_from(arg.to_owned())).collect::<Result<_, _>>()?)),
+            "target" => Ok(Condition::Target(args.take_while(|&arg| arg != "#").map(|arg|TargetSubStr::try_from(arg.to_owned())).collect::<Result<_, _>>()?)),
+            "host" => Ok(Condition::Host(args.take_while(|&arg| arg != "#").map(|arg|TargetSubStr::try_from(arg.to_owned())).collect::<Result<_, _>>()?)),
             _ => Err(format!("`{c}` is not a valid condition, expected `on-host`, /[0-9]+bit/, /host-.*/, or /target-.*/")),
         }
     }
@@ -612,7 +612,7 @@ impl CommentParser<Comments> {
             }
             Some(i) => {
                 let (command, args) = command.split_at(i);
-                // Commands are separated from their arguments by ':' or ' '
+                // Commands are separated from their arguments by ':'
                 let next = args
                     .chars()
                     .next()

src/parser/tests.rs

@@ -265,7 +265,7 @@ fn parse_x86_64() {
 
 #[test]
 fn parse_two_only_filters() {
-    let s = r"//@only-target: hello world";
+    let s = r"//@only-target: hello world # some comment";
     let comments = Comments::parse(
         Spanned::new(
             s.as_bytes(),