"Allow always" approval has very suprising behaviour.

[kevincox]

I got a prompt like: "Run the command cargo test?"

The first option is "Allow always". At first I thought that this was whitelisting cargo test. But I was confused when the LLM started running other commands. However after reading the code I realized that it wasn't even just allowing arbitrary use of that tool, it was allowing the use of any tool.

codecompanion.nvim/lua/codecompanion/strategies/chat/tools/orchestrator.lua

Line 281 in 8ad65ee

vim.g.codecompanion_yolo_mode = true

I find this behaviour incredibly surprising (and dangerous). I would recommend changing the text to something like "Allow all tools" or "YOLO mode". Might also make sense to make that option less prominent than being the first option. I would consider something like 1: Deny, 2: Allow, 0: YOLO. This physically moves the entry to yolo mode multiple keys away on the keyboard.

It would also be very useful to have the option to approve specific tools or commands. For example during an editing cycle the LLM will want to run cargo test a lot. I don't feel the need to approve each time. But I definitely still want to review other commands in case they are destructive.

[olimorris]

Completely agree. This needs to be improved. Infact, the docs have not been updated to reflect this. I'll make sure this is on my roadmap.

[kevincox]

Another thing to point out is that the current behaviour globally affects the editor invocation. I wasn't sure if it affected only that window or was per invocation or was persisted somewhere across editor invocations. It would be nice to highlight " for this nvim instance" or something like that. But I'm not sure how to do that without being too wordy.

[olimorris]

You hit the nail on the head with "surprising behaviour". As a user I would expect the approvals that come through the confirmation to apply to that chat and to that tool only (except in the case of the cmd_runner which should be per command).

[olimorris]

This has now been added in #2569 and covered in the configure and usage sections of the docs.

Potentially destructive tools like cmd_runner and delete_file are not part of YOLO mode and can only be "approved always" at a cmd level.

Really appreciate you raising this.