review

Author: oliver006

main.go

@@ -59,14 +59,6 @@ func getEnvInt64(key string, defaultVal int64) int64 {
 	return defaultVal
 }
 
-// validateTLSClientConfig validates TLS client configuration
-func validateTLSClientConfig(certFile, keyFile string) error {
-	if (certFile != "") != (keyFile != "") {
-		return errors.New("TLS client key file and cert file should both be present")
-	}
-	return nil
-}
-
 // loadScripts loads Lua scripts from the provided script paths
 func loadScripts(scriptPath string) (map[string][]byte, error) {
 	if scriptPath == "" {
@@ -206,16 +198,10 @@ func main() {
 		}
 	}
 
-	var ls map[string][]byte
-	if *scriptPath != "" {
-		scripts := strings.Split(*scriptPath, ",")
-		ls = make(map[string][]byte, len(scripts))
-		for _, script := range scripts {
-			if ls[script], err = os.ReadFile(script); err != nil {
-				slog.Error("Error loading script file", "file", script, "error", err)
-				os.Exit(1)
-			}
-		}
+	ls, err := loadScripts(*scriptPath)
+	if err != nil {
+		slog.Error("Error loading script files", "scriptPath", scriptPath, "error", err)
+		os.Exit(1)
 	}
 
 	registry := createPrometheusRegistry(*redisMetricsOnly)

main_test.go

@@ -210,35 +210,6 @@ func TestGetEnvInt64(t *testing.T) {
 	}
 }
 
-func TestValidateTLSClientConfig(t *testing.T) {
-	tests := []struct {
-		name        string
-		certFile    string
-		keyFile     string
-		expectError bool
-	}{
-		{"both files provided", "/path/to/cert.pem", "/path/to/key.pem", false},
-		{"both files empty", "", "", false},
-		{"only cert file provided", "/path/to/cert.pem", "", true},
-		{"only key file provided", "", "/path/to/key.pem", true},
-	}
-
-	for _, tt := range tests {
-		t.Run(tt.name, func(t *testing.T) {
-			err := validateTLSClientConfig(tt.certFile, tt.keyFile)
-			if tt.expectError {
-				if err == nil {
-					t.Errorf("validateTLSClientConfig(%s, %s) expected error but got none", tt.certFile, tt.keyFile)
-				}
-			} else {
-				if err != nil {
-					t.Errorf("validateTLSClientConfig(%s, %s) unexpected error: %v", tt.certFile, tt.keyFile, err)
-				}
-			}
-		})
-	}
-}
-
 func TestLoadScripts(t *testing.T) {
 	// Create temporary directory for test scripts
 	tmpDir := t.TempDir()
@@ -368,15 +339,6 @@ func TestMainFunctionsIntegration(t *testing.T) {
 		t.Errorf("Script content mismatch")
 	}
 
-	// Test TLS validation
-	if err := validateTLSClientConfig("/cert.pem", ""); err == nil {
-		t.Error("Expected TLS validation error for mismatched cert/key")
-	}
-
-	if err := validateTLSClientConfig("/cert.pem", "/key.pem"); err != nil {
-		t.Errorf("Unexpected TLS validation error: %v", err)
-	}
-
 	// Test registry creation
 	registry := createPrometheusRegistry(true)
 	if registry == nil {