Skip to content

Commit 54fab24

Browse files
committed
[TASK] Enable more warnings in the tests
Also drop configuration values that are the same as their corresponding default values.
1 parent 6d92822 commit 54fab24

File tree

2 files changed

+10
-24
lines changed

2 files changed

+10
-24
lines changed

Configuration/FunctionalTests.xml

Lines changed: 6 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -2,24 +2,17 @@
22
<phpunit xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
33
xsi:noNamespaceSchemaLocation="https://schema.phpunit.de/9.6/phpunit.xsd"
44
backupGlobals="true"
5-
backupStaticAttributes="false"
6-
beStrictAboutTestsThatDoNotTestAnything="false"
5+
beStrictAboutCoversAnnotation="true"
6+
beStrictAboutOutputDuringTests="true"
77
bootstrap="../.Build/vendor/typo3/testing-framework/Resources/Core/Build/FunctionalTestsBootstrap.php"
88
cacheResult="false"
99
colors="true"
10-
convertDeprecationsToExceptions="false"
11-
convertErrorsToExceptions="true"
12-
convertNoticesToExceptions="true"
13-
convertWarningsToExceptions="true"
10+
convertDeprecationsToExceptions="true"
1411
failOnRisky="true"
1512
failOnWarning="true"
16-
forceCoversAnnotation="false"
17-
stopOnError="false"
18-
stopOnFailure="false"
19-
stopOnIncomplete="false"
20-
stopOnSkipped="false"
21-
verbose="false"
13+
forceCoversAnnotation="true"
2214
>
15+
2316
<php>
2417
<!-- @deprecated: will be removed with next major version, constant TYPO3_MODE is deprecated -->
2518
<const name="TYPO3_MODE" value="BE"/>
@@ -29,7 +22,7 @@
2922
Will always be done with next major version.
3023
To still suppress warnings, notices and deprecations, do NOT define the constant at all.
3124
-->
32-
<!-- <const name="TYPO3_TESTING_FUNCTIONAL_REMOVE_ERROR_HANDLER" value="true"/>-->
25+
<const name="TYPO3_TESTING_FUNCTIONAL_REMOVE_ERROR_HANDLER" value="true"/>
3326
<ini name="display_errors" value="1"/>
3427
<env name="TYPO3_CONTEXT" value="Testing"/>
3528
</php>

Configuration/UnitTests.xml

Lines changed: 4 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -2,25 +2,18 @@
22
<phpunit xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
33
xsi:noNamespaceSchemaLocation="https://schema.phpunit.de/9.6/phpunit.xsd"
44
backupGlobals="true"
5-
backupStaticAttributes="false"
6-
beStrictAboutTestsThatDoNotTestAnything="false"
5+
beStrictAboutChangesToGlobalState="true"
6+
beStrictAboutCoversAnnotation="true"
7+
beStrictAboutOutputDuringTests="true"
78
bootstrap="../.Build/vendor/typo3/testing-framework/Resources/Core/Build/UnitTestsBootstrap.php"
89
cacheResult="false"
910
colors="true"
1011
convertDeprecationsToExceptions="true"
11-
convertErrorsToExceptions="true"
12-
convertNoticesToExceptions="true"
13-
convertWarningsToExceptions="true"
1412
failOnRisky="true"
1513
failOnWarning="true"
1614
forceCoversAnnotation="true"
17-
processIsolation="false"
18-
stopOnError="false"
19-
stopOnFailure="false"
20-
stopOnIncomplete="false"
21-
stopOnSkipped="false"
22-
verbose="false"
2315
>
16+
2417
<php>
2518
<!-- @deprecated: will be removed with next major version, constant TYPO3_MODE is deprecated -->
2619
<const name="TYPO3_MODE" value="BE"/>

0 commit comments

Comments
 (0)