Skip to content

Commit 3db1c0e

Browse files
authored
Update Reviewer_Checklist.md
1 parent 281812c commit 3db1c0e

File tree

1 file changed

+1
-0
lines changed

1 file changed

+1
-0
lines changed

doc/guide/Reviewer_Checklist.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@
55
* The code should be easily readable (for infos e.g. here [here](https://treyhunner.com/2017/07/craft-your-python-like-poetry/?__s=jf8h91lx6zhl7vv6o9jo))
66
* Variable names should be chosen to be clear. Avoid `item, element, var, list` etc...
77
* Avoid as much as possible hard-coded indices for list (no `x = l[0], y = l[1]`) (see also [here](https://treyhunner.com/2018/03/tuple-unpacking-improves-python-code-readability/))
8+
* Avoid mutable as default values for functions and methods.
89
* Use pythonic loops, list comprehensions etc.
910
* Make sure the unit test are testing all the relevant parts of the code
1011
* Check the docstring (is everything clearly explained, are the default values given an clear)

0 commit comments

Comments
 (0)