You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Copy file name to clipboardExpand all lines: doc/guide/Reviewer_Checklist.md
+1Lines changed: 1 addition & 0 deletions
Display the source diff
Display the rich diff
Original file line number
Diff line number
Diff line change
@@ -5,6 +5,7 @@
5
5
* The code should be easily readable (for infos e.g. here [here](https://treyhunner.com/2017/07/craft-your-python-like-poetry/?__s=jf8h91lx6zhl7vv6o9jo))
6
6
* Variable names should be chosen to be clear. Avoid `item, element, var, list` etc...
7
7
* Avoid as much as possible hard-coded indices for list (no `x = l[0], y = l[1]`) (see also [here](https://treyhunner.com/2018/03/tuple-unpacking-improves-python-code-readability/))
8
+
* Avoid mutable as default values for functions and methods.
8
9
* Use pythonic loops, list comprehensions etc.
9
10
* Make sure the unit test are testing all the relevant parts of the code
10
11
* Check the docstring (is everything clearly explained, are the default values given an clear)
0 commit comments