Check IP, settings Payouts

[belmix]

I did not find in the code checking ip


the table also does not contain the miner's ip
if you look at the code, any user can change the payment settings for any account

The IP address is only in the table of shares, but it is not related to the validation of the request sent.

[oliverw]

The IP address is only in the table of shares, but it is not related to the validation of the request sent.

Wrong. The latter part is the whole point of the implementation.

[belmix]

{"paymentThreshold":"0",
"PoolId":"dgb",
"Address":"DGoajbBjSSqqVhDq5Hk6dQxh8CLnZFL2ir"}

ip address should also be in the request?

[oliverw]

Of course.

[belmix]

{"paymentThreshold":"0",
"PoolId":"dgb",
"Address":"DGoajbBjSSqqVhDq5Hk6dQxh8CLnZFL2ir",
"ip":"x.x.x.x"}

right?

[oliverw]

My apologies. I didn't realize that master still has the old implementation. The current implementation is in the dev branch (oliverw): https://github.com/coinfoundry/miningcore/blob/oliverw/src/Miningcore/Api/Controllers/PoolApiController.cs

I will push a new release later today.

[belmix]

ok thx,
I will add FCH and DVT this week
I don't know, maybe anyone needs it, I can still unload the customs fee
https://github.com/belmix/MinigcoreNET5/commits/master

implementation allows you to make not only individual fee, but can also be used as a blacklist
"percentageFeeCustom" : 1.0,

[riksarchen]

Please add description how to use this for the average user

[belmix]

is it relevant or is the structure different?

[oliverw]

is it relevant or is the structure different?

paymentthreshold does not contain an underscore.

[belmix]

Example for DVT Coin:

SET ROLE miningcore;
DROP TABLE miner_settings;
CREATE TABLE miner_settings
(
poolid TEXT NOT NULL PRIMARY KEY,
address TEXT NOT NULL,
paymentthreshold decimal(28,12) NOT NULL,
created TIMESTAMP NOT NULL,
updated TIMESTAMP NOT NULL
) PARTITION BY LIST (poolid);

CREATE TABLE miner_settings_dvt PARTITION OF miner_settings FOR VALUES IN ('dvt');

[belmix]

👍👍👍👍👍