Skip to content

Commit 09bf581

Browse files
gandazguloliviertassinari
authored andcommitted
Add handling for removing propTypes from babel output code (#163)
* Added handling for removing propTypes from babel output code So this is a third party library that ships their compiled code with propTypes, with this change it will removed. * Renamed create-class test to react-create-class it tests that module Added create-class test for the case covered in this change
1 parent 0c143f3 commit 09bf581

File tree

5 files changed

+37
-5
lines changed

5 files changed

+37
-5
lines changed

src/index.js

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -221,7 +221,10 @@ export default function(api) {
221221
return false
222222
}
223223

224-
return currentNode.get('callee').node.name === 'createReactClass'
224+
return (
225+
currentNode.get('callee').node.name === 'createReactClass' ||
226+
currentNode.get('callee').node.property.name === 'createClass'
227+
)
225228
})
226229

227230
if (parent) {
Lines changed: 12 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,18 @@
1-
var createReactClass = require('create-react-class');
1+
var _react2 = require('react');
22
var PropTypes = require('prop-types');
33

4-
createReactClass({
4+
// react >= 15.6
5+
var Class1 = _react2.default.createClass({
6+
displayName: 'Class1',
57
propTypes: {
68
foo: PropTypes.string,
79
},
810
});
11+
12+
// react < 15.6
13+
var Class2 = _react2.default.createClass({
14+
displayName: 'Class2',
15+
propTypes: {
16+
foo: _react2.default.PropTypes.string,
17+
},
18+
});
Lines changed: 10 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,11 @@
1-
var createReactClass = require('create-react-class');
1+
var _react2 = require('react');
22

3-
createReactClass({});
3+
// react >= 15.6
4+
var Class1 = _react2.default.createClass({
5+
displayName: 'Class1'
6+
}); // react < 15.6
7+
8+
9+
var Class2 = _react2.default.createClass({
10+
displayName: 'Class2'
11+
});
Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,8 @@
1+
var createReactClass = require('create-react-class');
2+
var PropTypes = require('prop-types');
3+
4+
createReactClass({
5+
propTypes: {
6+
foo: PropTypes.string,
7+
},
8+
});
Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,3 @@
1+
var createReactClass = require('create-react-class');
2+
3+
createReactClass({});

0 commit comments

Comments
 (0)