Skip to content

Commit 1c07e7b

Browse files
Merge pull request #109 from newyork-anthonyng/master
Update README.md
2 parents 9ce8ff2 + dfa09d5 commit 1c07e7b

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

README.md

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -183,18 +183,18 @@ both will be removed.
183183

184184
## Is it safe?
185185

186-
If you are using the `propTypes` in a conventionnal way,
186+
If you are using the `propTypes` in a conventional way,
187187
i.e by using them to perform type checking on the properties, that plugin should be **safe to use**.
188188

189189
However, some libraries are accessing the `propTypes` on the component directly.
190190
For instance [react-native-vector-icons](https://github.com/oblador/react-native-vector-icons/blob/3d1f2a5b7175d6e4c8985676940240776543ff60/lib/icon-button.js#L59) use them to split the properties between two components:
191191
```js
192192
const touchableProps = pick(restProps, Object.keys(TouchableHighlight.propTypes));
193193
```
194-
:warning: The plugin is breaking that code if he end-up removing `TouchableHighlight.propTypes`.
194+
:warning: The plugin is breaking that code if it ends up removing `TouchableHighlight.propTypes`.
195195

196196
Make sure you are:
197-
- Not using that pattern in your souce code.
197+
- Not using that pattern in your source code.
198198
If you do, explicitly **export** the `propTypes` to work around that limitation.
199199
- Not parsing the `node_modules`.
200200
If you do, test that your code is still working before shipping into production.

0 commit comments

Comments
 (0)