Fix babel readonly (#167)

* Add failing test case for const scoped

* Fix babel read-only error

* try something else

* add a new unit test

Author: eps1lon

package.json

@@ -8,10 +8,9 @@
     "test:unit": "mocha",
     "test:watch": "mocha -w",
     "prettier": "find . -name \"*.js\" | grep -v -f .eslintignore | xargs prettier --write",
-    "test": "npm run lint && npm run test:unit && npm run flow",
+    "test": "npm run lint && npm run test:unit",
     "prebuild": "rm -rf lib/",
     "build": "babel src --out-dir lib",
-    "flow": "flow",
     "version": "npm run build && pkgfiles"
   },
   "repository": {
@@ -53,7 +52,6 @@
     "eslint-plugin-mocha": "^4.11.0",
     "eslint-plugin-prettier": "^2.3.1",
     "eslint-plugin-react": "^7.4.0",
-    "flow-bin": "^0.59.0",
     "mocha": "^4.0.1",
     "path-exists": "^3.0.0",
     "pkgfiles": "^2.3.2",

src/index.js

@@ -1,4 +1,3 @@
-// @flow weak
 /* eslint-disable global-require, import/no-dynamic-require */
 
 // import generate from 'babel-generator';
@@ -288,6 +287,11 @@ export default function(api) {
         let skippedIdentifiers = 0
         const removeNewlyUnusedIdentifiers = {
           VariableDeclarator(path) {
+            // Only consider the top level scope.
+            if (path.scope.block.type !== 'Program') {
+              return
+            }
+
             if (['ObjectPattern', 'ArrayPattern'].includes(path.node.id.type)) {
               // Object or Array destructuring, so we will want to capture all
               // the names created by the destructuring. This currently doesn't
@@ -309,7 +313,7 @@ export default function(api) {
             // removedPaths Set. We need to do this in order to support the wrap
             // option, which doesn't actually remove the references.
             const hasRemainingReferencePaths = referencePaths.some(referencePath => {
-              const found = referencePath.find(p => removedPaths.has(p))
+              const found = referencePath.find(path2 => removedPaths.has(path2))
               return !found
             })
 

src/isAnnotatedForRemoval.js

@@ -1,7 +1,5 @@
-// @flow weak
-
-export default function(node) {
+export default function isAnnotatedForRemoval(node) {
   const comments = node.trailingComments || []
 
-  return !!comments.find(({ value }) => value.trim() === 'remove-proptypes')
+  return Boolean(comments.find(({ value }) => value.trim() === 'remove-proptypes'))
 }

src/isStatelessComponent.js

@@ -1,5 +1,3 @@
-// @flow weak
-
 const traversed = Symbol('traversed')
 
 function isJSXElementOrReactCreateElement(path) {

src/remove.js

@@ -1,4 +1,3 @@
-// @flow weak
 /* eslint-disable no-param-reassign */
 
 function isInside(scope, regex) {

test/fixtures.test.js

@@ -23,7 +23,7 @@ describe('fixtures', () => {
       const fixtureDir = path.join(fixturesDir, caseName)
 
       // Only run a specific test
-      // if (caseName !== 'recursive') {
+      // if (caseName !== 'const-in-anonymous-validator') {
       //   return
       // }
 

test/fixtures/const-in-anonymous-validator/actual.js

@@ -0,0 +1,38 @@
+import React, {PropTypes} from 'react';
+
+const Component = () => (
+  <div />
+);
+
+const referencedPropTypes = {
+   variant3: () => {
+    const willBeWrapped = 1;
+    return null;
+  }
+}
+
+Component.propTypes = {
+  variant1: props => {
+    const variants = [null];
+    return variantſ[0];
+  },
+  variant2: chainPropTypes(
+    PropTypes.oneOf(['foo']),
+    props => {
+      const deprecatedVariants = [
+        'display4',
+        'display3',
+        'display2',
+        'display1',
+        'headline',
+        'title',
+        'subheading',
+      ];
+
+      return null;
+    },
+  ),
+  ...referencedPropTypes,
+};
+
+export default Component;

test/fixtures/const-in-anonymous-validator/expected-remove-es5.js

@@ -0,0 +1,15 @@
+"use strict";
+
+Object.defineProperty(exports, "__esModule", {
+  value: true
+});
+exports.default = void 0;
+
+var _react = babelHelpers.interopRequireWildcard(require("react"));
+
+var Component = function Component() {
+  return _react.default.createElement("div", null);
+};
+
+var _default = Component;
+exports.default = _default;

test/fixtures/const-in-anonymous-validator/expected-remove-es6.js

@@ -0,0 +1,5 @@
+import React, { PropTypes } from 'react';
+
+const Component = () => <div />;
+
+export default Component;

test/fixtures/const-in-anonymous-validator/expected-wrap-es5.js

@@ -0,0 +1,31 @@
+"use strict";
+
+Object.defineProperty(exports, "__esModule", {
+  value: true
+});
+exports.default = void 0;
+
+var _react = babelHelpers.interopRequireWildcard(require("react"));
+
+var Component = function Component() {
+  return _react.default.createElement("div", null);
+};
+
+var referencedPropTypes = process.env.NODE_ENV !== "production" ? {
+  variant3: function variant3() {
+    var willBeWrapped = 1;
+    return null;
+  }
+} : {};;
+Component.propTypes = process.env.NODE_ENV !== "production" ? babelHelpers.objectSpread({
+  variant1: function variant1(props) {
+    var variants = [null];
+    return variantſ[0];
+  },
+  variant2: chainPropTypes(_react.PropTypes.oneOf(['foo']), function (props) {
+    var deprecatedVariants = ['display4', 'display3', 'display2', 'display1', 'headline', 'title', 'subheading'];
+    return null;
+  })
+}, referencedPropTypes) : {};
+var _default = Component;
+exports.default = _default;