fix: make streaming response fields optional in ChatResponse and GenerateResponse#281
Open
abdelhadi703 wants to merge 1 commit intoollama:mainfrom
Open
fix: make streaming response fields optional in ChatResponse and GenerateResponse#281abdelhadi703 wants to merge 1 commit intoollama:mainfrom
abdelhadi703 wants to merge 1 commit intoollama:mainfrom
Conversation
…rateResponse Fields like total_duration, load_duration, prompt_eval_count, prompt_eval_duration, eval_count, eval_duration, done_reason, and context are only present in the final streaming response when done=true. Making them required causes TypeScript errors when consuming intermediate streaming chunks. This makes them optional with `?` to match the actual API behavior. Fixes ollama#262 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
done: true) optional in theChatResponseandGenerateResponseinterfacesdone_reason,total_duration,load_duration,prompt_eval_count,prompt_eval_duration,eval_count,eval_duration, andcontext(GenerateResponse only)Fixes #262
Changes
src/interfaces.ts: Add?optional modifier to completion-only fields in bothChatResponseandGenerateResponseinterfacesTest plan
unbuild.d.tsfiles🤖 Generated with Claude Code