Fix: Prevent crash when retrieving metadata with Sharp for many large images (Linux only)

Author: ollm

CHANGELOG.md

@@ -18,14 +18,15 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
 - Hide file extension by default [`ad33247`](https://github.com/ollm/OpenComic/commit/ad332470f47b1f110f22ee85a4384f75a19bce99)
 - Support playing background music on a specific page [`23aae8a`](https://github.com/ollm/OpenComic/commit/23aae8abdc8c1bd983411f0f9eeac974218694fa)
 - Options in OPDS to auto-download files from the catalog [`594d69f`](https://github.com/ollm/OpenComic/commit/594d69f81e3740c0be32e284dac3aed1aba69de9)
-- Support for tabs
+- Support for tabs [`d9f7fa0`](https://github.com/ollm/OpenComic/commit/d9f7fa048b743c918c44e077e0bae08705e7b8c0)
 
 ##### 🐛 Bug Fixes
 
 - Adding or changing poster not working when the drive is different from the system drive [`8ce3d5f`](https://github.com/ollm/OpenComic/commit/8ce3d5f01a7694c26fa1e6d477c1eab99c299a0e)
 - Hiding cursor in fullscreen mode fails in some cases [`828d504`](https://github.com/ollm/OpenComic/commit/828d504e700e43ab1f6d9e5081195ad496f65920)
 - Save/Copy uses the image under the mouse cursor instead of the active page [`26c5923`](https://github.com/ollm/OpenComic/commit/26c5923d5dc920b691be5db591c20b8b92d9f320)
 - Error saving the progress of the final page in epub files [`ff42c18`](https://github.com/ollm/OpenComic/commit/ff42c181e7a6a324ef1065c836dc0ed175e1b623)
+- Prevent crash when retrieving metadata with Sharp for many large images (Linux only)
 
 ## [v1.6.5](https://github.com/ollm/OpenComic/releases/tag/v1.6.5) (31-10-2025)
 

scripts/child-fork.js

@@ -180,9 +180,21 @@ async function resizeToBlob() {
 
 }
 
+async function metadata() {
+
+	const fork = getFork();
+
+	return fork.work({
+		job: 'metadata',
+		args: [...arguments],
+	});
+
+}
+
 module.exports = {
 	ChildFork,
 	config,
 	_resize,
 	resizeToBlob,
+	metadata,
 };

scripts/fork.js

@@ -56,6 +56,29 @@ process.on('message', async function(data) {
 
 			process.send(message);
 
+			break;
+
+		case 'metadata':
+
+			message = {
+				index: data.index,
+				result: false,
+				error: false,
+			};
+
+			try
+			{
+				const result = await image.metadata(...data.args);
+				message.result = result;
+			}
+			catch(error)
+			{
+				console.log(error);
+				message.error = error.message;
+			}
+
+			process.send(message);
+
 			break;
 	}
 

scripts/image.js

@@ -307,6 +307,14 @@ function loadImage(url, encode = false)
 	});
 }
 
+async function metadata(path)
+{
+	await loadSharp();
+
+	const _sharp = sharp(path);
+	return await _sharp.metadata();
+}
+
 var sizesCache = {};
 
 async function getSizes(images)
@@ -411,13 +419,11 @@ async function getSizes(images)
 					catch(error)
 					{
 						const image = await workers.convertImage(path);
-
-						const _sharp = sharp(image);
-						const metadata = await _sharp.metadata();
+						const _metadata = await metadata(image);
 
 						size = {
-							width: metadata.width,
-							height: metadata.height,
+							width: _metadata.width,
+							height: _metadata.height,
 						};
 					}
 				}
@@ -426,12 +432,13 @@ async function getSizes(images)
 					try
 					{
 						fileManager.macosStartAccessingSecurityScopedResource(image.image);
-						const _sharp = sharp(app.shortWindowsPath(image.image));
-						const metadata = await _sharp.metadata();
+
+						const path = app.shortWindowsPath(image.image);
+						const _metadata = useChildFork ? await childFork.metadata(path) : await metadata(path);
 
 						size = {
-							width: metadata.width,
-							height: metadata.height,
+							width: _metadata.width,
+							height: _metadata.height,
 						};
 					}
 					catch(error)
@@ -460,7 +467,7 @@ async function getSizes(images)
 			}
 			catch(error)
 			{
-				console.error(error);
+				console.error(image.image, error);
 			}
 
 			sizesCache[sha] = size;
@@ -485,5 +492,6 @@ module.exports = {
 	isAnimated: isAnimated,
 	sharpSupportedFormat: sharpSupportedFormat,
 	loadImage: loadImage,
+	metadata: metadata,
 	getSizes: getSizes,
 };