v3.0 (793)

Author: tbaigner

CHANGELOG.en.md

@@ -1,5 +1,26 @@
 # Changelog
 
+## [3.0 (793)] - 2024-06-28
+
+- Reliability Boost: Significant improvements in multi-device settings, ensuring a smoother experience across all devices.
+- Instant Connections: When adding a new contact, you can now start chatting immediately, with no waiting time whatsoever.
+- URL Preview Refinement: When a preview is available, URLs at the end of messages are now hidden.
+- Read Message Sync: Fixed an issue where messages marked as read on one device would incorrectly remain unread on other devices.
+- Secure Call Stability: Resolved a rare issue with secure calls in multi-device settings, where calls could occasionally hang up after 30 seconds.
+- Enhanced Notification Reliability: Improved notifications for messages received in recently joined groups, ensuring consistent delivery across all devices.
+- Draft Fix: Resolved an issue where drafts with attachments but no text couldn't be sent using the keyboard shortcut.
+- Multi-Device Discussion Deletion: Fixed various issues related to deleting discussions across multiple devices.
+- Admin Preserved in Group Cloning: Cloning a group now retains the admin's chosen settings.
+- Duration Display and Modification Fix: Fixed a bug preventing the display and modification of existence or visibility durations outside of enum values.
+- Database Migration Recovery: Improved strategies to recover from certain database migration errors.
+- Miscellaneous Improvements and Bug Fixes: Various minor enhancements and bug fixes to further enhance the overall user experience.
+
+## [2.5 (782)] - 2024-06-06
+
+- Resolved an intermittent issue with profile transfers from other devices.
+- Enhanced the cryptographic library.
+- Various minor improvements and bug fixes.
+
 ## [2.4 (778)] - 2024-06-03
 
 ### macOS

CHANGELOG.fr.md

@@ -1,5 +1,26 @@
 # Changelog
 
+## [3.0 (793)] - 2024-06-28
+
+- Amélioration de la fiabilité: Des améliorations significatives dans les paramètres multi-appareils, garantissant une expérience plus fluide sur tous les appareils.
+- Connexions instantanées: Lors de l'ajout d'un nouveau contact, vous pouvez maintenant démarrer une conversation immédiatement, sans délai aucun.
+- Raffinement de l'aperçu URL: Lorsqu'un prévisualisation est disponible, les URLs en fin des messages sont maintenant cachées.
+- Synchronisation des messages lus: Correction d'un problème où les messages marqués comme lus sur un appareil restaient incorrectement non lus sur d'autres appareils.
+- Stabilité des appels sécurisés: Résolution d'un problème rare avec les appels sécurisés dans les paramètres multi-appareils, où les appels pouvaient occasionnellement être coupés après 30 secondes.
+- Fiabilité améliorée des notifications: Amélioration des notifications pour les messages reçus dans les groupes récemment joints, garantissant une livraison cohérente sur tous les appareils.
+- Correction de brouillon: Résolution d'un problème où les brouillons avec des pièces jointes mais sans texte ne pouvaient pas être envoyés à l'aide du raccourci clavier.
+- Suppression de discussion multi-appareil: Correction de divers problèmes liés à la suppression de discussions sur plusieurs appareils.
+- Administrateur préservé lors du clonage de groupe: Le clonage d'un groupe conserve maintenant les paramètres choisis par l'administrateur.
+- Correction de l'affichage et de la modification des durées: Correction d'un bug empêchant l'affichage et la modification des durées d'existence ou de visibilité en dehors des valeurs énumérées.
+- Récupération après erreur de migration de base de données: Amélioration des stratégies pour récupérer d'éventuelles erreurs de migration de base de données.
+- Autres améliorations et corrections de bugs mineures: Diverses améliorations et corrections de bugs mineures pour améliorer l'expérience utilisateur globale.
+
+## [2.5 (782)] - 2024-06-06
+
+- Résolution d'un problème intermittent lors du transfert d'un profil depuis un autre appareil.
+- Amélioration de la bibliothèque cryptographique.
+- Diverses améliorations mineures et corrections de bugs.
+
 ## [2.4 (778)] - 2024-05-31
 
 ### macOS

Engine/BigInt/BigInt/BigInt/BigInt.swift

@@ -395,6 +395,10 @@ final public class BigInt: Comparable, Hashable, CustomDebugStringConvertible, D
     public func isNonNegative() -> Bool {
         return self.readVal._mp_size >= 0
     }
+    
+    public func isPositive() -> Bool {
+        return self.readVal._mp_size > 0
+    }
 
     public class func cmp(op1: BigInt, op2: BigInt) -> Int {
         return Int(__gmpz_cmp(&op1.readVal, &op2.readVal))

Engine/ObvBackupManager/ObvBackupManager/ObvBackupManagerImplementation.swift

@@ -609,7 +609,10 @@ extension ObvBackupManagerImplementation {
 
                     os_log("Encrypting the full backup for backupRequestIdentifier %{public}@", log: log, type: .info, backupRequestIdentifier.description)
 
-                    let encryptedBackup = PublicKeyEncryption.encrypt(fullBackupData, using: derivedKeysForBackup.publicKeyForEncryption, and: prng)
+                    guard let encryptedBackup = PublicKeyEncryption.encrypt(fullBackupData, using: derivedKeysForBackup.publicKeyForEncryption, and: prng) else {
+                        assertionFailure()
+                        throw Self.makeError(message: "Failed to encrypt full backup data")
+                    }
                     let macOfEncryptedBackup = try MAC.compute(forData: encryptedBackup, withKey: derivedKeysForBackup.macKey)
                     let authenticatedEncryptedBackup = EncryptedData(data: encryptedBackup.raw + macOfEncryptedBackup)
 

Engine/ObvChannelManager/ObvChannelManager/ChannelTypes/ObvAsymmetricChannel.swift

@@ -47,8 +47,9 @@ final class ObvAsymmetricChannel: ObvNetworkChannel {
     // MARK: Init
 
     init(to identity: ObvCryptoIdentity, deviceUid: UID, delegateManager: ObvChannelDelegateManager) throws {
-        guard let delegate =  delegateManager.keyWrapperForIdentityDelegate else {
-            throw ObvAsymmetricChannel.makeError(message: "The key wrapper delegate is not set")
+        guard let delegate = delegateManager.keyWrapperForIdentityDelegate else {
+            assertionFailure()
+            throw ObvError.keyWrapperForIdentityDelegateIsNil
         }
         self.keyWrapperForIdentityDelegate = delegate
         self.identity = identity
@@ -59,26 +60,38 @@ final class ObvAsymmetricChannel: ObvNetworkChannel {
 
     // MARK: Encryption/Wrapping method and helpers
 
-    func wrapMessageKey(_ messageKey: AuthenticatedEncryptionKey, randomizedWith prng: PRNGService) -> ObvNetworkMessageToSend.Header {
-        let wrappedMessageKey = keyWrapperForIdentityDelegate.wrap(messageKey, for: identity, randomizedWith: prng)
+    func wrapMessageKey(_ messageKey: AuthenticatedEncryptionKey, randomizedWith prng: PRNGService) -> ObvNetworkMessageToSend.Header? {
+        guard let wrappedMessageKey = keyWrapperForIdentityDelegate.wrap(messageKey, for: identity, randomizedWith: prng) else {
+            assertionFailure()
+            return nil
+        }
         let header = ObvNetworkMessageToSend.Header(toIdentity: identity, deviceUid: deviceUid, wrappedMessageKey: wrappedMessageKey)
         return header
     }
 
     // MARK: Decryption/Unwrapping method and helpers
 
-    static func unwrapMessageKey(wrappedKey: EncryptedData, toOwnedIdentity: ObvCryptoIdentity, delegateManager: ObvChannelDelegateManager, within obvContext: ObvContext) -> (AuthenticatedEncryptionKey, ObvProtocolReceptionChannelInfo)? {
+    static func unwrapMessageKey(wrappedKey: EncryptedData, toOwnedIdentity: ObvCryptoIdentity, delegateManager: ObvChannelDelegateManager, within obvContext: ObvContext) throws -> UnwrapMessageKeyResult {
 
         let log = OSLog(subsystem: delegateManager.logSubsystem, category: ObvAsymmetricChannel.logCategory)
 
         guard let keyWrapperForIdentityDelegate = delegateManager.keyWrapperForIdentityDelegate else {
             os_log("The key wrapper for identity delegate is not set", log: log, type: .fault)
-            return nil
+            assertionFailure()
+            throw ObvError.keyWrapperForIdentityDelegateIsNil
         }
 
-        guard let messageKey = keyWrapperForIdentityDelegate.unwrap(wrappedKey, for: toOwnedIdentity, within: obvContext) else { return nil }
-        return (messageKey, ObvProtocolReceptionChannelInfo.AsymmetricChannel)
+        guard let messageKey = keyWrapperForIdentityDelegate.unwrap(wrappedKey, for: toOwnedIdentity, within: obvContext) else { return .couldNotUnwrap }
+        return .unwrapSucceeded(messageKey: messageKey,
+                                receptionChannelInfo: .asymmetricChannel,
+                                updateOrCheckGKMV2SupportOnMessageContentAvailable: nil)
     }
+    
+    
+    enum ObvError: Error {
+        case keyWrapperForIdentityDelegateIsNil
+    }
+    
 }
 
 extension ObvAsymmetricChannel {
@@ -91,7 +104,7 @@ extension ObvAsymmetricChannel {
 
         switch message.channelType {
 
-        case .AsymmetricChannel(to: let toIdentity, remoteDeviceUids: let remoteDeviceUids, fromOwnedIdentity: _):
+        case .asymmetricChannel(to: let toIdentity, remoteDeviceUids: let remoteDeviceUids, fromOwnedIdentity: _):
             // Only protocol messages may be sent through AsymmetricChannel channels
             guard message.messageType == .ProtocolMessage else {
                 throw ObvAsymmetricChannel.makeError(message: "Only protocol messages may be sent through AsymmetricChannel channels")
@@ -101,7 +114,7 @@ extension ObvAsymmetricChannel {
                 try ObvAsymmetricChannel(to: toIdentity, deviceUid: $0, delegateManager: delegateManager)
             }
 
-        case .AsymmetricChannelBroadcast(to: let toIdentity, fromOwnedIdentity: _):
+        case .asymmetricChannelBroadcast(to: let toIdentity, fromOwnedIdentity: _):
             // Only protocol messages may be sent through AsymmetricChannel channels
             guard message.messageType == .ProtocolMessage else {
                 throw ObvAsymmetricChannel.makeError(message: "Only protocol messages may be sent through AsymmetricChannel channels")

Engine/ObvChannelManager/ObvChannelManager/ChannelTypes/ObvChannel.swift

@@ -1,6 +1,6 @@
 /*
  *  Olvid for iOS
- *  Copyright © 2019-2022 Olvid SAS
+ *  Copyright © 2019-2024 Olvid SAS
  *
  *  This file is part of Olvid for iOS.
  *
@@ -36,14 +36,26 @@ protocol ObvChannel {
 
 }
 
+/// Only relevant for an `ObvObliviousChannel`.
+typealias UpdateGKMV2SupportOnMessageContentAvailable = (Data) throws -> Void
+
 protocol ObvNetworkChannel: ObvChannel {
 
-    func wrapMessageKey(_ messageKey: AuthenticatedEncryptionKey, randomizedWith prng: PRNGService) -> ObvNetworkMessageToSend.Header
+    func wrapMessageKey(_ messageKey: AuthenticatedEncryptionKey, randomizedWith prng: PRNGService) -> ObvNetworkMessageToSend.Header?
 
-    static func unwrapMessageKey(wrappedKey: EncryptedData, toOwnedIdentity: ObvCryptoIdentity, delegateManager: ObvChannelDelegateManager, within obvContext: ObvContext) throws -> (AuthenticatedEncryptionKey, ObvProtocolReceptionChannelInfo)?
+    static func unwrapMessageKey(wrappedKey: EncryptedData, toOwnedIdentity: ObvCryptoIdentity, delegateManager: ObvChannelDelegateManager, within obvContext: ObvContext) throws -> UnwrapMessageKeyResult
 
 }
 
+
+enum UnwrapMessageKeyResult {
+    case unwrapSucceeded(messageKey: AuthenticatedEncryptionKey, receptionChannelInfo: ObvProtocolReceptionChannelInfo, updateOrCheckGKMV2SupportOnMessageContentAvailable: UpdateGKMV2SupportOnMessageContentAvailable?)
+    case unwrapSucceededButRemoteCryptoIdIsUnknown(remoteCryptoIdentity: ObvCryptoIdentity) // Only used by PreKey channel
+    case couldNotUnwrap
+    case contactIsRevokedAsCompromised
+}
+
+
 extension ObvNetworkChannel {
 
     private static var errorDomain: String { "ObvNetworkChannel" }
@@ -53,25 +65,15 @@ extension ObvNetworkChannel {
         return NSError(domain: errorDomain, code: 0, userInfo: userInfo)
     }
 
-    private static func generateMessageKeyAndHeaders(using acceptableChannels: [ObvNetworkChannel], randomizedWith prng: PRNGService) -> (AuthenticatedEncryptionKey, [ObvNetworkMessageToSend.Header])? {
-        let cryptoSuiteVersion = acceptableChannels.reduce(ObvCryptoSuite.sharedInstance.latestVersion) { min($0, $1.cryptoSuiteVersion) }
-        guard let authEnc = ObvCryptoSuite.sharedInstance.authenticatedEncryption(forSuiteVersion: cryptoSuiteVersion) else {
-            return nil
-        }
-        let messageKey = authEnc.generateKey(with: prng)
-        let headers = acceptableChannels.map { $0.wrapMessageKey(messageKey, randomizedWith: prng) }
-        return (messageKey, headers)
-    }
-
     /// Generates one or more `ObvNetworkMessageToSend` for the given `ObvChannelMessageToSend`. The reasons why multiple messages can be returned is that we generate one message for server URL found in the destination identities.
-    private static func generateObvNetworkMessagesToSend(from message: ObvChannelMessageToSend, messageKey: AuthenticatedEncryptionKey, headers: [ObvNetworkMessageToSend.Header], randomizedWith prng: PRNGService) throws -> [ObvNetworkMessageToSend] {
+    private static func generateObvNetworkMessagesToSend(from message: ObvChannelMessageToSend, acceptableChannels: [ObvNetworkChannel], randomizedWith prng: PRNGService, log: OSLog) throws -> [ObvNetworkMessageToSend] {
 
         let wrapperMessage: ObvChannelMessageToSendWrapper?
         switch message.messageType {
         case .ProtocolMessage:
-            wrapperMessage = ObvChannelProtocolMessageToSendWrapper(message: message, messageKey: messageKey, headers: headers, randomizedWith: prng)
+            wrapperMessage = ObvChannelProtocolMessageToSendWrapper(message: message, acceptableChannels: acceptableChannels, randomizedWith: prng, log: log)
         case .ApplicationMessage:
-            wrapperMessage = ObvChannelApplicationMessageToSendWrapper(message: message, messageKey: messageKey, headers: headers, randomizedWith: prng)
+            wrapperMessage = ObvChannelApplicationMessageToSendWrapper(message: message, acceptableChannels: acceptableChannels, randomizedWith: prng, log: log)
         case .DialogMessage,
              .DialogResponseMessage,
              .ServerQuery,
@@ -102,11 +104,7 @@ extension ObvNetworkChannel {
             return [:]
         }
 
-        guard let (messageKey, headers) = generateMessageKeyAndHeaders(using: acceptableChannels, randomizedWith: prng) else {
-            throw Self.makeError(message: "Could not generate message key and headers")
-        }
-        
-        let networkMessages = try generateObvNetworkMessagesToSend(from: message, messageKey: messageKey, headers: headers, randomizedWith: prng)
+        let networkMessages = try generateObvNetworkMessagesToSend(from: message, acceptableChannels: acceptableChannels, randomizedWith: prng, log: log)
         guard !networkMessages.isEmpty else {
             throw Self.makeError(message: "Could not generate obv network message to send")
         }

Engine/ObvChannelManager/ObvChannelManager/ChannelTypes/ObvLocalChannel.swift

@@ -79,7 +79,7 @@ final class ObvLocalChannel: ObvChannel {
 
             let receivedMessage = ObvProtocolReceivedMessage(messageId: messageId,
                                                              timestamp: message.timestamp,
-                                                             receptionChannelInfo: .Local,
+                                                             receptionChannelInfo: .local,
                                                              encodedElements: message.encodedElements)
 
             os_log("Processing a posted protocol message with a (just created) messageId %{public}@", log: log, type: .info, messageId.debugDescription)
@@ -109,7 +109,7 @@ final class ObvLocalChannel: ObvChannel {
 
             let receivedMessage = ObvProtocolReceivedDialogResponse(toOwnedIdentity: ownedIdentity,
                                                                     timestamp: message.timestamp,
-                                                                    receptionChannelInfo: .Local,
+                                                                    receptionChannelInfo: .local,
                                                                     encodedElements: message.encodedElements,
                                                                     encodedUserDialogResponse: message.encodedUserDialogResponse,
                                                                     dialogUuid: message.uuid)
@@ -131,7 +131,7 @@ final class ObvLocalChannel: ObvChannel {
 
             let receivedMessage = ObvProtocolReceivedServerResponse(toOwnedIdentity: ownedIdentity,
                                                                     serverTimestamp: message.serverTimestamp,
-                                                                    receptionChannelInfo: .Local,
+                                                                    receptionChannelInfo: .local,
                                                                     encodedElements: message.encodedElements,
                                                                     serverResponseType: message.responseType)
 
@@ -162,7 +162,7 @@ extension ObvLocalChannel {
         let acceptableChannels: [ObvChannel]
 
         switch message.channelType {
-        case .Local(ownedIdentity: let ownedIdentity):
+        case .local(ownedIdentity: let ownedIdentity):
 
             guard message.messageType == .ProtocolMessage || message.messageType == .DialogResponseMessage || message.messageType == .ServerResponse else {
                 throw ObvLocalChannel.makeError(message: "Wrong message type")

Engine/ObvChannelManager/ObvChannelManager/ChannelTypes/ObvServerChannel.swift

@@ -111,6 +111,8 @@ extension ObvServerChannel {
                 serverQueryType = .transferWait(protocolInstanceUID: protocolInstanceUID, connectionIdentifier: connectionIdentifier)
             case .closeWebsocketConnection(protocolInstanceUID: let protocolInstanceUID):
                 serverQueryType = .closeWebsocketConnection(protocolInstanceUID: protocolInstanceUID)
+            case .uploadPreKeyForCurrentDevice(deviceBlobOnServerToUpload: let deviceBlobOnServerToUpload):
+                serverQueryType = .uploadPreKeyForCurrentDevice(deviceBlobOnServerToUpload: deviceBlobOnServerToUpload)
             }
 
             let serverQuery = ServerQuery(ownedIdentity: ownedIdentity, queryType: serverQueryType, encodedElements: message.encodedElements)
@@ -142,7 +144,7 @@ extension ObvServerChannel {
 
         switch message.channelType {
 
-        case .ServerQuery(ownedIdentity: let ownedIdentity):
+        case .serverQuery(ownedIdentity: let ownedIdentity):
             // Only server query messages may be sent through the server channel
             guard message.messageType == .ServerQuery else {
                 throw ObvServerChannel.makeError(message: "Wrong message type")

Engine/ObvChannelManager/ObvChannelManager/ChannelTypes/ObvUserInterfaceChannel.swift

@@ -94,7 +94,7 @@ extension ObvUserInterfaceChannel {
         let acceptableChannels: [ObvChannel]
 
         switch message.channelType {
-        case .UserInterface(uuid: _, ownedIdentity: let ownedIdentity, dialogType: _):
+        case .userInterface(uuid: _, ownedIdentity: let ownedIdentity, dialogType: _):
 
             // Only dialog messages can be sent to the user interface
             guard message.messageType == .DialogMessage else {