Skip to content

Commit 8edd6e2

Browse files
committed
Code Review
1 parent 8ac88bf commit 8edd6e2

File tree

3 files changed

+5
-10
lines changed

3 files changed

+5
-10
lines changed

src/ClassAttributeCollector.php

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -131,7 +131,8 @@ private function collectMethodAndParameterAttributes(
131131
string $class,
132132
\ReflectionMethod $methodReflection,
133133
array &$methodAttributes,
134-
array &$methodParameterAttributes,
134+
array &$methodParameterAttributes
135+
,
135136
): void {
136137
foreach ($methodReflection->getAttributes() as $attribute) {
137138
if (self::isAttributeIgnored($attribute)) {

tests/Acme81/Attribute/ParameterA.php

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -7,10 +7,8 @@
77
#[Attribute(Attribute::TARGET_PARAMETER)]
88
class ParameterA
99
{
10-
public string $label;
1110
public function __construct(
12-
string $label = ''
11+
public string $label = ''
1312
) {
14-
$this->label = $label;
1513
}
1614
}

tests/Acme81/Attribute/ParameterB.php

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -7,13 +7,9 @@
77
#[Attribute(Attribute::TARGET_PARAMETER)]
88
class ParameterB
99
{
10-
public string $label;
11-
public string $moreData;
1210
public function __construct(
13-
string $label = '',
14-
string $moreData = ''
11+
public string $label = '',
12+
public string $moreData = ''
1513
) {
16-
$this->label = $label;
17-
$this->moreData = $moreData;
1814
}
1915
}

0 commit comments

Comments
 (0)