Skip to content

Github Page's style shouldn't be part of the styleguide itself #36

@arielj

Description

@arielj

We are including all this CSS as a part of the styleguide https://github.com/ombulabs/styleguide/blob/gh-pages/vendor/assets/stylesheets/ombulabs/styleguide/5-pages/_styleguide.scss

This is specific for the github page and it's not needed for projects using the styleguide, we should move this to a static file so it doesn't bloat the CSS.

Also, there's too much custom style https://github.com/ombulabs/styleguide/blob/gh-pages/vendor/assets/stylesheets/ombulabs/styleguide/5-pages/_styleguide.scss#L93. Most of the style should come from the styleguide itself and should need minimal tweaks, if we need to add custom style for the styleguide to look good it means the original style does not look good probably.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions