Replies: 3 comments 1 reply
-
Hi, thanks for letting me know. I'll check out the repository. To be honest, I've mostly used AI (Windsurf) in my development on this repo. Recent development has been done by other developers via pull requests, mostly by @boypt. Therefore, it seems difficult for me to contribute to any potential collaboration directly. The significant differences between the two may make merging difficult, but we can exchange ideas. This way, we can add additional features without making it difficult for first-time users. By the way, your modifications were a significant contribution to the creation and release of this repository, so thank you again. |
Beta Was this translation helpful? Give feedback.
-
@omer-faruq : I skim through zeeyado's repo, the code is more structful, while our repo is contributed by other devlepers, the code tent to "glued together". zeeyado's has more features to the UI (chat history, buildin model selection), and ours to have make the users writting "creative" config file :) . We shared some refactoring ideas, like concentrating prompts and AI API service, using list merge, and simplifing user config file. But generelly, two repos have gone a bit too far to be able to merge now. I thinks fistlly we should make some effects to avoid KOReader's registering conflits when both plugins are installed, and we can introduce zeeyado's version in the README. And to @zeeyado , Thank you for the original ideas on the plugin again. omer-faruq's repo's populariry is beacuse it's introduced in the offcial KOReader's manual (by other contributors) . Given the trend that AI applications are now sprouting, KOReader's should have more AI integration too , try PR to the KOReader's manual repo, I thinks users would certanly like to try out different approach. |
Beta Was this translation helpful? Give feedback.
-
I recently discovered @zeeyado version and found some very useful features that would be nice to have in @omer-faruq version. File Browser Integration (Book Analysis, Multi-Book Comparison, Author Information), Chat History, and Settings UI would all be very useful features to combine with @omer-faruq version. It also has a more independent custom prompt structure (which makes it easier to avoid editing code when updating plugin versions). I'm glad both are interested in combining the projects (I tried using both plugins, but since they have the same name, it gave an error). Also, as a suggestion, I created an X-Ray module based on @omer-faruq Recap with the help of AI, which would be a very interesting additional feature. |
Beta Was this translation helpful? Give feedback.
Uh oh!
There was an error while loading. Please reload this page.
-
Hi, just an FYI that I republished my original fork (that you forked from), but not in the fork network anymore (after going private).
I've made a lot of changes, and see that this fork has as well, and that there are quite a few users.
Perhaps we could look at merging bases or otherwise collaborating.
At any rate, just letting you know that the original fork is back up: https://github.com/zeeyado/assistant.koplugin
@omer-faruq
Beta Was this translation helpful? Give feedback.
All reactions