Task/72 Value namespace reorg (#75)

* Reorganize value classes with a common prefix into namespaces
* Move Valinor mapper to trait
* Removes abstract base class for responses.
* Move agents and waypoint responses to value namespace
* Remaining classes in Resources namespace to Value namespace
* Reorganize System classes

Author: omerida

cli/Command/Fleet/DockShipController.php

@@ -5,8 +5,8 @@
 use InvalidArgumentException;
 use Minicli\Command\CommandController;
 use Phparch\SpaceTraders\Client;
-use Phparch\SpaceTraders\Response\Fleet\DockShip;
 use Phparch\SpaceTraders\ServiceContainer;
+use Phparch\SpaceTraders\Value\Fleet\DockShip;
 use Phparch\SpaceTradersCLI\Command\HelpInfo;
 use Phparch\SpaceTradersCLI\Render;
 

cli/Command/Fleet/ExtractShipController.php

@@ -4,11 +4,11 @@
 
 use InvalidArgumentException;
 use Minicli\Command\CommandController;
+use Phparch\SpaceTraders\APIException;
 use Phparch\SpaceTraders\Client;
-use Phparch\SpaceTraders\Response\Fleet\ExtractResources;
 use Phparch\SpaceTraders\ServiceContainer;
-use Phparch\SpaceTraders\APIException;
 use Phparch\SpaceTraders\Value;
+use Phparch\SpaceTraders\Value\Fleet\ExtractResources;
 use Phparch\SpaceTradersCLI\Command\HelpInfo;
 use Phparch\SpaceTradersCLI\Render;
 
@@ -42,7 +42,7 @@ public function handle(): void
         } catch (APIException $ex) {
             $error = new Render\Exception($ex);
             echo $error->output();
-            $cooldown = Value\ShipCoolDown::fromArray($ex->data['cooldown']);
+            $cooldown = Value\Ship\CoolDown::fromArray($ex->data['cooldown']);
             $render = new Render\Ship\Cooldown($cooldown);
             echo $render->output();
         }

cli/Command/Fleet/NavigateShipController.php

@@ -5,9 +5,9 @@
 use InvalidArgumentException;
 use Minicli\Command\CommandController;
 use Phparch\SpaceTraders\Client;
-use Phparch\SpaceTraders\Response\Fleet\NavigateShip;
 use Phparch\SpaceTraders\ServiceContainer;
-use Phparch\SpaceTraders\Value\WaypointSymbol;
+use Phparch\SpaceTraders\Value\Fleet\NavigateShip;
+use Phparch\SpaceTraders\Value\Waypoint;
 use Phparch\SpaceTradersCLI\Command\HelpInfo;
 use Phparch\SpaceTradersCLI\Render;
 
@@ -31,7 +31,7 @@ public function handle(): void
         if (!$waypoint) {
             throw new InvalidArgumentException("Please specify waypoint as third parameter");
         }
-        $waypoint = new WaypointSymbol($waypoint);
+        $waypoint = new Waypoint\Symbol($waypoint);
 
         $response = $client->navigateShip($shipSymbol, $waypoint);
 

cli/Command/Fleet/OrbitShipController.php

@@ -6,7 +6,7 @@
 use Minicli\Command\CommandController;
 use Phparch\SpaceTraders\Client;
 use Phparch\SpaceTraders\ServiceContainer;
-use Phparch\SpaceTraders\Response\Fleet\OrbitShip;
+use Phparch\SpaceTraders\Value\Fleet\OrbitShip;
 use Phparch\SpaceTradersCLI\Command\HelpInfo;
 use Phparch\SpaceTradersCLI\Render;
 

cli/Command/Fleet/PurchaseShipController.php

@@ -6,7 +6,7 @@
 use Minicli\Command\CommandController;
 use Phparch\SpaceTraders\Client;
 use Phparch\SpaceTraders\ServiceContainer;
-use Phparch\SpaceTraders\Value\WaypointSymbol;
+use Phparch\SpaceTraders\Value\Waypoint;
 use Phparch\SpaceTradersCLI\Command\HelpInfo;
 use Phparch\SpaceTradersCLI\Render;
 
@@ -25,7 +25,7 @@ public function handle(): void
         if (!$waypoint) {
             throw new InvalidArgumentException("Please specify waypoint as third parameter");
         }
-        $waypoint = new WaypointSymbol($waypoint);
+        $waypoint = new Waypoint\Symbol($waypoint);
 
         $type = strtoupper($args[4]);
         if (!$type) {

cli/Command/Fleet/RefuelShipController.php

@@ -5,8 +5,8 @@
 use InvalidArgumentException;
 use Minicli\Command\CommandController;
 use Phparch\SpaceTraders\Client;
-use Phparch\SpaceTraders\Response\Fleet\RefuelShip;
 use Phparch\SpaceTraders\ServiceContainer;
+use Phparch\SpaceTraders\Value\Fleet\RefuelShip;
 use Phparch\SpaceTradersCLI\Command\HelpInfo;
 use Phparch\SpaceTradersCLI\Render;
 

cli/Command/Systems/MarketController.php

@@ -6,7 +6,7 @@
 use Minicli\Command\CommandController;
 use Phparch\SpaceTraders\Client;
 use Phparch\SpaceTraders\ServiceContainer;
-use Phparch\SpaceTraders\Value\WaypointSymbol;
+use Phparch\SpaceTraders\Value\Waypoint;
 use Phparch\SpaceTradersCLI\Command\HelpInfo;
 use Phparch\SpaceTradersCLI\Render;
 
@@ -31,7 +31,7 @@ public function handle(): void
                 throw new InvalidArgumentException("Invalid characters in waypoing ID");
             }
 
-            $wp = new WaypointSymbol($id);
+            $wp = new Waypoint\Symbol($id);
             $market = $client->market($wp->system, $wp->waypoint);
 
             $r = new Render\Market($market);

cli/Command/Systems/ShipyardController.php

@@ -7,7 +7,7 @@
 use Phparch\SpaceTraders\Client;
 use Phparch\SpaceTraders\ServiceContainer;
 use Phparch\SpaceTraders\Trait\TerminalOutputHelper;
-use Phparch\SpaceTraders\Value\WaypointSymbol;
+use Phparch\SpaceTraders\Value\Waypoint;
 use Phparch\SpaceTradersCLI\Command\HelpInfo;
 use Phparch\SpaceTradersCLI\Render;
 
@@ -31,7 +31,7 @@ public function handle(): void
                 throw new InvalidArgumentException("Invalid characters in waypoing ID");
             }
 
-            $wp = new WaypointSymbol($id);
+            $wp = new Waypoint\Symbol($id);
 
             $shipyard = $client->shipyard($wp->system, $wp->waypoint);
 

cli/Command/Systems/WaypointController.php

@@ -7,7 +7,7 @@
 use Phparch\SpaceTraders\Client;
 use Phparch\SpaceTraders\ServiceContainer;
 use Phparch\SpaceTraders\Trait\TerminalOutputHelper;
-use Phparch\SpaceTraders\Value\WaypointSymbol;
+use Phparch\SpaceTraders\Value\Waypoint;
 use Phparch\SpaceTradersCLI\Command\HelpInfo;
 use Phparch\SpaceTradersCLI\Render;
 
@@ -31,7 +31,7 @@ public function handle(): void
                 throw new InvalidArgumentException("Invalid characters in waypoing ID");
             }
 
-            $point = new WaypointSymbol($id);
+            $point = new Waypoint\Symbol($id);
 
             $point = $client->systemLocation($point->system, $point->waypoint);
             $renderer = new Render\Waypoint($point);

cli/Render/Agent.php

@@ -5,7 +5,7 @@
 class Agent extends AbstractRenderer
 {
     public function __construct(
-        public \Phparch\SpaceTraders\Response\Agent $agent,
+        public \Phparch\SpaceTraders\Value\Agent $agent,
     )
     {
     }