refactor: get service operations

Author: omermecitoglu

src/operations/getService.ts

@@ -1,6 +1,7 @@
 import type database from "~/database";
 import type { ServiceDTO } from "~/models/service";
 import { pluck } from "~/utils/object";
+import createRecord from "~/utils/record";
 
 export default async function getService(db: typeof database, serviceId: string) {
   const service = await db.query.services.findFirst({
@@ -26,7 +27,6 @@ export default async function getService(db: typeof database, serviceId: string)
       networks: {
         columns: {
           id: true,
-          kind: true,
         },
       },
       providerlinks: {
@@ -73,9 +73,9 @@ export default async function getService(db: typeof database, serviceId: string)
   const { ports, environmentVariables, volumes, networks, providerlinks, clientLinks, ...others } = service;
   return {
     ...others,
-    environmentVariables: Object.fromEntries(environmentVariables.map(({ key, value }) => [key, value] as const)),
+    environmentVariables: createRecord(environmentVariables, "key", "value"),
     ports: Object.fromEntries(ports.map(({ external, internal }) => [external, internal.toString()] as const)),
-    volumes: Object.fromEntries(volumes.map(({ id, containerPath }) => [id, containerPath] as const)),
+    volumes: createRecord(volumes, "id", "containerPath"),
     networkIds: pluck(networks, "id"),
     providers: pluck(providerlinks, "provider").map(({
       networks: providerNetworks,
@@ -84,7 +84,7 @@ export default async function getService(db: typeof database, serviceId: string)
     }) => ({
       ...otherPropsOfProvider,
       networkIds: pluck(providerNetworks, "id"),
-      variables: Object.fromEntries(providerVariables.map(entry => [entry.key, entry.value] as const)),
+      variables: createRecord(providerVariables, "key", "value"),
     })),
     clients: pluck(clientLinks, "client"),
   } satisfies ServiceDTO;

src/operations/getServiceByRepo.ts

@@ -1,6 +1,7 @@
 import type database from "~/database";
 import type { ServiceDTO } from "~/models/service";
 import { pluck } from "~/utils/object";
+import createRecord from "~/utils/record";
 
 export default async function getServiceByRepo(db: typeof database, repo: string) {
   const service = await db.query.services.findFirst({
@@ -76,18 +77,18 @@ export default async function getServiceByRepo(db: typeof database, repo: string
   const { ports, environmentVariables, volumes, networks, providerlinks, clientLinks, ...others } = service;
   return {
     ...others,
-    environmentVariables: Object.fromEntries(environmentVariables.map(({ key, value }) => [key, value] as const)),
+    environmentVariables: createRecord(environmentVariables, "key", "value"),
     ports: Object.fromEntries(ports.map(({ external, internal }) => [external, internal.toString()] as const)),
-    volumes: Object.fromEntries(volumes.map(({ id, containerPath }) => [id, containerPath] as const)),
-    networkIds: networks.map(network => network.id),
+    volumes: createRecord(volumes, "id", "containerPath"),
+    networkIds: pluck(networks, "id"),
     providers: pluck(providerlinks, "provider").map(({
       networks: providerNetworks,
       environmentVariables: providerVariables,
       ...otherPropsOfProvider
     }) => ({
       ...otherPropsOfProvider,
       networkIds: pluck(providerNetworks, "id"),
-      variables: Object.fromEntries(providerVariables.map(entry => [entry.key, entry.value] as const)),
+      variables: createRecord(providerVariables, "key", "value"),
     })),
     clients: pluck(clientLinks, "client"),
   } satisfies ServiceDTO;

src/utils/record.ts

@@ -0,0 +1,18 @@
+type KeysOfType<T, ValueType> = {
+  [K in keyof T]: T[K] extends ValueType ? K : never
+}[keyof T];
+
+export default function createRecord<
+  Item,
+  K extends KeysOfType<Item, string | number>,
+  V extends keyof Item,
+>(
+  collection: Item[],
+  key: K,
+  value: V,
+) {
+  return collection.reduce((bundle, item) => ({
+    ...bundle,
+    [item[key] as string]: item[value],
+  }), {} as Record<Item[K] & (string | number), Item[V]>);
+}