fix: Transaction function cannot return a promise (temporary fix)

Author: omermecitoglu

src/actions/build-image.ts

@@ -5,11 +5,21 @@ import db from "~/database";
 import deleteBuildImage from "~/operations/deleteBuildImage";
 
 export async function destroy(id: string, _: FormData) {
-  const serviceId = await db.transaction(async tx => {
-    await removeImage(id);
-    const image = await deleteBuildImage(tx, id);
-    if (!image) throw new Error("Invalid Build Image");
-    return image.serviceId;
-  });
+  let serviceId: string = "";
+  try {
+    serviceId = await db.transaction(async tx => {
+      await removeImage(id);
+      const image = await deleteBuildImage(tx, id);
+      if (!image) throw new Error("Invalid Build Image");
+      return image.serviceId;
+    });
+  } catch (error) {
+    if (error && typeof error === "object" && "message" in error && error.message === "Transaction function cannot return a promise") {
+      // do nothing. This is a known bug in Drizzle ORM
+      // Check https://github.com/omermecitoglu/buttler/issues/40
+    } else {
+      throw error;
+    }
+  }
   redirect(`/services/${serviceId}`);
 }

src/actions/service-networks.ts

@@ -7,10 +7,19 @@ import createServiceLink from "~/operations/createServiceLink";
 import deleteNetwork from "~/operations/deleteNetwork";
 
 export async function create(serviceId: string) {
-  await db.transaction(async tx => {
-    const { id: networkId } = await createNetwork(tx, serviceId, "custom");
-    await createDockerNetwork(networkId);
-  });
+  try {
+    await db.transaction(async tx => {
+      const { id: networkId } = await createNetwork(tx, serviceId, "custom");
+      await createDockerNetwork(networkId);
+    });
+  } catch (error) {
+    if (error && typeof error === "object" && "message" in error && error.message === "Transaction function cannot return a promise") {
+      // do nothing. This is a known bug in Drizzle ORM
+      // Check https://github.com/omermecitoglu/buttler/issues/40
+    } else {
+      throw error;
+    }
+  }
   redirect(`/services/${serviceId}/networks`);
 }
 

src/actions/service.ts

@@ -65,11 +65,12 @@ export async function create(formData: FormData) {
       }
     });
   } catch (error) {
-    console.error(error);
-    if (error && typeof error === "object" && "message" in error) {
-      console.log(error.message);
+    if (error && typeof error === "object" && "message" in error && error.message === "Transaction function cannot return a promise") {
+      // do nothing. This is a known bug in Drizzle ORM
+      // Check https://github.com/omermecitoglu/buttler/issues/40
+    } else {
+      throw error;
     }
-    throw error;
   }
   redirect("/services");
 }