Skip to content

Commit 877bebf

Browse files
committed
refactor: buildImage with networkId
1 parent 76d26f6 commit 877bebf

File tree

2 files changed

+10
-2
lines changed

2 files changed

+10
-2
lines changed

src/core/build.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,8 @@ export async function startBuilding(service: ServiceDTO) {
1616
after(async () => {
1717
try {
1818
const repoPath = await cloneRepo(service.repo, service.id);
19-
const success = await buildImage(image.id, repoPath, service.environmentVariables, false);
19+
const networkId = service.providers.at(0)?.networkIds.at(0);
20+
const success = await buildImage(image.id, repoPath, service.environmentVariables, networkId, false);
2021
await deleteRepo(service.id);
2122
if (success) {
2223
await updateBuildImage(db, image.id, { status: "ready" });

src/core/docker.ts

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,14 +9,21 @@ type FixedReadableStream = NodeJS.ReadableStream & { destroy: (reason: unknown)
99

1010
const streams = {} as Record<string, FixedReadableStream>;
1111

12-
export function buildImage(imageId: string, repoPath: string, environmentVariables: Record<string, string>, log: boolean) {
12+
export function buildImage(
13+
imageId: string,
14+
repoPath: string,
15+
environmentVariables: Record<string, string>,
16+
networkId: string | undefined,
17+
log: boolean,
18+
) {
1319
const dockerfilePath = path.join(repoPath, "Dockerfile");
1420
const tarStream = tar.pack(path.dirname(dockerfilePath)) as unknown as NodeJS.ReadableStream;
1521

1622
return new Promise<boolean>((resolve, reject) => {
1723
docker.buildImage(tarStream, {
1824
t: `${imageId}:latest`,
1925
buildargs: environmentVariables,
26+
networkmode: networkId,
2027
}, (err, stream) => {
2128
if (err) return reject(err);
2229
if (!stream) return reject(new Error("no stream"));

0 commit comments

Comments
 (0)