fix: add try-catch blocks to transactions

Author: omermecitoglu

src/actions/build-image.ts

@@ -6,10 +6,15 @@ import deleteBuildImage from "~/operations/deleteBuildImage";
 
 export async function destroy(id: string, _: FormData) {
   const serviceId = await db.transaction(async tx => {
-    await removeImage(id);
-    const image = await deleteBuildImage(tx, id);
-    if (!image) throw new Error("Invalid Build Image");
-    return image.serviceId;
+    try {
+      await removeImage(id);
+      const image = await deleteBuildImage(tx, id);
+      if (!image) throw new Error("Invalid Build Image");
+      return image.serviceId;
+    } catch (error) {
+      console.error(error);
+      throw error;
+    }
   });
   redirect(`/services/${serviceId}`);
 }

src/actions/service-networks.ts

@@ -8,8 +8,13 @@ import deleteNetwork from "~/operations/deleteNetwork";
 
 export async function create(serviceId: string) {
   await db.transaction(async tx => {
-    const { id: networkId } = await createNetwork(tx, serviceId, "custom");
-    await createDockerNetwork(networkId);
+    try {
+      const { id: networkId } = await createNetwork(tx, serviceId, "custom");
+      await createDockerNetwork(networkId);
+    } catch (error) {
+      console.error(error);
+      throw error;
+    }
   });
   redirect(`/services/${serviceId}/networks`);
 }

src/actions/service.ts

@@ -24,43 +24,48 @@ import { mergeObjects } from "~/utils/object";
 export async function create(formData: FormData) {
   const data = NewServiceSchema.parse(getData(formData));
   await db.transaction(async tx => {
-    const service = await createService(tx, data);
-    if (data.kind === "database") {
-      const envEntries: [string, string][] = [];
-      const portEntries: [string, string][] = [];
-      if (data.repo === "postgres") {
-        envEntries.push(["POSTGRES_PASSWORD", crypto.randomUUID()]);
-        // portEntries.push(["5432", "5432"]);
-        const volume = await createVolume(tx, { containerPath: "/var/lib/postgresql/data", serviceId: service.id });
-        await createDockerVolume(volume.id);
-      }
-      if (data.repo === "mysql") {
-        envEntries.push(["MYSQL_ROOT_PASSWORD", "example"]);
-        portEntries.push(["3306", "3306"]);
-        const volume = await createVolume(tx, { containerPath: "/var/lib/mysql", serviceId: service.id });
-        await createDockerVolume(volume.id);
-      }
-      if (data.repo === "mongo") {
-        envEntries.push(["MONGO_INITDB_ROOT_USERNAME", "root"]);
-        envEntries.push(["MONGO_INITDB_ROOT_PASSWORD", "example"]);
-        portEntries.push(["27017", "27017"]);
-        const volume = await createVolume(tx, { containerPath: "/data/db", serviceId: service.id });
-        await createDockerVolume(volume.id);
-      }
-      if (data.repo === "redis") {
-        envEntries.push(["REDIS_ARGS", "--appendonly yes"]);
-        // portEntries.push(["6379", "6379"]);
-        const volume = await createVolume(tx, { containerPath: "/data", serviceId: service.id });
-        await createDockerVolume(volume.id);
-      }
-      if (envEntries.length) {
-        await syncEnvironmentVariables(tx, service.id, Object.fromEntries(envEntries));
-      }
-      if (portEntries.length) {
-        await syncPorts(tx, service.id, Object.fromEntries(portEntries));
+    try {
+      const service = await createService(tx, data);
+      if (data.kind === "database") {
+        const envEntries: [string, string][] = [];
+        const portEntries: [string, string][] = [];
+        if (data.repo === "postgres") {
+          envEntries.push(["POSTGRES_PASSWORD", crypto.randomUUID()]);
+          // portEntries.push(["5432", "5432"]);
+          const volume = await createVolume(tx, { containerPath: "/var/lib/postgresql/data", serviceId: service.id });
+          await createDockerVolume(volume.id);
+        }
+        if (data.repo === "mysql") {
+          envEntries.push(["MYSQL_ROOT_PASSWORD", "example"]);
+          portEntries.push(["3306", "3306"]);
+          const volume = await createVolume(tx, { containerPath: "/var/lib/mysql", serviceId: service.id });
+          await createDockerVolume(volume.id);
+        }
+        if (data.repo === "mongo") {
+          envEntries.push(["MONGO_INITDB_ROOT_USERNAME", "root"]);
+          envEntries.push(["MONGO_INITDB_ROOT_PASSWORD", "example"]);
+          portEntries.push(["27017", "27017"]);
+          const volume = await createVolume(tx, { containerPath: "/data/db", serviceId: service.id });
+          await createDockerVolume(volume.id);
+        }
+        if (data.repo === "redis") {
+          envEntries.push(["REDIS_ARGS", "--appendonly yes"]);
+          // portEntries.push(["6379", "6379"]);
+          const volume = await createVolume(tx, { containerPath: "/data", serviceId: service.id });
+          await createDockerVolume(volume.id);
+        }
+        if (envEntries.length) {
+          await syncEnvironmentVariables(tx, service.id, Object.fromEntries(envEntries));
+        }
+        if (portEntries.length) {
+          await syncPorts(tx, service.id, Object.fromEntries(portEntries));
+        }
+        const network = await createNetwork(tx, service.id, "provider");
+        await createDockerNetwork(network.id);
       }
-      const network = await createNetwork(tx, service.id, "provider");
-      await createDockerNetwork(network.id);
+    } catch (error) {
+      console.error(error);
+      throw error;
     }
   });
   redirect("/services");
@@ -81,9 +86,14 @@ export async function update(id: string, _: unknown, formData: FormData): Promis
     patch.status = "idle";
   }
   await db.transaction(async tx => {
-    await updateService(tx, id, patch);
-    await syncEnvironmentVariables(tx, id, env);
-    await syncPorts(tx, id, ports);
+    try {
+      await updateService(tx, id, patch);
+      await syncEnvironmentVariables(tx, id, env);
+      await syncPorts(tx, id, ports);
+    } catch (error) {
+      console.error(error);
+      throw error;
+    }
   });
   redirect("/services");
 }