Refactor MongoDBAdapter for clarity

Author: curry684

src/Adapter/MongoDB/MongoDBAdapter.php

@@ -18,6 +18,8 @@
 use Omines\DataTablesBundle\Adapter\AbstractAdapter;
 use Omines\DataTablesBundle\Adapter\AdapterQuery;
 use Omines\DataTablesBundle\Column\AbstractColumn;
+use Omines\DataTablesBundle\DataTable;
+use Omines\DataTablesBundle\DataTableState;
 use Symfony\Component\OptionsResolver\OptionsResolver;
 
 /**
@@ -28,12 +30,13 @@
 class MongoDBAdapter extends AbstractAdapter
 {
     const SORT_MAP = [
-        'asc' => 1,
-        'desc' => -1,
+        DataTable::SORT_ASCENDING => 1,
+        DataTable::SORT_DESCENDING => -1,
     ];
 
     /** @var Collection */
     private $collection;
+
     /** @var array */
     private $filters;
 
@@ -79,13 +82,32 @@ protected function getResults(AdapterQuery $query): \Traversable
     {
         $state = $query->getState();
 
-        $filter = $this->filters;
-        $options = [
-            'limit' => $state->getLength(),
-            'skip' => $state->getStart(),
-            'sort' => [],
-        ];
+        $filter = $this->buildFilter($state);
+        $options = $this->buildOptions($state);
+
+        $query->setFilteredRows($this->collection->count($filter));
+        $cursor = $this->collection->find($filter, $options);
+        $cursor->setTypeMap(['root' => 'array', 'document' => 'array']);
+
+        /** @var BSONDocument $result */
+        foreach ($cursor as $result) {
+            array_walk_recursive($result, function (&$value) {
+                if ($value instanceof UTCDateTime) {
+                    $value = $value->toDateTime();
+                }
+            });
 
+            yield $result;
+        }
+    }
+
+    /**
+     * @param DataTableState $state
+     * @return array
+     */
+    private function buildFilter(DataTableState $state): array
+    {
+        $filter = $this->filters;
         if (!empty($globalSearch = $state->getGlobalSearch())) {
             foreach ($state->getDataTable()->getColumns() as $column) {
                 if ($column->isGlobalSearchable()) {
@@ -95,27 +117,29 @@ protected function getResults(AdapterQuery $query): \Traversable
             $filter = ['$or' => $filter];
         }
 
+        return $filter;
+    }
+
+    /**
+     * @param DataTableState $state
+     * @return array
+     */
+    private function buildOptions(DataTableState $state): array
+    {
+        $options = [
+            'limit' => $state->getLength(),
+            'skip' => $state->getStart(),
+            'sort' => [],
+        ];
+
         foreach ($state->getOrderBy() as list($column, $direction)) {
             /** @var AbstractColumn $column */
             if ($column->isOrderable() && $orderField = $column->getOrderField()) {
                 $options['sort'][$orderField] = self::SORT_MAP[$direction];
             }
         }
 
-        $query->setFilteredRows($this->collection->count($filter));
-        $cursor = $this->collection->find($filter, $options);
-        $cursor->setTypeMap(['root' => 'array', 'document' => 'array']);
-
-        /** @var BSONDocument $result */
-        foreach ($cursor as $result) {
-            array_walk_recursive($result, function (&$value) {
-                if ($value instanceof UTCDateTime) {
-                    $value = $value->toDateTime();
-                }
-            });
-
-            yield $result;
-        }
+        return $options;
     }
 
     /**