Syntactic sugar

Author: curry684

src/DataTable.php

@@ -265,21 +265,16 @@ public function getTranslationDomain(): string
 
     public function isCallback(): bool
     {
-        return (null === $this->state) ? false : $this->state->isCallback();
+        return null !== $this->state && $this->state->isCallback();
     }
 
     public function handleRequest(Request $request): static
     {
-        switch ($this->getMethod()) {
-            case Request::METHOD_GET:
-                $parameters = $request->query;
-                break;
-            case Request::METHOD_POST:
-                $parameters = $request->request;
-                break;
-            default:
-                throw new InvalidConfigurationException(sprintf("Unknown request method '%s'", $this->getMethod()));
-        }
+        $parameters = match ($this->getMethod()) {
+            Request::METHOD_GET => $request->query,
+            Request::METHOD_POST => $request->request,
+            default => throw new InvalidConfigurationException(sprintf("Unknown request method '%s'", $this->getMethod())),
+        };
         if ($this->getName() === $parameters->get('_dt')) {
             if (null === $this->state) {
                 $this->state = DataTableState::fromDefaults($this);

tests/Unit/DataTableTest.php

@@ -104,9 +104,6 @@ public function testDataTableState(): void
         $this->assertSame(10, $state->getLength());
         $this->assertSame('foo', $state->getGlobalSearch());
         $this->assertCount(2, $state->getOrderBy());
-        foreach ($state->getOrderBy() as $order) {
-            $this->assertContains($order[1], [DataTable::SORT_ASCENDING, DataTable::SORT_DESCENDING]);
-        }
         $this->assertSame('bar', $state->getSearchColumns(onlySearchable: false)['foo']['search']);
 
         // Test boundaries
@@ -142,9 +139,6 @@ public function testDataTableStateSearchColumns(): void
         $this->assertSame('foo', $searchColumns['foo']['search']);
     }
 
-    /**
-     * If ordering is false, ensure columns are not ordered.
-     */
     public function testSortDirectionValidation(): void
     {
         $this->expectException(\InvalidArgumentException::class);