Remove deprecated notice (#230)

Author: maxhelias

.travis.yml

@@ -47,7 +47,7 @@ matrix:
          - DEPENDENCIES=dev
          - COMPOSER_FLAGS="--ignore-platform-reqs"
     allow_failures:
-     - env: DEPENDENCIES=dev
+     - php: 8.0snapshot
 
 before_install:
   - if [ "$DEPENDENCIES" != "" ]; then composer config minimum-stability ${DEPENDENCIES}; fi;

composer.json

@@ -23,8 +23,8 @@
         "php": ">=7.2",
         "symfony/event-dispatcher": "^4.4|^5.0",
         "symfony/framework-bundle": "^4.4|^5.0",
-        "symfony/property-access": "^4.4|^5.0",
         "symfony/options-resolver": "^4.4|^5.0",
+        "symfony/property-access": "^4.4|^5.0",
         "symfony/translation": "^4.4|^5.0"
     },
     "require-dev": {
@@ -33,7 +33,7 @@
         "ext-pdo_sqlite": "*",
         "ext-zip": "*",
         "doctrine/common": "^2.6|^3.0",
-        "doctrine/doctrine-bundle": "^2.1|^3.0",
+        "doctrine/doctrine-bundle": "^2.3|^3.0",
         "doctrine/orm": "^2.6.3",
         "doctrine/persistence": "^1.3.4|^2.0",
         "friendsofphp/php-cs-fixer": "^2.7",

src/DataTable.php

@@ -309,7 +309,7 @@ public function getResponse(): Response
             $response['template'] = $this->renderer->renderDataTable($this, $this->template, $this->templateParams);
         }
 
-        return JsonResponse::create($response);
+        return new JsonResponse($response);
     }
 
     protected function getInitialResponse(): array

src/DataTableState.php

@@ -91,7 +91,7 @@ public function applyParameters(ParameterBag $parameters)
         $this->start = (int) $parameters->get('start', $this->start);
         $this->length = (int) $parameters->get('length', $this->length);
 
-        $search = $parameters->get('search', []);
+        $search = $parameters->all()['search'] ?? [];
         $this->setGlobalSearch($search['value'] ?? $this->globalSearch);
 
         $this->handleOrderBy($parameters);
@@ -102,7 +102,7 @@ private function handleOrderBy(ParameterBag $parameters)
     {
         if ($parameters->has('order')) {
             $this->orderBy = [];
-            foreach ($parameters->get('order', []) as $order) {
+            foreach ($parameters->all()['order'] ?? [] as $order) {
                 $column = $this->getDataTable()->getColumn((int) $order['column']);
                 $this->addOrderBy($column, $order['dir'] ?? DataTable::SORT_ASCENDING);
             }
@@ -111,7 +111,7 @@ private function handleOrderBy(ParameterBag $parameters)
 
     private function handleSearch(ParameterBag $parameters)
     {
-        foreach ($parameters->get('columns', []) as $key => $search) {
+        foreach ($parameters->all()['columns'] ?? [] as $key => $search) {
             $column = $this->dataTable->getColumn((int) $key);
             $value = $this->isInitial ? $search : $search['search']['value'];
 

tests/Fixtures/config.yml

@@ -2,8 +2,11 @@ imports:
     - { resource: services.yml }
 
 framework:
+    annotations:
+        enabled: true
     secret: '1234567890'
     router:
+        utf8: true
         resource: '%kernel.project_dir%/routing.yml'
         strict_requirements: ~
     default_locale: 'en'
@@ -29,15 +32,12 @@ doctrine:
         auto_generate_proxy_classes: '%kernel.debug%'
         naming_strategy: doctrine.orm.naming_strategy.underscore_number_aware
         auto_mapping: true
-        metadata_cache_driver:
-            type: service
-            id: doctrine.system_cache_provider
         query_cache_driver:
-            type: service
-            id: doctrine.system_cache_provider
+            type: pool
+            pool: doctrine.system_cache_pool
         result_cache_driver:
-            type: service
-            id: doctrine.result_cache_provider
+            type: pool
+            pool: doctrine.result_cache_pool
 
 twig:
     debug: '%kernel.debug%'

tests/Fixtures/services.yml

@@ -11,16 +11,6 @@ services:
         resource: 'AppBundle/Controller'
         tags: ['controller.service_arguments']
 
-    doctrine.result_cache_provider:
-        class: Symfony\Component\Cache\DoctrineProvider
-        arguments:
-            - '@doctrine.result_cache_pool'
-
-    doctrine.system_cache_provider:
-        class: Symfony\Component\Cache\DoctrineProvider
-        arguments:
-            - '@doctrine.system_cache_pool'
-
     twig.extension.string_loader:
         class: Twig\Extension\StringLoaderExtension
         tags: