fixes

Author: Chetan11-dev

docs/docs/botasaurus-desktop/botasaurus-desktop-api/adding-domain-and-ssl.md

@@ -43,17 +43,18 @@ The process involves two main steps:
 
    I recommend these registrars:
 
-   - **Cloudflare Domains** - Cheapest option (offers at-cost pricing, charging only the  ICANN registry fees with no markup)
+   - **Cloudflare Domains** - Cheapest option (offers at-cost pricing, charging only the ICANN registry fees with no markup)
    - **Porkbun** - Second cheapest option
-   - **Namecheap**
 
-   Avoid GoDaddy. While their initial registration costs are low, renewal prices are significantly higher than Porkbun and Namecheap, costing more in the long run.
+   Avoid GoDaddy and Namecheap. 
+    - Although their initial registration costs are low, their renewal prices are significantly higher than Porkbun and Cloudflare Domains. Therefore, it is unwise to buy from them.
+    - Also, do not even search for a domain on GoDaddy. They may purchase the domain themselves and then offer it to you at a much higher price.
 
-   I personally use Porkbun because it offers auto-renewals and sends multiple renewal reminders (45 days and 30 days before expiry), so I don't forget to renew my domains.
+   I personally use Porkbun because it offers automatic renewals 45 days before expiry and sends multiple renewal reminders (45 days and 30 days before expiry), so I don't forget to renew my domains.
 
    ![Porkbun Renewal Emails](https://raw.githubusercontent.com/omkarcloud/botasaurus/master/images/domains/porkbun-renewal-emails.png)
 
-   Also, Porkbun's logo and branding are funny, nevertheless they provide a good experience and are [highly ratings on Trustpilot.](https://www.trustpilot.com/review/porkbun.com)
+   Also, Porkbun's logo and branding are funny, nevertheless they provide a good experience and are [highly rated on Trustpilot.](https://www.trustpilot.com/review/porkbun.com)
 
 2. Next, log in to your domain registrar and create DNS **A records** pointing to your VM's IP address.
 

js/botasaurus-server-js/src/ndjson.ts

@@ -41,6 +41,9 @@ export class NDJSONWriteStream {
   }
 
   end(): Promise<void> {
+    if (!this.writeStream){
+      return Promise.resolve()
+    }
     return new Promise(async (resolve) => {
       await this.preEnd()
       this.writeStream.end(() => {

js/botasaurus-server-js/src/routes-db-logic.ts

@@ -1003,8 +1003,8 @@ function convertUnicodeDictToAsciiDictInPlace(inputList: any[]): any[] {
             if (abortedChildrenCount === allChildrenCount) {
               await TaskHelper.abortTask(parentId);
             } else {
-              const failedChildrenCount = await TaskHelper.getFailedChildrenCount(parentId, taskId);
-              if (failedChildrenCount) {
+              const hasFailedChildrenCount = await TaskHelper.hasFailedChildren(parentId, taskId);
+              if (hasFailedChildrenCount) {
                 fn = async () => {
                   await TaskHelper.collectAndSaveAllTask(
                     parentId,
@@ -1046,14 +1046,14 @@ function convertUnicodeDictToAsciiDictInPlace(inputList: any[]): any[] {
     // Only abort tasks that are in PENDING or IN_PROGRESS status
     const abortableStatuses: string[] = [TaskStatus.PENDING, TaskStatus.IN_PROGRESS];
     if (!abortableStatuses.includes(status)) {
-      return;
+      // return;
     }
 
     let fn: (() => Promise<void>) | null = null;
 
     if (is_all_task) {
       await TaskHelper.abortChildTasks(taskId);
-      await TaskHelper.collectAndSaveAllTaskForAbortedTask(taskId, removeDuplicatesBy);
+      await TaskHelper.collectAndSaveAllTask(taskId, null, removeDuplicatesBy, TaskStatus.ABORTED, false);
     } else {
       if (parentId) {
         const allChildrenCount = await TaskHelper.getAllChildrenCount(parentId, taskId);
@@ -1075,8 +1075,8 @@ function convertUnicodeDictToAsciiDictInPlace(inputList: any[]): any[] {
             if (abortedChildrenCount === allChildrenCount) {
               await TaskHelper.abortTask(parentId);
             } else {
-              const failedChildrenCount = await TaskHelper.getFailedChildrenCount(parentId, taskId);
-              if (failedChildrenCount) {
+              const hasFailedChildrenCount = await TaskHelper.hasFailedChildren(parentId, taskId);
+              if (hasFailedChildrenCount) {
                 fn = async () => {
                   await TaskHelper.collectAndSaveAllTask(
                     parentId,

js/botasaurus-server-js/src/server.ts

@@ -1,6 +1,6 @@
 import { BaseSort, Sort } from './sorts';
 import { ScraperType } from './scraper-type';
-import { isObject } from './utils';
+import { isNoentError, isObject } from './utils';
 import { _hash } from 'botasaurus/cache';
 import * as fs from 'fs';
 import { isNotNullish } from './null-utils'
@@ -24,8 +24,7 @@ function getReadme(): string {
     const text = fs.readFileSync(readmeFile, 'utf-8');
     return text;
   } catch (error) {
-    // @ts-ignore
-    if (error.code === 'ENOENT') {
+    if (isNoentError(error)) {
       return '';
     }
     throw error;

js/botasaurus-server-js/src/task-executor.ts

@@ -154,8 +154,8 @@ class TaskExecutor {
                 if (isAllChildTasksDone) {
                   const is_large: any = parentTask.is_large
 
-                  const failedChildrenCount = await TaskHelper.getFailedChildrenCount(parentId)
-                  const status = failedChildrenCount ? TaskStatus.FAILED : TaskStatus.COMPLETED
+                  const hasFailedChildrenCount = await TaskHelper.hasFailedChildren(parentId)
+                  const status = hasFailedChildrenCount ? TaskStatus.FAILED : TaskStatus.COMPLETED
 
                   const removeDuplicatesBy = Server.getRemoveDuplicatesBy(parentTask.scraper_name)
                   // Find the oldest started_at task that is the parent of the current task
@@ -644,13 +644,12 @@ class TaskExecutor {
     ) {
         const parentTask = await TaskHelper.getTask(
             parentId,
-            [TaskStatus.PENDING, TaskStatus.IN_PROGRESS],
         )
 
         if (parentTask) {
             const is_large: any = parentTask.is_large
             await TaskHelper.updateParentTaskResults(parentId, result, is_large)
-            await this.finalizeParentIfAllChildrenDone(parentId, removeDuplicatesBy, is_large)
+            await this.finalizeParentIfAllChildrenDone(parentId, parentTask, removeDuplicatesBy, is_large)
         }
     }
 
@@ -664,13 +663,12 @@ class TaskExecutor {
     ) {
         const parentTask = await TaskHelper.getTask(
             parentId,
-            [TaskStatus.PENDING, TaskStatus.IN_PROGRESS],
         )
 
         if (parentTask) {
             const is_large: any = parentTask.is_large
             await TaskHelper.streamChildToParentResults(childId, parentId, is_large)
-            await this.finalizeParentIfAllChildrenDone(parentId, removeDuplicatesBy, is_large)
+            await this.finalizeParentIfAllChildrenDone(parentId, parentTask, removeDuplicatesBy, is_large)
         }
     }
 
@@ -679,13 +677,13 @@ class TaskExecutor {
      */
     private async finalizeParentIfAllChildrenDone(
         parentId: number,
+        parentTask: Task,
         removeDuplicatesBy: string | null,
         is_large: boolean
     ) {
         const isAllChildTasksDone = await TaskHelper.areAllChildTaskDone(parentId)
         if (isAllChildTasksDone) {
-            const failedChildrenCount = await TaskHelper.getFailedChildrenCount(parentId)
-            const status = failedChildrenCount ? TaskStatus.FAILED : TaskStatus.COMPLETED
+            const status = await this.getParentFinalizingStatus(parentId, parentTask)
             await TaskHelper.readCleanSaveTask(
                 parentId,
                 removeDuplicatesBy,
@@ -695,16 +693,24 @@ class TaskExecutor {
         }
     }
 
+    private async getParentFinalizingStatus(parentId: number, parentTask: Task) {
+        if (parentTask.status === TaskStatus.ABORTED) {
+            return TaskStatus.ABORTED
+        }
+        const hasFailedChildrenCount = await TaskHelper.hasFailedChildren(parentId)
+        return hasFailedChildrenCount ? TaskStatus.FAILED : TaskStatus.COMPLETED
+    }
+
     async completeAsMuchAllTaskAsPossible(
         parentId: number,
         removeDuplicatesBy: string | null
     ): Promise<void> {
         const isAllChildTasksDone = await TaskHelper.areAllChildTaskDone(parentId)
         if (isAllChildTasksDone) {
-            const failedChildrenCount = await TaskHelper.getFailedChildrenCount(
+            const hasFailedChildrenCount = await TaskHelper.hasFailedChildren(
                 parentId
             )
-            const status = failedChildrenCount
+            const status = hasFailedChildrenCount
                 ? TaskStatus.FAILED
                 : TaskStatus.COMPLETED
             await TaskHelper.collectAndSaveAllTask(