on_validation is the decider of which persistence logic to use

Author: pboling

lib/omniauth/strategies/identity.rb

@@ -76,17 +76,19 @@ def registration_phase
         if model.respond_to?(:column_names) && model.column_names.include?('provider')
           attributes.reverse_merge!(provider: 'identity')
         end
-        @identity = model.new(attributes)
-        if saving_instead_of_creating?
+        if validating?
+          @identity = model.new(attributes)
           env['omniauth.identity'] = @identity
-          if !validating? || valid?
+          if valid?
             @identity.save
             registration_result
           else
             registration_failure(options[:validation_failure_message])
           end
         else
-          deprecated_registration(attributes)
+          @identity = model.create(attributes)
+          env['omniauth.identity'] = @identity
+          registration_result
         end
       end
 
@@ -141,10 +143,6 @@ def build_omniauth_registration_form(validation_message)
         end
       end
 
-      def saving_instead_of_creating?
-        @identity.respond_to?(:save) && @identity.respond_to?(:persisted?)
-      end
-
       # Validates the model before it is persisted
       #
       # @return [truthy or falsey] :on_validation option is truthy or falsey
@@ -177,17 +175,6 @@ def registration_result
           registration_failure(options[:registration_failure_message])
         end
       end
-
-      def deprecated_registration(attributes)
-        warn <<~CREATEDEP
-          [DEPRECATION] Please define '#{model.class}#save'.
-                        Behavior based on '#{model.class}.create' will be removed in omniauth-identity v4.0.
-                        See lib/omniauth/identity/model.rb
-        CREATEDEP
-        @identity = model.create(attributes)
-        env['omniauth.identity'] = @identity
-        registration_result
-      end
     end
   end
 end