Skip to content

Commit 3ea1562

Browse files
committed
πŸ‘· Add more appraisals
- test against all minor versions of rack
1 parent 677ba9f commit 3ea1562

18 files changed

+46
-39
lines changed

β€Ž.github/workflows/ancient.ymlβ€Ž

Lines changed: 7 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -35,20 +35,6 @@ jobs:
3535
matrix:
3636
include:
3737
# Ruby 2.3
38-
- ruby: "ruby-2.3"
39-
appraisal: "ruby-2-3-omni-v1.0"
40-
exec_cmd: "rake test"
41-
gemfile: "Appraisal.root"
42-
rubygems: "3.3.27"
43-
bundler: "2.3.27"
44-
45-
- ruby: "ruby-2.3"
46-
appraisal: "ruby-2-3-omni-v1.1"
47-
exec_cmd: "rake test"
48-
gemfile: "Appraisal.root"
49-
rubygems: "3.3.27"
50-
bundler: "2.3.27"
51-
5238
- ruby: "ruby-2.3"
5339
appraisal: "ruby-2-3-omni-v1.2"
5440
exec_cmd: "rake test"
@@ -91,6 +77,13 @@ jobs:
9177
rubygems: "3.3.27"
9278
bundler: "2.3.27"
9379

80+
- ruby: "ruby-2.3"
81+
appraisal: "ruby-2-3-omni-v1.8"
82+
exec_cmd: "rake test"
83+
gemfile: "Appraisal.root"
84+
rubygems: "3.3.27"
85+
bundler: "2.3.27"
86+
9487
# Ruby 2.4
9588
- ruby: "ruby-2.4"
9689
appraisal: "ruby-2-4"

β€ŽAppraisalsβ€Ž

Lines changed: 11 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -56,50 +56,44 @@ appraise "dep-heads" do
5656
eval_gemfile "modular/runtime_heads.gemfile"
5757
end
5858

59-
appraise "ruby-2-3-omni-v1.0" do
60-
eval_gemfile "modular/omniauth/r2/v1.0.gemfile"
61-
eval_gemfile "modular/rack/r2.1/v1.6.gemfile"
62-
eval_gemfile "modular/x_std_libs/r2.3/libs.gemfile"
63-
end
64-
65-
appraise "ruby-2-3-omni-v1.1" do
66-
eval_gemfile "modular/omniauth/r2/v1.1.gemfile"
67-
eval_gemfile "modular/rack/r2.1/v1.6.gemfile"
68-
eval_gemfile "modular/x_std_libs/r2.3/libs.gemfile"
69-
end
70-
7159
appraise "ruby-2-3-omni-v1.2" do
7260
eval_gemfile "modular/omniauth/r2/v1.2.gemfile"
73-
eval_gemfile "modular/rack/r2.1/v1.6.gemfile"
61+
eval_gemfile "modular/rack/r2.1/v1.0.gemfile"
7462
eval_gemfile "modular/x_std_libs/r2.3/libs.gemfile"
7563
end
7664

7765
appraise "ruby-2-3-omni-v1.3" do
7866
eval_gemfile "modular/omniauth/r2/v1.3.gemfile"
79-
eval_gemfile "modular/rack/r2.1/v1.6.gemfile"
67+
eval_gemfile "modular/rack/r2.1/v1.1.gemfile"
8068
eval_gemfile "modular/x_std_libs/r2.3/libs.gemfile"
8169
end
8270

8371
appraise "ruby-2-3-omni-v1.4" do
8472
eval_gemfile "modular/omniauth/r2/v1.4.gemfile"
85-
eval_gemfile "modular/rack/r2.1/v1.6.gemfile"
73+
eval_gemfile "modular/rack/r2.1/v1.2.gemfile"
8674
eval_gemfile "modular/x_std_libs/r2.3/libs.gemfile"
8775
end
8876

8977
appraise "ruby-2-3-omni-v1.5" do
9078
eval_gemfile "modular/omniauth/r2/v1.5.gemfile"
91-
eval_gemfile "modular/rack/r2.1/v1.6.gemfile"
79+
eval_gemfile "modular/rack/r2.1/v1.3.gemfile"
9280
eval_gemfile "modular/x_std_libs/r2.3/libs.gemfile"
9381
end
9482

9583
appraise "ruby-2-3-omni-v1.6" do
9684
eval_gemfile "modular/omniauth/r2/v1.6.gemfile"
97-
eval_gemfile "modular/rack/r2.1/v1.6.gemfile"
85+
eval_gemfile "modular/rack/r2.1/v1.4.gemfile"
9886
eval_gemfile "modular/x_std_libs/r2.3/libs.gemfile"
9987
end
10088

10189
appraise "ruby-2-3-omni-v1.7" do
10290
eval_gemfile "modular/omniauth/r2/v1.7.gemfile"
91+
eval_gemfile "modular/rack/r2.1/v1.5.gemfile"
92+
eval_gemfile "modular/x_std_libs/r2.3/libs.gemfile"
93+
end
94+
95+
appraise "ruby-2-3-omni-v1.8" do
96+
eval_gemfile "modular/omniauth/r2/v1.8.gemfile"
10397
eval_gemfile "modular/rack/r2.1/v1.6.gemfile"
10498
eval_gemfile "modular/x_std_libs/r2.3/libs.gemfile"
10599
end

β€ŽCHANGELOG.mdβ€Ž

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -28,6 +28,9 @@ Please file a bug if you notice a violation of semantic versioning.
2828

2929
### Changed
3030

31+
- Make support for OmniAuth v1.2+ explicit
32+
- Versions < 1.2 do not support SCRIPT_NAME properly, and may cause other issues
33+
3134
### Deprecated
3235

3336
### Removed

β€ŽGemfile.lockβ€Ž

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ PATH
1515
specs:
1616
omniauth-ldap (2.3.1)
1717
net-ldap (~> 0.16, < 1)
18-
omniauth (>= 1, < 3)
18+
omniauth (>= 1.2, < 3)
1919
pyu-ruby-sasl (>= 0.0.3.3, < 0.1)
2020
rack (>= 1, < 4)
2121
rubyntlm (~> 0.6.2, < 1)
Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
gem "rack", "~> 1.0", ">= 1.0.1"
Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
gem "rack", "~> 1.1", ">= 1.1.6"
Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
gem "rack", "~> 1.2", ">= 1.2.8"
Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
gem "rack", "~> 1.3", ">= 1.3.10"
Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
gem "rack", "~> 1.4", ">= 1.4.7"
Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
gem "rack", "~> 1.5", ">= 1.5.5"

0 commit comments

Comments
Β (0)