Skip to content

Commit 61a6a8a

Browse files
committed
🐛 request.params: compatible with all supported versions of rack
1 parent 8fbfd7d commit 61a6a8a

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

lib/omniauth/strategies/ldap.rb

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,7 @@ def callback_phase
4040

4141
return fail!(:missing_credentials) if missing_credentials?
4242
begin
43-
@ldap_user_info = @adaptor.bind_as(:filter => filter(@adaptor), :size => 1, :password => request["password"])
43+
@ldap_user_info = @adaptor.bind_as(:filter => filter(@adaptor), :size => 1, :password => request.params["password"])
4444
return fail!(:invalid_credentials) if !@ldap_user_info
4545

4646
@user_info = self.class.map_user(@@config, @ldap_user_info)
@@ -52,9 +52,9 @@ def callback_phase
5252

5353
def filter adaptor
5454
if adaptor.filter and !adaptor.filter.empty?
55-
Net::LDAP::Filter.construct(adaptor.filter % {:username => @options[:name_proc].call(request["username"])})
55+
Net::LDAP::Filter.construct(adaptor.filter % {:username => @options[:name_proc].call(request.params["username"])})
5656
else
57-
Net::LDAP::Filter.eq(adaptor.uid, @options[:name_proc].call(request["username"]))
57+
Net::LDAP::Filter.eq(adaptor.uid, @options[:name_proc].call(request.params["username"]))
5858
end
5959
end
6060

@@ -102,7 +102,7 @@ def self.map_user(mapper, object)
102102
protected
103103

104104
def missing_credentials?
105-
request["username"].nil? or request["username"].empty? or request["password"].nil? or request["password"].empty?
105+
request.params["username"].nil? or request.params["username"].empty? or request.params["password"].nil? or request.params["password"].empty?
106106
end # missing_credentials?
107107
end
108108
end

0 commit comments

Comments
 (0)