Fix more compiler warnings

Author: jmarin

parser/shared/src/test/scala/hmda/parser/fi/lar/LarDatParserSpec.scala

@@ -98,8 +98,4 @@ class LarDatParserSpec extends PropSpec with MustMatchers with PropertyChecks wi
     applicant.income mustBe "9000"
   }
 
-  private def padLeftWithZero(s: String, n: Int): String = {
-    String.format("%1$" + n + "s", s).replace(' ', '0')
-  }
-
 }

persistence-model/src/main/scala/hmda/persistence/processing/HmdaQuery.scala

@@ -4,7 +4,6 @@ import akka.NotUsed
 import akka.actor.ActorSystem
 import akka.persistence.query.PersistenceQuery
 import akka.persistence.query.scaladsl._
-import akka.stream.ActorMaterializer
 import akka.stream.scaladsl.Source
 import hmda.persistence.PersistenceConfig._
 import hmda.persistence.messages.CommonMessages._
@@ -21,17 +20,17 @@ object HmdaQuery {
     PersistenceQuery(system).readJournalFor[RJ](journalId)
   }
 
-  def events(persistenceId: String)(implicit system: ActorSystem, materializer: ActorMaterializer): Source[Event, NotUsed] = {
+  def events(persistenceId: String)(implicit system: ActorSystem): Source[Event, NotUsed] = {
     readJournal(system).currentEventsByPersistenceId(persistenceId, 0L, Long.MaxValue)
       .map(_.event.asInstanceOf[Event])
   }
 
-  def liveEvents(persistenceId: String)(implicit system: ActorSystem, materializer: ActorMaterializer): Source[Event, NotUsed] = {
+  def liveEvents(persistenceId: String)(implicit system: ActorSystem): Source[Event, NotUsed] = {
     readJournal(system).eventsByPersistenceId(persistenceId, 0L, Long.MaxValue)
       .map(_.event.asInstanceOf[Event])
   }
 
-  def eventsWithSequenceNumber(persistenceId: String, fromSequenceNr: Long, toSequenceNr: Long)(implicit system: ActorSystem, materializer: ActorMaterializer): Source[EventWithSeqNr, NotUsed] = {
+  def eventsWithSequenceNumber(persistenceId: String, fromSequenceNr: Long, toSequenceNr: Long)(implicit system: ActorSystem): Source[EventWithSeqNr, NotUsed] = {
     readJournal(system)
       .eventsByPersistenceId(persistenceId, fromSequenceNr, toSequenceNr)
       .map(x => EventWithSeqNr(x.sequenceNr, x.event.asInstanceOf[Event]))

persistence/src/main/scala/hmda/persistence/HmdaSupervisor.scala

@@ -1,6 +1,6 @@
 package hmda.persistence
 
-import akka.actor.{ ActorRef, ActorSystem, Props, Terminated }
+import akka.actor.{ ActorRef, ActorSystem, Props }
 import hmda.model.fi.SubmissionId
 import hmda.persistence.institutions.{ FilingPersistence, InstitutionPersistence, SubmissionPersistence }
 import hmda.persistence.model.HmdaSupervisorActor

persistence/src/test/scala/hmda/persistence/institutions/InstitutionPersistenceSpec.scala

@@ -1,10 +1,6 @@
 package hmda.persistence.institutions
 
-import akka.testkit.{ EventFilter, TestProbe }
-import hmda.model.institution.Agency.CFPB
-import hmda.model.institution.ExternalIdType.{ FederalTaxId, RssdId, UndeterminedExternalId }
-import hmda.model.institution.InstitutionType.Bank
-import hmda.model.institution._
+import akka.testkit.TestProbe
 import hmda.persistence.demo.DemoData
 import hmda.persistence.institutions.InstitutionPersistence._
 import hmda.persistence.messages.CommonMessages.GetState

persistence/src/test/scala/hmda/persistence/institutions/SubmissionPersistenceSpec.scala

@@ -1,6 +1,6 @@
 package hmda.persistence.institutions
 
-import akka.testkit.{ EventFilter, TestProbe }
+import akka.testkit.TestProbe
 import hmda.model.fi._
 import hmda.persistence.messages.CommonMessages.GetState
 import hmda.persistence.demo.DemoData

persistence/src/test/scala/hmda/persistence/processing/HmdaFileValidatorSpec.scala

@@ -1,6 +1,6 @@
 package hmda.persistence.processing
 
-import akka.actor.{ ActorRef, ActorSystem }
+import akka.actor.ActorRef
 import akka.testkit.TestProbe
 import com.typesafe.config.ConfigFactory
 import hmda.model.fi.SubmissionId

persistence/src/test/scala/hmda/persistence/processing/HmdaFilingSpec.scala

@@ -7,7 +7,6 @@ import hmda.persistence.messages.CommonMessages.GetState
 import hmda.persistence.messages.events.processing.CommonHmdaValidatorEvents.LarValidated
 import hmda.persistence.model.ActorSpec
 import hmda.persistence.processing.HmdaFiling._
-import hmda.persistence.processing.HmdaFileValidator._
 
 class HmdaFilingSpec extends ActorSpec with LarGenerators {
 

query/src/main/scala/hmda/query/HmdaQuerySupervisor.scala

@@ -3,7 +3,6 @@ package hmda.query
 import akka.actor.{ ActorRef, ActorSystem, Props }
 import akka.pattern.ask
 import akka.util.Timeout
-import com.typesafe.config.ConfigFactory
 import hmda.persistence.model.HmdaSupervisorActor
 import hmda.query.projections.filing.HmdaFilingDBProjection.CreateSchema
 import hmda.query.view.filing.HmdaFilingView

query/src/main/scala/hmda/query/repository/filing/FilingCassandraRepository.scala

@@ -1,8 +1,8 @@
 package hmda.query.repository.filing
 
 import akka.{ Done, NotUsed }
-import akka.stream.alpakka.cassandra.scaladsl.{ CassandraSink, CassandraSource }
-import akka.stream.scaladsl.{ Flow, Sink, Source }
+import akka.stream.alpakka.cassandra.scaladsl.CassandraSink
+import akka.stream.scaladsl.{ Flow, Source }
 import com.datastax.driver.core._
 import hmda.query.model.filing.LoanApplicationRegisterQuery
 import hmda.query.projections.ProjectionRuntime

query/src/main/scala/hmda/query/repository/filing/FilingComponent.scala

@@ -1,22 +1,16 @@
 package hmda.query.repository.filing
 
 import akka.NotUsed
-import akka.actor.ActorSystem
-import akka.stream.ActorMaterializer
-import akka.stream.scaladsl.{ Sink, Source }
+import akka.stream.scaladsl.Source
 import com.typesafe.config.ConfigFactory
-import hmda.model.fi.SubmissionId
 import hmda.query.DbConfiguration._
-import hmda.query.model.filing.{ LoanApplicationRegisterQuery, LoanApplicationRegisterTotal, ModifiedLoanApplicationRegister }
+import hmda.query.model.filing.{ LoanApplicationRegisterQuery, ModifiedLoanApplicationRegister }
 import hmda.query.repository.{ Repository, TableRepository }
 import slick.basic.{ DatabaseConfig, DatabasePublisher }
 import slick.jdbc.JdbcProfile
 import slick.collection.heterogeneous._
 import slick.collection.heterogeneous.syntax._
 
-import scala.concurrent.{ ExecutionContext, Future }
-import scala.util.Try
-
 trait FilingComponent {
   import config.profile.api._
 
@@ -621,14 +615,14 @@ trait FilingComponent {
 
     def findByInstitutionId(instId: String) = db.run(table.filter(_.institutionId === instId).result)
 
-    private def findByInstitutionIdStream(instId: String, period: String)(implicit ec: ExecutionContext): DatabasePublisher[ModifiedLoanApplicationRegister] = {
+    private def findByInstitutionIdStream(instId: String, period: String): DatabasePublisher[ModifiedLoanApplicationRegister] = {
       val disableAutocommit = SimpleDBIO(_.connection.setAutoCommit(false))
       val query = table.filter(x => x.institutionId === instId && x.period === period)
       val action = query.result.withStatementParameters(fetchSize = queryFetchSize)
       db.stream(disableAutocommit andThen action)
     }
 
-    def findByInstitutionIdSource(instId: String, period: String)(implicit ec: ExecutionContext): Source[ModifiedLoanApplicationRegister, NotUsed] =
+    def findByInstitutionIdSource(instId: String, period: String): Source[ModifiedLoanApplicationRegister, NotUsed] =
       Source.fromPublisher(findByInstitutionIdStream(instId, period))
   }