Completed Filings stay in 'Completed' status

Author: schbetsy

persistence/src/main/scala/hmda/persistence/institutions/FilingPersistence.scala

@@ -57,6 +57,9 @@ class FilingPersistence(institutionId: String) extends HmdaPersistentActor {
 
     case UpdateFilingStatus(period, newStatus) =>
       state.filings.find(f => f.period == period) match {
+        case Some(filing) if filing.status == Completed =>
+          sender() ! None
+          log.debug(s"$period Filing for Institution $institutionId is already Completed. Not updating status")
         case Some(filing) =>
           val startTime = if (newStatus == InProgress) System.currentTimeMillis else filing.start
           val endTime = if (newStatus == Completed) System.currentTimeMillis else filing.end

persistence/src/test/scala/hmda/persistence/institutions/FilingPersistenceSpec.scala

@@ -10,7 +10,7 @@ class FilingPersistenceSpec extends ActorSpec {
 
   val filingsActor = createFilings("12345", system)
 
-  val sample1 = Filing("2016", "12345", Completed, filingRequired = true, 1483287071000L, 1514736671000L)
+  val sample1 = Filing("2016", "12345", Cancelled, filingRequired = true, 1483287071000L, 1514736671000L)
   val sample2 = Filing("2017", "12345", NotStarted, filingRequired = true, 0L, 0L)
 
   val probe = TestProbe()
@@ -38,8 +38,8 @@ class FilingPersistenceSpec extends ActorSpec {
 
   "UpdateFilingStatus" must {
     "update status of filing for given period" in {
-      val expected = sample1.copy(status = Cancelled)
-      probe.send(filingsActor, UpdateFilingStatus("2016", Cancelled))
+      val expected = sample1.copy(status = NotStarted)
+      probe.send(filingsActor, UpdateFilingStatus("2016", NotStarted))
       probe.expectMsg(Some(expected))
       probe.send(filingsActor, GetFilingByPeriod("2016"))
       probe.expectMsg(expected)
@@ -62,6 +62,10 @@ class FilingPersistenceSpec extends ActorSpec {
       comp.start mustBe startTime
       comp.end must be > 0L
     }
+    "not update if filing status is already 'Completed'" in {
+      probe.send(filingsActor, UpdateFilingStatus("2017", InProgress))
+      probe.expectMsg(None)
+    }
   }
 
 }