Fix submission fsm test

Author: jmarin

persistence-model/src/main/scala/hmda/persistence/model/HmdaActor.scala

@@ -6,7 +6,7 @@ trait HmdaActor extends Actor with ActorLogging {
 
   override def preStart(): Unit = {
     log.info(s"Actor started at ${self.path}")
-    log.info("Thread name for actor: " + Thread.currentThread().getName)
+    //log.info("Thread name for actor: " + Thread.currentThread().getName)
   }
 
   override def postStop(): Unit = {

persistence/src/main/scala/hmda/persistence/HmdaSupervisor.scala

@@ -81,9 +81,7 @@ class HmdaSupervisor(validationStats: ActorRef) extends HmdaSupervisorActor {
 
   private def createSubmissions(name: String, institutionId: String, period: String): ActorRef = {
     val sId = s"$name-$institutionId-$period"
-    val actor = context.actorOf(SubmissionPersistence
-      .props(institutionId, period)
-      .withDispatcher("persistence-dispatcher"), sId)
+    val actor = context.actorOf(SubmissionPersistence.props(institutionId, period).withDispatcher("persistence-dispatcher"), sId)
     supervise(actor, sId)
   }
 

persistence/src/main/scala/hmda/persistence/institutions/SubmissionPersistence.scala

@@ -68,6 +68,7 @@ class SubmissionPersistence(institutionId: String, period: String) extends HmdaP
       val newSubmission = Submission(submissionId, Created, System.currentTimeMillis(), 0L)
       persist(SubmissionCreated(newSubmission)) { e =>
         updateState(e)
+        log.debug(s"Submission Created with Submission Id: ${submissionId.toString}")
         sender() ! Some(newSubmission)
       }
 

persistence/src/test/resources/application.conf

@@ -15,3 +15,20 @@ akka.test.single-expect-default = 10s
 hmda {
   isDemo = false
 }
+
+persistence-dispatcher {
+  type = Dispatcher
+  executor = "fork-join-executor"
+  fork-join-executor {
+    # Min number of threads to cap factor-based parallelism number to
+    parallelism-min = 2
+    # Parallelism (threads) ... ceil(available processors * factor)
+    parallelism-factor = 2.0
+    # Max number of threads to cap factor-based parallelism number to
+    parallelism-max = 10
+  }
+  # Throughput defines the maximum number of messages to be
+  # processed per actor before the thread jumps to the next actor.
+  # Set to 1 for as fair as possible.
+  throughput = 100
+}

persistence/src/test/scala/hmda/persistence/processing/SubmissionFSMSpec.scala

@@ -4,12 +4,19 @@ import akka.actor.ActorRef
 import akka.testkit.TestProbe
 import hmda.model.fi.{ Submission, SubmissionId }
 import hmda.persistence.HmdaSupervisor
+import hmda.persistence.institutions.SubmissionPersistence
+import hmda.persistence.institutions.SubmissionPersistence.CreateSubmission
 import hmda.persistence.messages.CommonMessages.GetState
 import hmda.persistence.model.ActorSpec
 import hmda.persistence.processing.ProcessingMessages._
 import hmda.persistence.processing.SubmissionFSM._
 import hmda.validation.ValidationStats
 
+import scala.concurrent.Await
+import scala.concurrent.duration._
+import akka.pattern.ask
+import akka.util.Timeout
+
 class SubmissionFSMSpec extends ActorSpec {
 
   val probe = TestProbe()
@@ -19,6 +26,15 @@ class SubmissionFSMSpec extends ActorSpec {
   val validationStats = ValidationStats.createValidationStats(system)
   val supervisor = HmdaSupervisor.createSupervisor(system, validationStats)
 
+  val duration = 5.seconds
+  implicit val timeout = Timeout(duration)
+
+  override def beforeAll(): Unit = {
+    super.beforeAll()
+    val submissionPersistence = system.actorOf(SubmissionPersistence.props(submissionId.institutionId, submissionId.period))
+    Await.result(submissionPersistence ? CreateSubmission, duration)
+  }
+
   "Submission Finite State Machine" must {
     "transition through states" in {
       val fsm = actorRef()